common/fs/file: Update documentation for {Append/Write}StringToFile

This fixes errors when a file is being opened for write/append access, but the file does not exist initially.

These functions were not respecting the FileAccessMode which specify that the file will be created if it does not exist.

.gitmodules

@@ -18,7 +18,7 @@
 	url = https://github.com/libusb/libusb.git
 [submodule "discord-rpc"]
     path = externals/discord-rpc
-    url = https://github.com/discordapp/discord-rpc.git
+    url = https://github.com/discord/discord-rpc.git
 [submodule "Vulkan-Headers"]
     path = externals/Vulkan-Headers
     url = https://github.com/KhronosGroup/Vulkan-Headers.git

src/common/fs/file.cpp

@@ -172,23 +172,13 @@ std::string ReadStringFromFile(const std::filesystem::path& path, FileType type)
 
 size_t WriteStringToFile(const std::filesystem::path& path, FileType type,
                          std::string_view string) {
-    if (!IsFile(path)) {
-        return 0;
-    }
-
     IOFile io_file{path, FileAccessMode::Write, type};
-
     return io_file.WriteString(string);
 }
 
 size_t AppendStringToFile(const std::filesystem::path& path, FileType type,
                           std::string_view string) {
-    if (!IsFile(path)) {
-        return 0;
-    }
-
     IOFile io_file{path, FileAccessMode::Append, type};
-
     return io_file.WriteString(string);
 }
 

src/common/fs/file.h

@@ -72,6 +72,7 @@ template <typename Path>
 /**
  * Writes a string to a file at path and returns the number of characters successfully written.
  * If a file already exists at path, its contents will be erased.
+ * If a file does not exist at path, it creates and opens a new empty file for writing.
  * If the filesystem object at path is not a file, this function returns 0.
  *
  * @param path Filesystem path
@@ -95,6 +96,7 @@ template <typename Path>
 
 /**
  * Appends a string to a file at path and returns the number of characters successfully written.
+ * If a file does not exist at path, it creates and opens a new empty file for appending.
  * If the filesystem object at path is not a file, this function returns 0.
  *
  * @param path Filesystem path

src/common/fs/fs.cpp

@@ -135,9 +135,13 @@ std::shared_ptr<IOFile> FileOpen(const fs::path& path, FileAccessMode mode, File
         return nullptr;
     }
 
-    if (!IsFile(path)) {
-        LOG_ERROR(Common_Filesystem, "Filesystem object at path={} is not a file",
-                  PathToUTF8String(path));
+    const bool needs_existing_file =
+        mode == FileAccessMode::Read || mode == FileAccessMode::ReadWrite;
+    if (needs_existing_file && !IsFile(path)) {
+        LOG_ERROR(Common_Filesystem,
+                  "Filesystem object at path={} is not a file."
+                  "FileAccessMode={} requires a file to exist in order to be accessed",
+                  PathToUTF8String(path), mode);
         return nullptr;
     }
 

src/video_core/vulkan_common/vulkan_debug_callback.cpp

@@ -12,6 +12,14 @@ VkBool32 Callback(VkDebugUtilsMessageSeverityFlagBitsEXT severity,
                   VkDebugUtilsMessageTypeFlagsEXT type,
                   const VkDebugUtilsMessengerCallbackDataEXT* data,
                   [[maybe_unused]] void* user_data) {
+    // Skip logging known false-positive validation errors
+    switch (static_cast<u32>(data->messageIdNumber)) {
+    case 0x682a878au: // VUID-vkCmdBindVertexBuffers2EXT-pBuffers-parameter
+    case 0x99fb7dfdu: // UNASSIGNED-RequiredParameter (vkCmdBindVertexBuffers2EXT pBuffers[0])
+        return VK_FALSE;
+    default:
+        break;
+    }
     const std::string_view message{data->pMessage};
     if (severity & VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT) {
         LOG_CRITICAL(Render_Vulkan, "{}", message);