mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-02-12 12:28:42 +00:00
### Changed
This pr split the old `edgeless-selected-rect` into four focused modules:
- `edgeless-selected-rect`: Provide an entry point for user operation on view layer only, no further logic here.
- `GfxViewInteractionExtension`: Allow you to plug in custom resize/rotate behaviors for block or canvas element. If you don’t register an extension, it falls back to the default behaviours.
- `InteractivityManager`: Provide the API that accepts resize/rotate requests, invokes any custom behaviors you’ve registered, tracks the lifecycle and intermediate state, then hands off to the math engine.
- `ResizeController`: A pure math engine that listens for pointer moves and pointer ups and calculates new sizes, positions, and angles. It doesn’t call any business APIs.
### Customizing an element’s resize/rotate behavior
Call `GfxViewInteractionExtension` with the element’s flavour or type plus a config object. In the config you can define:
- `resizeConstraint` (min/max width & height, lock ratio)
- `handleResize(context)` method that returns an object containing `beforeResize`、`onResizeStart`、`onResizeMove`、`onResizeEnd`
- `handleRotate(context)` method that returns an object containing `beforeRotate`、`onRotateStart`、`onRotateMove`、`onRotateEnd`
```typescript
import { GfxViewInteractionExtension } from '@blocksuite/std/gfx';
GfxViewInteractionExtension(
flavourOrElementType,
{
resizeConstraint: {
minWidth,
maxWidth,
lockRatio,
minHeight,
maxHeight
},
handleResize(context) {
return {
beforeResize(context) {},
onResizeStart(context) {},
onResizeMove(context) {},
onResizeEnd(context) {}
};
},
handleRotate(context) {
return {
beforeRotate(context) {},
onRotateStart(context) {},
onRotateMove(context) {},
onRotateEnd(context) {}
};
}
}
);
```
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **New Features**
- Added interaction extensions for edgeless variants of attachment, bookmark, edgeless text, embedded docs, images, notes, frames, AI chat blocks, and various embed blocks (Figma, GitHub, HTML, iframe, Loom, YouTube).
- Introduced interaction extensions for graphical elements including connectors, groups, mind maps, shapes, and text, supporting constrained resizing and rotation disabling where applicable.
- Implemented a unified interaction extension framework enabling configurable resize and rotate lifecycle handlers.
- Enhanced autocomplete overlay behavior based on selection context.
- **Refactor**
- Removed legacy resize manager and element-specific resize/rotate logic, replacing with a centralized, extensible interaction system.
- Simplified resize handle rendering to a data-driven approach with improved cursor management.
- Replaced complex cursor rotation calculations with fixed-angle mappings for resize handles.
- Streamlined selection rectangle component to use interactivity services for resize and rotate handling.
- **Bug Fixes**
- Fixed connector update triggers to reduce unnecessary updates.
- Improved resize constraints enforcement and interaction state tracking.
- **Tests**
- Refined end-to-end tests to use higher-level resize utilities and added finer-grained assertions on element dimensions.
- Enhanced mouse movement granularity in drag tests for better simulation fidelity.
- **Chores**
- Added new workspace dependencies and project references for the interaction framework modules.
- Extended public API exports to include new interaction types and extensions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
151 lines
4.3 KiB
TypeScript
151 lines
4.3 KiB
TypeScript
import { expect, type Page } from '@playwright/test';
|
|
|
|
import {
|
|
addNote,
|
|
locatorScalePanelButton,
|
|
selectNoteInEdgeless,
|
|
switchEditorMode,
|
|
triggerComponentToolbarAction,
|
|
zoomResetByKeyboard,
|
|
} from '../../utils/actions/edgeless.js';
|
|
import {
|
|
copyByKeyboard,
|
|
pasteByKeyboard,
|
|
selectAllByKeyboard,
|
|
} from '../../utils/actions/keyboard.js';
|
|
import {
|
|
enterPlaygroundRoom,
|
|
initEmptyEdgelessState,
|
|
waitNextFrame,
|
|
} from '../../utils/actions/misc.js';
|
|
import { assertRectExist } from '../../utils/asserts.js';
|
|
import { test } from '../../utils/playwright.js';
|
|
|
|
async function setupAndAddNote(page: Page) {
|
|
await enterPlaygroundRoom(page);
|
|
await initEmptyEdgelessState(page);
|
|
await switchEditorMode(page);
|
|
await zoomResetByKeyboard(page);
|
|
const noteId = await addNote(page, 'hello world', 100, 200);
|
|
await page.mouse.click(0, 0);
|
|
return noteId;
|
|
}
|
|
|
|
async function openScalePanel(page: Page, noteId: string) {
|
|
await selectNoteInEdgeless(page, noteId);
|
|
await triggerComponentToolbarAction(page, 'changeNoteScale');
|
|
await waitNextFrame(page);
|
|
const scalePanel = page.locator('.scale-menu');
|
|
await expect(scalePanel).toBeVisible();
|
|
return scalePanel;
|
|
}
|
|
|
|
async function checkNoteScale(
|
|
page: Page,
|
|
noteId: string,
|
|
expectedScale: number,
|
|
expectedType: 'equal' | 'greater' | 'less' = 'equal'
|
|
) {
|
|
const edgelessNote = page.locator(
|
|
`affine-edgeless-note[data-block-id="${noteId}"]`
|
|
);
|
|
const noteContainer = edgelessNote.getByTestId('edgeless-note-container');
|
|
const style = await noteContainer.getAttribute('style');
|
|
|
|
if (!style) {
|
|
throw new Error('Style attribute not found');
|
|
}
|
|
|
|
const scaleMatch = style.match(/transform:\s*scale\(([\d.]+)\)/);
|
|
if (!scaleMatch) {
|
|
throw new Error('Scale transform not found in style');
|
|
}
|
|
|
|
const actualScale = parseFloat(scaleMatch[1]);
|
|
|
|
switch (expectedType) {
|
|
case 'equal':
|
|
expect(actualScale).toBeCloseTo(expectedScale, 2);
|
|
break;
|
|
case 'greater':
|
|
expect(actualScale).toBeGreaterThan(expectedScale);
|
|
break;
|
|
case 'less':
|
|
expect(actualScale).toBeLessThan(expectedScale);
|
|
}
|
|
}
|
|
|
|
test.describe('note scale', () => {
|
|
test('Note scale can be changed by scale panel button', async ({ page }) => {
|
|
const noteId = await setupAndAddNote(page);
|
|
await openScalePanel(page, noteId);
|
|
|
|
const scale150 = locatorScalePanelButton(page, 50);
|
|
await scale150.click();
|
|
|
|
await checkNoteScale(page, noteId, 0.5);
|
|
});
|
|
|
|
test('Note scale can be changed by scale panel input', async ({ page }) => {
|
|
const noteId = await setupAndAddNote(page);
|
|
const scalePanel = await openScalePanel(page, noteId);
|
|
|
|
const scaleInput = scalePanel.locator('input');
|
|
await scaleInput.click();
|
|
await page.keyboard.type('50');
|
|
await page.keyboard.press('Enter');
|
|
|
|
await checkNoteScale(page, noteId, 0.5);
|
|
});
|
|
|
|
test('Note scale input support copy paste', async ({ page }) => {
|
|
const noteId = await setupAndAddNote(page);
|
|
const scalePanel = await openScalePanel(page, noteId);
|
|
|
|
const scaleInput = scalePanel.locator('input');
|
|
await scaleInput.click();
|
|
await page.keyboard.type('50');
|
|
await selectAllByKeyboard(page);
|
|
await copyByKeyboard(page);
|
|
await page.mouse.click(0, 0);
|
|
|
|
await selectNoteInEdgeless(page, noteId);
|
|
await triggerComponentToolbarAction(page, 'changeNoteScale');
|
|
await waitNextFrame(page);
|
|
|
|
await scaleInput.click();
|
|
await pasteByKeyboard(page);
|
|
await page.keyboard.press('Enter');
|
|
|
|
await checkNoteScale(page, noteId, 0.5);
|
|
});
|
|
|
|
test('Note scale can be changed by shift drag', async ({ page }) => {
|
|
const noteId = await setupAndAddNote(page);
|
|
await selectNoteInEdgeless(page, noteId);
|
|
|
|
const edgelessNote = page.locator(
|
|
`affine-edgeless-note[data-block-id="${noteId}"]`
|
|
);
|
|
const noteRect = await edgelessNote.boundingBox();
|
|
assertRectExist(noteRect);
|
|
await page.mouse.move(
|
|
noteRect.x + noteRect.width,
|
|
noteRect.y + noteRect.height
|
|
);
|
|
await page.keyboard.down('Shift');
|
|
await page.mouse.down();
|
|
await page.mouse.move(
|
|
noteRect.x + noteRect.width * 2,
|
|
noteRect.y + noteRect.height * 2,
|
|
{
|
|
steps: 10,
|
|
}
|
|
);
|
|
await page.mouse.up();
|
|
|
|
// expect style scale to be greater than 1
|
|
await checkNoteScale(page, noteId, 1, 'greater');
|
|
});
|
|
});
|