mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-09-05 16:30:33 +08:00
feat: add select all action to trash (#15556)
<img width="284" height="132" alt="image" src="https://github.com/user-attachments/assets/a11f1919-ac91-4f87-b03d-4fab6e8cba7e" /> ## Description Add a select-all action next to the Trash page title after document multi-selection starts. - Select every unique document ID from the explorer groups, including items outside the rendered viewport. - Change the action to Clear selection when every Trash document is selected. - Reuse the existing Trash bulk-operation permissions without introducing artificial grouping. ## Testing - Trash page Playwright E2E: 2 passed - Targeted TypeScript project build - lint-staged - lint:ox - oxfmt --check - git diff --check ## Checklist - [x] I have signed the AFFiNE Contributor License Agreement - [x] The PR targets the canary branch and its title follows Conventional Commits - [x] Tests are added or updated where it makes sense - [ ] Full yarn lint and yarn typecheck pass locally <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a select-all and clear-selection control to the Trash view when multiple documents can be managed. - Select-all actions now update the document selection toolbar. - **Bug Fixes** - Improved Trash view controls for users with administrator or owner permissions. - **Tests** - Added end-to-end coverage for selecting, selecting all, and clearing multiple trashed documents. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
@@ -8,7 +8,23 @@ import {
|
||||
waitForEditorLoad,
|
||||
} from '@affine-test/kit/utils/page-logic';
|
||||
import { getCurrentDocIdFromUrl } from '@affine-test/kit/utils/url';
|
||||
import { expect } from '@playwright/test';
|
||||
import { expect, type Page } from '@playwright/test';
|
||||
|
||||
const movePageToTrash = async (page: Page, docId: string) => {
|
||||
await getPageOperationButton(page, docId).click();
|
||||
await page.getByTestId('doc-list-operation-trash').click();
|
||||
await expect(page.getByRole('dialog', { name: 'Delete doc?' })).toBeVisible();
|
||||
await page.getByRole('button', { name: 'Delete' }).click();
|
||||
};
|
||||
|
||||
const createAndTrashPage = async (page: Page, title: string) => {
|
||||
await clickNewPageButton(page);
|
||||
await getBlockSuiteEditorTitle(page).click();
|
||||
await getBlockSuiteEditorTitle(page).fill(title);
|
||||
const docId = getCurrentDocIdFromUrl(page);
|
||||
await page.getByTestId('all-pages').click();
|
||||
await movePageToTrash(page, docId);
|
||||
};
|
||||
|
||||
test('New a page , then delete it in all pages, finally find it in trash', async ({
|
||||
page,
|
||||
@@ -24,13 +40,7 @@ test('New a page , then delete it in all pages, finally find it in trash', async
|
||||
const cell = await getPageByTitle(page, 'this is a new page to delete');
|
||||
await expect(cell).toBeVisible();
|
||||
|
||||
await getPageOperationButton(page, newPageId).click();
|
||||
const deleteBtn = page.getByTestId('doc-list-operation-trash');
|
||||
await deleteBtn.click();
|
||||
const confirmTip = page.getByRole('dialog', { name: 'Delete doc?' });
|
||||
await expect(confirmTip).toBeVisible();
|
||||
|
||||
await page.getByRole('button', { name: 'Delete' }).click();
|
||||
await movePageToTrash(page, newPageId);
|
||||
|
||||
await page.getByTestId('trash-page').click();
|
||||
await expect(page.getByText('this is a new page to delete')).toBeVisible();
|
||||
@@ -38,3 +48,32 @@ test('New a page , then delete it in all pages, finally find it in trash', async
|
||||
|
||||
expect(currentWorkspace.meta.flavour).toContain('local');
|
||||
});
|
||||
|
||||
test('select all trashed pages from the Trash title', async ({ page }) => {
|
||||
await openHomePage(page);
|
||||
await waitForEditorLoad(page);
|
||||
await createAndTrashPage(page, 'trash select all 1');
|
||||
await createAndTrashPage(page, 'trash select all 2');
|
||||
await page.getByTestId('trash-page').click();
|
||||
|
||||
const selectAllButton = page.getByTestId('trash-select-all');
|
||||
await expect(selectAllButton).not.toBeVisible();
|
||||
|
||||
await page
|
||||
.locator('[data-testid="doc-list-item"]')
|
||||
.first()
|
||||
.click({ modifiers: ['Shift'] });
|
||||
|
||||
await expect(selectAllButton).toHaveText('Select all');
|
||||
await selectAllButton.click();
|
||||
await expect(page.getByTestId('floating-toolbar')).toHaveText(
|
||||
'2 doc(s) selected'
|
||||
);
|
||||
await expect(selectAllButton).toHaveText('Clear selection');
|
||||
|
||||
await selectAllButton.click();
|
||||
await expect(page.getByTestId('floating-toolbar')).toHaveText(
|
||||
'0 doc(s) selected'
|
||||
);
|
||||
await expect(selectAllButton).toHaveText('Select all');
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user