feat: add select all action to trash (#15556)

<img width="284" height="132" alt="image"
src="https://github.com/user-attachments/assets/a11f1919-ac91-4f87-b03d-4fab6e8cba7e"
/>


## Description

Add a select-all action next to the Trash page title after document
multi-selection starts.

- Select every unique document ID from the explorer groups, including
items outside the rendered viewport.
- Change the action to Clear selection when every Trash document is
selected.
- Reuse the existing Trash bulk-operation permissions without
introducing artificial grouping.

## Testing

- Trash page Playwright E2E: 2 passed
- Targeted TypeScript project build
- lint-staged
- lint:ox
- oxfmt --check
- git diff --check

## Checklist

- [x] I have signed the AFFiNE Contributor License Agreement
- [x] The PR targets the canary branch and its title follows
Conventional Commits
- [x] Tests are added or updated where it makes sense
- [ ] Full yarn lint and yarn typecheck pass locally

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added a select-all and clear-selection control to the Trash view when
multiple documents can be managed.
  - Select-all actions now update the document selection toolbar.

- **Bug Fixes**
- Improved Trash view controls for users with administrator or owner
permissions.

- **Tests**
- Added end-to-end coverage for selecting, selecting all, and clearing
multiple trashed documents.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Whitewater
2026-09-02 21:01:45 +08:00
committed by GitHub
parent ea0e477033
commit f78e46f90e
3 changed files with 98 additions and 17 deletions
@@ -1,4 +1,5 @@
import { cssVar } from '@toeverything/theme';
import { cssVarV2 } from '@toeverything/theme/v2';
import { style } from '@vanilla-extract/css';
export const trashTitle = style({
display: 'flex',
@@ -19,3 +20,11 @@ export const trashIcon = style({
color: cssVar('iconColor'),
fontSize: cssVar('fontH5'),
});
export const selectAllButton = style({
height: 24,
padding: '2px 4px',
color: cssVarV2.text.secondary,
fontSize: 12,
fontWeight: 400,
lineHeight: '20px',
});
@@ -1,4 +1,4 @@
import { toast, useConfirmModal } from '@affine/component';
import { Button, toast, useConfirmModal } from '@affine/component';
import {
createDocExplorerContext,
DocExplorerContext,
@@ -12,7 +12,7 @@ import { WorkspacePermissionService } from '@affine/core/modules/permissions';
import { useI18n } from '@affine/i18n';
import { DeleteIcon } from '@blocksuite/icons/rc';
import { useLiveData, useService } from '@toeverything/infra';
import { useCallback, useEffect, useState } from 'react';
import { useCallback, useContext, useEffect, useMemo, useState } from 'react';
import {
useIsActiveView,
@@ -24,14 +24,48 @@ import {
import { EmptyPageList } from './page-list-empty';
import * as styles from './trash-page.css';
const TrashHeader = () => {
const TrashHeader = ({ canManageTrash }: { canManageTrash: boolean }) => {
const t = useI18n();
const contextValue = useContext(DocExplorerContext);
const groups = useLiveData(contextValue.groups$);
const selectMode = useLiveData(contextValue.selectMode$);
const selectedDocIds = useLiveData(contextValue.selectedDocIds$);
const allDocIds = useMemo(
() => Array.from(new Set(groups.flatMap(group => group.items))),
[groups]
);
const allSelected = useMemo(() => {
const selectedDocIdSet = new Set(selectedDocIds);
return (
allDocIds.length > 0 && allDocIds.every(id => selectedDocIdSet.has(id))
);
}, [allDocIds, selectedDocIds]);
const handleToggleSelectAll = useCallback(() => {
contextValue.selectedDocIds$.next(allSelected ? [] : allDocIds);
contextValue.prevCheckAnchorId$?.next(null);
}, [allDocIds, allSelected, contextValue]);
return (
<Header
left={
<div className={styles.trashTitle}>
<DeleteIcon className={styles.trashIcon} />
{t['com.affine.workspaceSubPath.trash']()}
{selectMode && canManageTrash && allDocIds.length > 0 ? (
<Button
className={styles.selectAllButton}
data-testid="trash-select-all"
onClick={handleToggleSelectAll}
size="custom"
variant="plain"
>
{allSelected
? t['com.affine.page.group-header.clear']()
: t['com.affine.page.group-header.select-all']()}
</Button>
) : null}
</div>
}
/>
@@ -69,6 +103,7 @@ export const TrashPage = () => {
const isAdmin = useLiveData(permissionService.permission.isAdmin$);
const isOwner = useLiveData(permissionService.permission.isOwner$);
const canManageTrash = !!isAdmin || !!isOwner;
const groups = useLiveData(explorerContextValue.groups$);
const isEmpty =
groups.length === 0 ||
@@ -171,7 +206,7 @@ export const TrashPage = () => {
<ViewTitle title={t['Trash']()} />
<ViewIcon icon={'trash'} />
<ViewHeader>
<TrashHeader />
<TrashHeader canManageTrash={canManageTrash} />
</ViewHeader>
<ViewBody>
<div className={styles.body}>
@@ -179,11 +214,9 @@ export const TrashPage = () => {
<EmptyPageList type="trash" />
) : (
<DocsExplorer
disableMultiDelete={!isAdmin && !isOwner}
onRestore={isAdmin || isOwner ? handleMultiRestore : undefined}
onDelete={
isAdmin || isOwner ? onConfirmPermanentlyDelete : undefined
}
disableMultiDelete={!canManageTrash}
onRestore={canManageTrash ? handleMultiRestore : undefined}
onDelete={canManageTrash ? onConfirmPermanentlyDelete : undefined}
/>
)}
</div>
@@ -8,7 +8,23 @@ import {
waitForEditorLoad,
} from '@affine-test/kit/utils/page-logic';
import { getCurrentDocIdFromUrl } from '@affine-test/kit/utils/url';
import { expect } from '@playwright/test';
import { expect, type Page } from '@playwright/test';
const movePageToTrash = async (page: Page, docId: string) => {
await getPageOperationButton(page, docId).click();
await page.getByTestId('doc-list-operation-trash').click();
await expect(page.getByRole('dialog', { name: 'Delete doc?' })).toBeVisible();
await page.getByRole('button', { name: 'Delete' }).click();
};
const createAndTrashPage = async (page: Page, title: string) => {
await clickNewPageButton(page);
await getBlockSuiteEditorTitle(page).click();
await getBlockSuiteEditorTitle(page).fill(title);
const docId = getCurrentDocIdFromUrl(page);
await page.getByTestId('all-pages').click();
await movePageToTrash(page, docId);
};
test('New a page , then delete it in all pages, finally find it in trash', async ({
page,
@@ -24,13 +40,7 @@ test('New a page , then delete it in all pages, finally find it in trash', async
const cell = await getPageByTitle(page, 'this is a new page to delete');
await expect(cell).toBeVisible();
await getPageOperationButton(page, newPageId).click();
const deleteBtn = page.getByTestId('doc-list-operation-trash');
await deleteBtn.click();
const confirmTip = page.getByRole('dialog', { name: 'Delete doc?' });
await expect(confirmTip).toBeVisible();
await page.getByRole('button', { name: 'Delete' }).click();
await movePageToTrash(page, newPageId);
await page.getByTestId('trash-page').click();
await expect(page.getByText('this is a new page to delete')).toBeVisible();
@@ -38,3 +48,32 @@ test('New a page , then delete it in all pages, finally find it in trash', async
expect(currentWorkspace.meta.flavour).toContain('local');
});
test('select all trashed pages from the Trash title', async ({ page }) => {
await openHomePage(page);
await waitForEditorLoad(page);
await createAndTrashPage(page, 'trash select all 1');
await createAndTrashPage(page, 'trash select all 2');
await page.getByTestId('trash-page').click();
const selectAllButton = page.getByTestId('trash-select-all');
await expect(selectAllButton).not.toBeVisible();
await page
.locator('[data-testid="doc-list-item"]')
.first()
.click({ modifiers: ['Shift'] });
await expect(selectAllButton).toHaveText('Select all');
await selectAllButton.click();
await expect(page.getByTestId('floating-toolbar')).toHaveText(
'2 doc(s) selected'
);
await expect(selectAllButton).toHaveText('Clear selection');
await selectAllButton.click();
await expect(page.getByTestId('floating-toolbar')).toHaveText(
'0 doc(s) selected'
);
await expect(selectAllButton).toHaveText('Select all');
});