mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-07-01 17:50:50 +08:00
fix(editor): improve tests stability (#14971)
#### PR Dependency Tree * **PR #14971** 👈 This tree was auto-generated by [Charcoal](https://github.com/danerwilliams/charcoal) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Improved shape selection reliability in edge case testing scenarios * Enhanced rich text editor focusing logic with better synchronization for inline editor state validation <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/toeverything/AFFiNE/pull/14971) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
@@ -376,28 +376,19 @@ export async function setEdgelessTool(
|
||||
'shape',
|
||||
false
|
||||
);
|
||||
const shapeToolBox = await shapeToolButton.boundingBox();
|
||||
if (!shapeToolBox) {
|
||||
throw new Error('shapeToolBox is not found');
|
||||
}
|
||||
|
||||
await page.mouse.click(shapeToolBox.x + 2, shapeToolBox.y + 2);
|
||||
await shapeToolButton.click({ position: { x: 2, y: 2 } });
|
||||
|
||||
const shapeMenu = page.locator('edgeless-shape-menu');
|
||||
if ((await shapeMenu.count()) === 0 && shape === Shape.Square) {
|
||||
break;
|
||||
}
|
||||
await expect(shapeMenu).toBeVisible();
|
||||
|
||||
const squareShapeButton = shapeMenu
|
||||
.locator('edgeless-tool-icon-button')
|
||||
.filter({ hasText: shape });
|
||||
await expect(squareShapeButton).toBeVisible();
|
||||
const squareShapeBox = await squareShapeButton.boundingBox();
|
||||
if (!squareShapeBox) {
|
||||
throw new Error('squareShapeBox is not found');
|
||||
}
|
||||
await page.mouse.click(
|
||||
squareShapeBox.x + squareShapeBox.width / 2,
|
||||
squareShapeBox.y + squareShapeBox.height / 2
|
||||
);
|
||||
await squareShapeButton.click();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -552,6 +552,27 @@ export async function focusRichText(
|
||||
await expect(locator).toBeVisible();
|
||||
// need to set `force` to true when clicking on `affine-selected-blocks`
|
||||
await locator.click({ force: true, position: options?.clickPosition });
|
||||
await expect
|
||||
.poll(() =>
|
||||
page.evaluate(
|
||||
([i, currentEditorIndex]) => {
|
||||
const editorHost =
|
||||
document.querySelectorAll('editor-host')[currentEditorIndex];
|
||||
const richText =
|
||||
editorHost?.querySelectorAll<RichText>('rich-text')[i];
|
||||
const inlineEditor = richText?.inlineEditor;
|
||||
if (!inlineEditor) {
|
||||
return false;
|
||||
}
|
||||
if (inlineEditor.getInlineRange() === null) {
|
||||
inlineEditor.focusIndex(0);
|
||||
}
|
||||
return inlineEditor.getInlineRange() !== null;
|
||||
},
|
||||
[i, currentEditorIndex]
|
||||
)
|
||||
)
|
||||
.toBe(true);
|
||||
}
|
||||
|
||||
export async function focusRichTextEnd(page: Page, i = 0) {
|
||||
|
||||
Reference in New Issue
Block a user