mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-07-15 17:16:16 +08:00
fix(core): adjust error boundary level (#5493)
Allowing showing page title for page detail when page throws error. 
This commit is contained in:
@@ -79,7 +79,7 @@ const ModalContainer = ({
|
||||
withoutCloseButton
|
||||
contentOptions={contentOptions}
|
||||
>
|
||||
<AffineErrorBoundary>{children}</AffineErrorBoundary>
|
||||
{children}
|
||||
</Modal>
|
||||
);
|
||||
};
|
||||
@@ -138,12 +138,14 @@ const HistoryEditorPreview = ({
|
||||
</div>
|
||||
|
||||
{snapshotPage ? (
|
||||
<BlockSuiteEditor
|
||||
className={styles.editor}
|
||||
mode={mode}
|
||||
page={snapshotPage}
|
||||
onModeChange={onModeChange}
|
||||
/>
|
||||
<AffineErrorBoundary>
|
||||
<BlockSuiteEditor
|
||||
className={styles.editor}
|
||||
mode={mode}
|
||||
page={snapshotPage}
|
||||
onModeChange={onModeChange}
|
||||
/>
|
||||
</AffineErrorBoundary>
|
||||
) : (
|
||||
<div className={styles.loadingContainer}>
|
||||
<Loading size={24} />
|
||||
|
||||
@@ -177,14 +177,17 @@ const DetailPageImpl = memo(function DetailPageImpl({ page }: { page: Page }) {
|
||||
</>
|
||||
}
|
||||
main={
|
||||
<div className={styles.editorContainer}>
|
||||
<PageDetailEditor
|
||||
pageId={currentPageId}
|
||||
onLoad={onLoad}
|
||||
workspace={blockSuiteWorkspace}
|
||||
/>
|
||||
<HubIsland />
|
||||
</div>
|
||||
// Add a key to force rerender when page changed, to avoid error boundary persisting.
|
||||
<AffineErrorBoundary key={currentPageId}>
|
||||
<div className={styles.editorContainer}>
|
||||
<PageDetailEditor
|
||||
pageId={currentPageId}
|
||||
onLoad={onLoad}
|
||||
workspace={blockSuiteWorkspace}
|
||||
/>
|
||||
<HubIsland />
|
||||
</div>
|
||||
</AffineErrorBoundary>
|
||||
}
|
||||
footer={isInTrash ? <TrashPageFooter pageId={page.id} /> : null}
|
||||
sidebar={
|
||||
@@ -268,10 +271,5 @@ export const Component = () => {
|
||||
|
||||
const pageId = params.pageId;
|
||||
|
||||
// Add a key to force rerender when page changed, to avoid error boundary persisting.
|
||||
return (
|
||||
<AffineErrorBoundary key={params.pageId}>
|
||||
{pageId ? <DetailPage pageId={pageId} /> : null}
|
||||
</AffineErrorBoundary>
|
||||
);
|
||||
return pageId ? <DetailPage pageId={pageId} /> : null;
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user