Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-24 18:02:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): can not create surface block comment (#13115)

Browse Source 
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Improved comment handling to ensure elements from all selections are
considered, regardless of surface ID.
* Enhanced preview generation for comments to include all relevant
selections without surface-based filtering.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
L-Sun
2025-07-09 19:05:03 +08:00
committed by GitHub
parent ecea7bd825
commit 39abd1bbb8
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
blocksuite/affine/shared/src/services/comment-service/block-element-comment-manager.ts
View File

@@ -123,8 +123,7 @@ export class BlockElementCommentManager extends LifeCycleWatcher {
const gfx = this.std.get(GfxControllerIdentifier); const gfx = this.std.get(GfxControllerIdentifier);
const elementsFromSurfaceSelection = selections const elementsFromSurfaceSelection = selections
.filter(s => s instanceof SurfaceSelection) .filter(s => s instanceof SurfaceSelection)
.flatMap(({ blockId, elements }) => { .flatMap(({ elements }) => {
if (blockId !== gfx.surface?.id) return [];
return elements return elements
.map(id => gfx.getElementById<GfxModel>(id)) .map(id => gfx.getElementById<GfxModel>(id))
.filter(m => m !== null); .filter(m => m !== null);

5
packages/frontend/core/src/blocksuite/view-extensions/comment/comment-provider.ts
View File

@@ -50,10 +50,7 @@ function getPreviewFromSelections(
} else if (selection instanceof ImageSelection) { } else if (selection instanceof ImageSelection) {
// Return <"Image"> for ImageSelection // Return <"Image"> for ImageSelection
previews.push('<Image>'); previews.push('<Image>');
} else if ( } else if (selection instanceof SurfaceSelection) {
selection instanceof SurfaceSelection &&
gfx.surface?.id === selection.blockId
) {
selection.elements.forEach(elementId => { selection.elements.forEach(elementId => {
const model = gfx.getElementById(elementId); const model = gfx.getElementById(elementId);
if (model instanceof GfxPrimitiveElementModel) { if (model instanceof GfxPrimitiveElementModel) {