mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-07-11 07:06:28 +08:00
fix(editor): can not create surface block comment (#13115)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved comment handling to ensure elements from all selections are considered, regardless of surface ID. * Enhanced preview generation for comments to include all relevant selections without surface-based filtering. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
+1
-2
@@ -123,8 +123,7 @@ export class BlockElementCommentManager extends LifeCycleWatcher {
|
||||
const gfx = this.std.get(GfxControllerIdentifier);
|
||||
const elementsFromSurfaceSelection = selections
|
||||
.filter(s => s instanceof SurfaceSelection)
|
||||
.flatMap(({ blockId, elements }) => {
|
||||
if (blockId !== gfx.surface?.id) return [];
|
||||
.flatMap(({ elements }) => {
|
||||
return elements
|
||||
.map(id => gfx.getElementById<GfxModel>(id))
|
||||
.filter(m => m !== null);
|
||||
|
||||
@@ -50,10 +50,7 @@ function getPreviewFromSelections(
|
||||
} else if (selection instanceof ImageSelection) {
|
||||
// Return <"Image"> for ImageSelection
|
||||
previews.push('<Image>');
|
||||
} else if (
|
||||
selection instanceof SurfaceSelection &&
|
||||
gfx.surface?.id === selection.blockId
|
||||
) {
|
||||
} else if (selection instanceof SurfaceSelection) {
|
||||
selection.elements.forEach(elementId => {
|
||||
const model = gfx.getElementById(elementId);
|
||||
if (model instanceof GfxPrimitiveElementModel) {
|
||||
|
||||
Reference in New Issue
Block a user