perf(electron): add index for updates (#6951)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/cd2e982a-f78a-4cc3-b090-ee4c0090e19d.png)

Above image shows the performance on querying a 20k rows of updates table, which is super slow at 150+ms. After adding index for doc_id the performance should be greatly improved.

After:
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/45ea4389-1833-4dc5-bd64-84d8c99cd647.png)

fix TOV-866
This commit is contained in:
pengx17
2024-05-16 06:30:53 +00:00
parent 37cb5b86f4
commit 27af9b4d1a
10 changed files with 443 additions and 342 deletions

View File

@@ -73,6 +73,7 @@ impl SqliteConnection {
.await
.map_err(anyhow::Error::from)?;
self.migrate_add_doc_id().await?;
self.migrate_add_doc_id_index().await?;
connection.detach();
Ok(())
}
@@ -145,6 +146,25 @@ impl SqliteConnection {
Ok(updates)
}
#[napi]
pub async fn delete_updates(&self, doc_id: Option<String>) -> napi::Result<()> {
match doc_id {
Some(doc_id) => {
sqlx::query!("DELETE FROM updates WHERE doc_id = ?", doc_id)
.execute(&self.pool)
.await
.map_err(anyhow::Error::from)?;
}
None => {
sqlx::query!("DELETE FROM updates WHERE doc_id is NULL")
.execute(&self.pool)
.await
.map_err(anyhow::Error::from)?;
}
};
Ok(())
}
#[napi]
pub async fn get_updates_count(&self, doc_id: Option<String>) -> napi::Result<i32> {
let count = match doc_id {
@@ -361,4 +381,17 @@ impl SqliteConnection {
}
}
}
pub async fn migrate_add_doc_id_index(&self) -> napi::Result<()> {
// ignore errors
match sqlx::query("CREATE INDEX IF NOT EXISTS idx_doc_id ON updates(doc_id);")
.execute(&self.pool)
.await
{
Ok(_) => Ok(()),
Err(err) => {
Err(anyhow::Error::from(err).into()) // Propagate other errors
}
}
}
}