clippy

src/overlays/keyboard.rs

@@ -145,7 +145,7 @@ fn key_press(
             data.key_click(&app.session);
 
             if let PointerMode::Right = mode {
-                data.modifiers = data.modifiers | SHIFT;
+                data.modifiers |= SHIFT;
                 app.hid_provider.set_modifiers(data.modifiers);
             }
 

src/overlays/mirror.rs

@@ -82,7 +82,7 @@ impl OverlayRenderer for MirrorRenderer {
             if let Some(view) = renderer.view() {
                 let extent = view.image().extent();
                 if self.last_extent != extent {
-                    self.last_extent = extent.clone();
+                    self.last_extent = extent;
                     // resized
                     app.tasks.enqueue(TaskType::Overlay(
                         OverlaySelector::Name(self.name.clone()),

src/overlays/screen.rs

@@ -356,7 +356,7 @@ impl OverlayRenderer for ScreenRenderer {
                 }
             });
 
-            self.capture.init(&drm_formats);
+            self.capture.init(drm_formats);
             self.capture.request_new_frame();
         };
 
@@ -407,7 +407,7 @@ impl OverlayRenderer for ScreenRenderer {
                     let data = unsafe { slice::from_raw_parts(map, len) };
 
                     let image =
-                        upload.texture2d(frame.format.width, frame.format.height, format, &data)?;
+                        upload.texture2d(frame.format.width, frame.format.height, format, data)?;
                     upload.build_and_execute_now()?;
 
                     unsafe { libc::munmap(map as *mut _, len) };
@@ -426,7 +426,7 @@ impl OverlayRenderer for ScreenRenderer {
                     let data = unsafe { slice::from_raw_parts(frame.ptr as *const u8, frame.size) };
 
                     let image =
-                        upload.texture2d(frame.format.width, frame.format.height, format, &data)?;
+                        upload.texture2d(frame.format.width, frame.format.height, format, data)?;
 
                     let mut pipeline = None;
                     if frame.mouse.is_some() {

src/overlays/watch.rs

@@ -80,14 +80,11 @@ where
                 canvas.font_size = font_size;
                 canvas.fg_color = color_parse(&fg_color).unwrap_or(FALLBACK_COLOR);
 
-                let tz: Option<Tz> = match timezone {
-                    Some(tz) => Some(tz.parse().unwrap_or_else(|_| {
+                let tz: Option<Tz> = timezone.map(|tz| tz.parse().unwrap_or_else(|_| {
                         log::error!("Failed to parse timezone '{}'", &tz);
                         canvas.fg_color = FALLBACK_COLOR;
                         Tz::UTC
-                    })),
-                    None => None,
-                };
+                    }));
 
                 let label = canvas.label(x, y, w, h, empty_str.clone());
                 label.state = Some(ElemState::Clock {