From 2620a791b941951877adcce7504e2fe21a22fe35 Mon Sep 17 00:00:00 2001
From: galister <22305755+galister@users.noreply.github.com>
Date: Tue, 22 Apr 2025 04:07:21 +0900
Subject: [PATCH] fix mirrors never popping up

---
 src/overlays/mirror.rs | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/src/overlays/mirror.rs b/src/overlays/mirror.rs
index df3fdfa..d30b8a0 100644
--- a/src/overlays/mirror.rs
+++ b/src/overlays/mirror.rs
@@ -48,17 +48,6 @@ impl OverlayRenderer for MirrorRenderer {
         Ok(())
     }
     fn should_render(&mut self, app: &mut AppState) -> anyhow::Result<ShouldRender> {
-        self.renderer
-            .as_mut()
-            .map_or(Ok(ShouldRender::Unable), |r| r.should_render(app))
-    }
-    fn render(
-        &mut self,
-        app: &mut AppState,
-        tgt: Arc<ImageView>,
-        buf: &mut CommandBuffers,
-        alpha: f32,
-    ) -> anyhow::Result<bool> {
         if let Some(mut selector) = self.selector.take() {
             let maybe_pw_result = match selector
                 .poll_unpin(&mut Context::from_waker(futures::task::noop_waker_ref()))
@@ -66,7 +55,7 @@ impl OverlayRenderer for MirrorRenderer {
                 Poll::Ready(result) => result,
                 Poll::Pending => {
                     self.selector = Some(selector);
-                    return Ok(false);
+                    return Ok(ShouldRender::Unable);
                 }
             };
 
@@ -99,7 +88,17 @@ impl OverlayRenderer for MirrorRenderer {
                 }
             }
         }
-
+        self.renderer
+            .as_mut()
+            .map_or(Ok(ShouldRender::Unable), |r| r.should_render(app))
+    }
+    fn render(
+        &mut self,
+        app: &mut AppState,
+        tgt: Arc<ImageView>,
+        buf: &mut CommandBuffers,
+        alpha: f32,
+    ) -> anyhow::Result<bool> {
         let mut result = false;
         if let Some(renderer) = self.renderer.as_mut() {
             result = renderer.render(app, tgt, buf, alpha)?;