parser refactoring

This commit is contained in:
Aleksander
2025-06-28 17:39:53 +02:00
parent 247c51c3b7
commit 2420e8007c
12 changed files with 252 additions and 219 deletions

View File

@@ -1,10 +1,9 @@
use std::sync::Arc;
use glam::Vec2;
use taffy::{AlignItems, JustifyContent, prelude::length};
use crate::{
animation::{Animation, AnimationEasing},
components::Component,
drawing::{self, Color},
event::WidgetCallback,
layout::{Layout, WidgetID},
@@ -19,7 +18,9 @@ use crate::{
pub struct Params<'a> {
pub text: &'a str,
pub color: drawing::Color,
pub size: Vec2,
pub border_color: drawing::Color,
pub round: WLength,
pub style: taffy::Style,
pub text_style: TextStyle,
}
@@ -28,19 +29,23 @@ impl Default for Params<'_> {
Self {
text: "Text",
color: drawing::Color::new(1.0, 1.0, 1.0, 1.0),
size: Vec2::new(128.0, 32.0),
border_color: drawing::Color::new(0.0, 0.0, 0.0, 1.0),
round: WLength::Units(4.0),
style: Default::default(),
text_style: TextStyle::default(),
}
}
}
pub struct Button {
color: drawing::Color,
pub color: drawing::Color,
pub body: WidgetID, // Rectangle
pub text_id: WidgetID, // Text
text_node: taffy::NodeId,
}
impl Component for Button {}
impl Button {
pub fn set_text<'a, C>(&self, callback_data: &mut C, text: &str)
where
@@ -95,23 +100,23 @@ pub fn construct(
parent: WidgetID,
params: Params,
) -> anyhow::Result<Arc<Button>> {
let mut style = params.style;
// force-override style
style.align_items = Some(AlignItems::Center);
style.justify_content = Some(JustifyContent::Center);
style.padding = length(1.0);
let (rect_id, _) = layout.add_child(
parent,
Rectangle::create(RectangleParams {
color: params.color,
round: WLength::Units(4.0),
round: params.round,
border_color: params.border_color,
border: 2.0,
..Default::default()
})?,
taffy::Style {
size: taffy::Size {
width: length(params.size.x),
height: length(params.size.y),
},
align_items: Some(AlignItems::Center),
justify_content: Some(JustifyContent::Center),
padding: length(1.0),
..Default::default()
},
style,
)?;
let light_text = (params.color.r + params.color.g + params.color.b) < 1.5;

View File

@@ -1 +1,5 @@
use crate::any::AnyTrait;
pub mod button;
pub trait Component: AnyTrait {}

View File

@@ -0,0 +1,60 @@
use crate::{
components::button,
drawing::Color,
layout::WidgetID,
parser::{
ParserContext, ParserFile, iter_attribs,
style::{parse_color, parse_round, parse_style, parse_text_style},
},
widget::util::WLength,
};
pub fn parse_component_button<'a>(
file: &'a ParserFile,
ctx: &mut ParserContext,
node: roxmltree::Node<'a, 'a>,
parent_id: WidgetID,
) -> anyhow::Result<()> {
let mut color = Color::new(1.0, 1.0, 1.0, 1.0);
let mut border_color = Color::new(0.0, 0.0, 0.0, 1.0);
let mut round = WLength::Units(4.0);
let mut text = String::default();
let attribs: Vec<_> = iter_attribs(file, ctx, &node, false).collect();
let text_style = parse_text_style(&attribs);
let style = parse_style(&attribs);
for (key, value) in attribs {
match key.as_ref() {
"text" => {
text = String::from(value.as_ref());
}
"round" => {
parse_round(&value, &mut round);
}
"color" => {
parse_color(&value, &mut color);
}
"border_color" => {
parse_color(&value, &mut border_color);
}
_ => {}
}
}
let button = button::construct(
ctx.layout,
parent_id,
button::Params {
color,
border_color,
text: &text,
style,
text_style,
round,
},
)?;
Ok(())
}

View File

@@ -1,3 +1,4 @@
mod component_button;
mod style;
mod widget_div;
mod widget_label;
@@ -9,8 +10,9 @@ use crate::{
drawing::{self},
layout::{Layout, WidgetID},
parser::{
widget_div::parse_widget_div, widget_label::parse_widget_label,
widget_rectangle::parse_widget_rectangle, widget_sprite::parse_widget_sprite,
component_button::parse_component_button, widget_div::parse_widget_div,
widget_label::parse_widget_label, widget_rectangle::parse_widget_rectangle,
widget_sprite::parse_widget_sprite,
},
};
use ouroboros::self_referencing;
@@ -543,6 +545,9 @@ fn parse_children<'a>(
"sprite" => {
parse_widget_sprite(file, ctx, child_node, parent_id)?;
}
"button" => {
parse_component_button(file, ctx, child_node, parent_id)?;
}
"" => { /* ignore */ }
other_tag_name => {
parse_widget_other(other_tag_name, file, ctx, child_node, parent_id)?;

View File

@@ -1,75 +1,140 @@
use std::rc::Rc;
use taffy::{
AlignContent, AlignItems, AlignSelf, BoxSizing, Display, FlexDirection, FlexWrap, JustifyContent,
JustifySelf, Overflow,
};
use crate::parser::{
ParserContext, ParserFile, iter_attribs, parse_size_unit, parse_val, print_invalid_attrib,
use crate::{
drawing,
parser::{
is_percent, parse_color_hex, parse_f32, parse_percent, parse_size_unit, parse_val,
print_invalid_attrib, print_invalid_value,
},
renderer_vk::text::{FontWeight, HorizontalAlign, TextStyle},
widget::util::WLength,
};
pub fn style_from_node<'a>(
file: &'a ParserFile,
ctx: &ParserContext,
node: roxmltree::Node<'a, 'a>,
) -> taffy::Style {
pub fn parse_round(value: &str, round: &mut WLength) {
if is_percent(value) {
if let Some(val) = parse_percent(value) {
*round = WLength::Percent(val);
} else {
print_invalid_value(value);
}
} else if let Some(val) = parse_f32(value) {
*round = WLength::Units(val);
} else {
print_invalid_value(value);
}
}
pub fn parse_color(value: &str, color: &mut drawing::Color) {
if let Some(res_color) = parse_color_hex(value) {
*color = res_color;
} else {
print_invalid_value(value);
}
}
pub fn parse_text_style(attribs: &[(Rc<str>, Rc<str>)]) -> TextStyle {
let mut style = TextStyle::default();
for (key, value) in attribs {
match key.as_ref() {
"color" => {
if let Some(color) = parse_color_hex(value) {
style.color = Some(color);
}
}
"align" => match value.as_ref() {
"left" => style.align = Some(HorizontalAlign::Left),
"right" => style.align = Some(HorizontalAlign::Right),
"center" => style.align = Some(HorizontalAlign::Center),
"justified" => style.align = Some(HorizontalAlign::Justified),
"end" => style.align = Some(HorizontalAlign::End),
_ => {
print_invalid_attrib(key, value);
}
},
"weight" => match value.as_ref() {
"normal" => style.weight = Some(FontWeight::Normal),
"bold" => style.weight = Some(FontWeight::Bold),
_ => {
print_invalid_attrib(key, value);
}
},
"size" => {
if let Ok(size) = value.parse::<f32>() {
style.size = Some(size);
} else {
print_invalid_attrib(key, value);
}
}
_ => {}
}
}
style
}
pub fn parse_style(attribs: &[(Rc<str>, Rc<str>)]) -> taffy::Style {
let mut style = taffy::Style {
..Default::default()
};
let attribs: Vec<_> = iter_attribs(file, ctx, &node, false).collect();
for (key, value) in attribs {
match &*key {
"display" => match &*value {
match key.as_ref() {
"display" => match value.as_ref() {
"flex" => style.display = Display::Flex,
"block" => style.display = Display::Block,
"grid" => style.display = Display::Grid,
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"margin_left" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.margin.left = dim;
}
}
"margin_right" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.margin.right = dim;
}
}
"margin_top" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.margin.top = dim;
}
}
"margin_bottom" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.margin.bottom = dim;
}
}
"padding_left" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.padding.left = dim;
}
}
"padding_right" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.padding.right = dim;
}
}
"padding_top" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.padding.top = dim;
}
}
"padding_bottom" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.padding.bottom = dim;
}
}
"margin" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.margin.left = dim;
style.margin.right = dim;
style.margin.top = dim;
@@ -77,14 +142,14 @@ pub fn style_from_node<'a>(
}
}
"padding" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.padding.left = dim;
style.padding.right = dim;
style.padding.top = dim;
style.padding.bottom = dim;
}
}
"overflow" => match &*value {
"overflow" => match value.as_ref() {
"hidden" => {
style.overflow.x = Overflow::Hidden;
style.overflow.y = Overflow::Hidden;
@@ -102,92 +167,92 @@ pub fn style_from_node<'a>(
style.overflow.y = Overflow::Scroll;
}
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"overflow_x" => match &*value {
"overflow_x" => match value.as_ref() {
"hidden" => style.overflow.x = Overflow::Hidden,
"visible" => style.overflow.x = Overflow::Visible,
"clip" => style.overflow.x = Overflow::Clip,
"scroll" => style.overflow.x = Overflow::Scroll,
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"overflow_y" => match &*value {
"overflow_y" => match value.as_ref() {
"hidden" => style.overflow.y = Overflow::Hidden,
"visible" => style.overflow.y = Overflow::Visible,
"clip" => style.overflow.y = Overflow::Clip,
"scroll" => style.overflow.y = Overflow::Scroll,
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"min_width" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.min_size.width = dim;
}
}
"min_height" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.min_size.height = dim;
}
}
"max_width" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.max_size.width = dim;
}
}
"max_height" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.max_size.height = dim;
}
}
"width" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.size.width = dim;
}
}
"height" => {
if let Some(dim) = parse_size_unit(&value) {
if let Some(dim) = parse_size_unit(value) {
style.size.height = dim;
}
}
"gap" => {
if let Some(val) = parse_size_unit(&value) {
if let Some(val) = parse_size_unit(value) {
style.gap = val;
}
}
"flex_basis" => {
if let Some(val) = parse_size_unit(&value) {
if let Some(val) = parse_size_unit(value) {
style.flex_basis = val;
}
}
"flex_grow" => {
if let Some(val) = parse_val(&value) {
if let Some(val) = parse_val(value) {
style.flex_grow = val;
}
}
"flex_shrink" => {
if let Some(val) = parse_val(&value) {
if let Some(val) = parse_val(value) {
style.flex_shrink = val;
}
}
"position" => match &*value {
"position" => match value.as_ref() {
"absolute" => style.position = taffy::Position::Absolute,
"relative" => style.position = taffy::Position::Relative,
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"box_sizing" => match &*value {
"box_sizing" => match value.as_ref() {
"border_box" => style.box_sizing = BoxSizing::BorderBox,
"content_box" => style.box_sizing = BoxSizing::ContentBox,
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"align_self" => match &*value {
"align_self" => match value.as_ref() {
"baseline" => style.align_self = Some(AlignSelf::Baseline),
"center" => style.align_self = Some(AlignSelf::Center),
"end" => style.align_self = Some(AlignSelf::End),
@@ -196,10 +261,10 @@ pub fn style_from_node<'a>(
"start" => style.align_self = Some(AlignSelf::Start),
"stretch" => style.align_self = Some(AlignSelf::Stretch),
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"justify_self" => match &*value {
"justify_self" => match value.as_ref() {
"center" => style.justify_self = Some(JustifySelf::Center),
"end" => style.justify_self = Some(JustifySelf::End),
"flex_end" => style.justify_self = Some(JustifySelf::FlexEnd),
@@ -207,10 +272,10 @@ pub fn style_from_node<'a>(
"start" => style.justify_self = Some(JustifySelf::Start),
"stretch" => style.justify_self = Some(JustifySelf::Stretch),
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"align_items" => match &*value {
"align_items" => match value.as_ref() {
"baseline" => style.align_items = Some(AlignItems::Baseline),
"center" => style.align_items = Some(AlignItems::Center),
"end" => style.align_items = Some(AlignItems::End),
@@ -219,10 +284,10 @@ pub fn style_from_node<'a>(
"start" => style.align_items = Some(AlignItems::Start),
"stretch" => style.align_items = Some(AlignItems::Stretch),
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"align_content" => match &*value {
"align_content" => match value.as_ref() {
"center" => style.align_content = Some(AlignContent::Center),
"end" => style.align_content = Some(AlignContent::End),
"flex_end" => style.align_content = Some(AlignContent::FlexEnd),
@@ -233,10 +298,10 @@ pub fn style_from_node<'a>(
"start" => style.align_content = Some(AlignContent::Start),
"stretch" => style.align_content = Some(AlignContent::Stretch),
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"justify_content" => match &*value {
"justify_content" => match value.as_ref() {
"center" => style.justify_content = Some(JustifyContent::Center),
"end" => style.justify_content = Some(JustifyContent::End),
"flex_end" => style.justify_content = Some(JustifyContent::FlexEnd),
@@ -247,22 +312,22 @@ pub fn style_from_node<'a>(
"start" => style.justify_content = Some(JustifyContent::Start),
"stretch" => style.justify_content = Some(JustifyContent::Stretch),
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
"flex_wrap" => match &*value {
"flex_wrap" => match value.as_ref() {
"wrap" => style.flex_wrap = FlexWrap::Wrap,
"no_wrap" => style.flex_wrap = FlexWrap::NoWrap,
"wrap_reverse" => style.flex_wrap = FlexWrap::WrapReverse,
_ => {}
},
"flex_direction" => match &*value {
"flex_direction" => match value.as_ref() {
"column_reverse" => style.flex_direction = FlexDirection::ColumnReverse,
"column" => style.flex_direction = FlexDirection::Column,
"row_reverse" => style.flex_direction = FlexDirection::RowReverse,
"row" => style.flex_direction = FlexDirection::Row,
_ => {
print_invalid_attrib(&key, &value);
print_invalid_attrib(key, value);
}
},
_ => {}

View File

@@ -1,6 +1,8 @@
use crate::{
layout::WidgetID,
parser::{ParserContext, ParserFile, parse_children, parse_universal, style::style_from_node},
parser::{
ParserContext, ParserFile, iter_attribs, parse_children, parse_universal, style::parse_style,
},
widget,
};
@@ -10,7 +12,8 @@ pub fn parse_widget_div<'a>(
node: roxmltree::Node<'a, 'a>,
parent_id: WidgetID,
) -> anyhow::Result<()> {
let style = style_from_node(file, ctx, node);
let attribs: Vec<_> = iter_attribs(file, ctx, &node, false).collect();
let style = parse_style(&attribs);
let (new_id, _) = ctx
.layout

View File

@@ -1,10 +1,9 @@
use crate::{
layout::WidgetID,
parser::{
ParserContext, ParserFile, iter_attribs, parse_children, parse_color_hex, parse_universal,
print_invalid_attrib, style::style_from_node,
ParserContext, ParserFile, iter_attribs, parse_children, parse_universal,
style::{parse_style, parse_text_style},
},
renderer_vk::text::{FontWeight, HorizontalAlign},
widget::text::{TextLabel, TextParams},
};
@@ -16,46 +15,19 @@ pub fn parse_widget_label<'a>(
) -> anyhow::Result<()> {
let mut params = TextParams::default();
let attribs: Vec<_> = iter_attribs(file, ctx, &node, false).collect();
let style = parse_style(&attribs);
params.style = parse_text_style(&attribs);
for (key, value) in attribs {
match &*key {
"text" => {
params.content = String::from(value.as_ref());
}
"color" => {
if let Some(color) = parse_color_hex(&value) {
params.style.color = Some(color);
}
}
"align" => match &*value {
"left" => params.style.align = Some(HorizontalAlign::Left),
"right" => params.style.align = Some(HorizontalAlign::Right),
"center" => params.style.align = Some(HorizontalAlign::Center),
"justified" => params.style.align = Some(HorizontalAlign::Justified),
"end" => params.style.align = Some(HorizontalAlign::End),
_ => {
print_invalid_attrib(&key, &value);
}
},
"weight" => match &*value {
"normal" => params.style.weight = Some(FontWeight::Normal),
"bold" => params.style.weight = Some(FontWeight::Bold),
_ => {
print_invalid_attrib(&key, &value);
}
},
"size" => {
if let Ok(size) = value.parse::<f32>() {
params.style.size = Some(size);
} else {
print_invalid_attrib(&key, &value);
}
}
_ => {}
}
}
let style = style_from_node(file, ctx, node);
let (new_id, _) = ctx
.layout
.add_child(parent_id, TextLabel::create(params)?, style)?;

View File

@@ -2,11 +2,10 @@ use crate::{
drawing::GradientMode,
layout::WidgetID,
parser::{
ParserContext, ParserFile, is_percent, iter_attribs, parse_children, parse_color_hex,
parse_f32, parse_percent, parse_universal, print_invalid_attrib, print_invalid_value,
style::style_from_node,
ParserContext, ParserFile, iter_attribs, parse_children, parse_universal, print_invalid_attrib,
style::{parse_color, parse_round, parse_style},
},
widget::{self, rectangle::RectangleParams, util::WLength},
widget::{self, rectangle::RectangleParams},
};
pub fn parse_widget_rectangle<'a>(
@@ -17,22 +16,15 @@ pub fn parse_widget_rectangle<'a>(
) -> anyhow::Result<()> {
let mut params = RectangleParams::default();
let attribs: Vec<_> = iter_attribs(file, ctx, &node, false).collect();
let style = parse_style(&attribs);
for (key, value) in attribs {
match &*key {
"color" => {
if let Some(color) = parse_color_hex(&value) {
params.color = color;
} else {
print_invalid_attrib(&key, &value);
}
parse_color(&value, &mut params.color);
}
"color2" => {
if let Some(color) = parse_color_hex(&value) {
params.color2 = color;
} else {
print_invalid_attrib(&key, &value);
}
parse_color(&value, &mut params.color2);
}
"gradient" => {
params.gradient = match &*value {
@@ -47,17 +39,7 @@ pub fn parse_widget_rectangle<'a>(
}
}
"round" => {
if is_percent(&value) {
if let Some(val) = parse_percent(&value) {
params.round = WLength::Percent(val);
} else {
print_invalid_value(&value);
}
} else if let Some(val) = parse_f32(&value) {
params.round = WLength::Units(val);
} else {
print_invalid_value(&value);
}
parse_round(&value, &mut params.round);
}
"border" => {
params.border = value.parse().unwrap_or_else(|_| {
@@ -66,18 +48,12 @@ pub fn parse_widget_rectangle<'a>(
});
}
"border_color" => {
if let Some(color) = parse_color_hex(&value) {
params.border_color = color;
} else {
print_invalid_attrib(&key, &value);
}
parse_color(&value, &mut params.border_color);
}
_ => {}
}
}
let style = style_from_node(file, ctx, node);
let (new_id, _) = ctx.layout.add_child(
parent_id,
widget::rectangle::Rectangle::create(params)?,

View File

@@ -1,8 +1,7 @@
use crate::{
layout::WidgetID,
parser::{
ParserContext, ParserFile, iter_attribs, parse_children, parse_universal,
style::style_from_node,
ParserContext, ParserFile, iter_attribs, parse_children, parse_universal, style::parse_style,
},
renderer_vk::text::custom_glyph::{CustomGlyphContent, CustomGlyphData},
widget::sprite::{SpriteBox, SpriteBoxParams},
@@ -18,6 +17,7 @@ pub fn parse_widget_sprite<'a>(
) -> anyhow::Result<()> {
let mut params = SpriteBoxParams::default();
let attribs: Vec<_> = iter_attribs(file, ctx, &node, false).collect();
let style = parse_style(&attribs);
let mut glyph = None;
for (key, value) in attribs {
@@ -53,8 +53,6 @@ pub fn parse_widget_sprite<'a>(
log::warn!("No source for sprite node!");
};
let style = style_from_node(file, ctx, node);
let (new_id, _) = ctx
.layout
.add_child(parent_id, SpriteBox::create(params)?, style)?;