Files
AFFiNE-Mirror/blocksuite/affine/gfx/group/src/interaction-ext.ts
T
doouding 5de63c29f5 fix: rewrite selection logic and frame selection handling logic (#12421)
Fixes [BS-3528](https://linear.app/affine-design/issue/BS-3528)
Fixes [BS-3331](https://linear.app/affine-design/issue/BS-3331/frame-移动逻辑很奇怪)

### Changed
- Remove `onSelected` method from gfx view, use `handleSelection` provided by `GfxViewInteraction` instead.
- Add `selectable` to allow model to filter out itself from selection.
- Frame can be selected by body only if it's locked or its background is not transparent.

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

- **New Features**
  - Enhanced selection behavior for frames, edgeless text, notes, and mind map elements with refined control based on lock state and background transparency.
  - Introduced group-aware selection logic promoting selection of appropriate group ancestors.
  - Added support for element selection events in interactivity extensions.

- **Bug Fixes**
  - Resolved frame selection issues by enabling selection via title clicks and restricting body selection to locked frames or those with non-transparent backgrounds.

- **Documentation**
  - Added clarifying comments for group retrieval methods.

- **Tests**
  - Updated and added end-to-end tests for frame and lock selection reflecting new selection conditions.

- **Refactor**
  - Unified and simplified selection handling by moving logic from component methods to interaction handlers and removing deprecated selection methods.
  - Streamlined selection candidate processing with extension-driven target suggestion.
  - Removed legacy group element retrieval and selection helper methods to simplify interaction logic.

- **Style**
  - Renamed types and improved type signatures for selection context and interaction configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-05-26 05:03:09 +00:00

46 lines
1.3 KiB
TypeScript

import { GroupElementModel } from '@blocksuite/affine-model';
import { InteractivityExtension } from '@blocksuite/std/gfx';
export class GroupInteractionExtension extends InteractivityExtension {
static override key = 'group-selection';
override mounted(): void {
this.action.onElementSelect(context => {
const { candidates, suggest } = context;
const { activeGroup } = this.gfx.selection;
let target = context.target;
if (activeGroup && activeGroup.hasDescendant(target)) {
const groups = target.groups;
const activeGroupIdx = groups.indexOf(activeGroup);
if (activeGroupIdx !== -1) {
target =
groups
.slice(0, activeGroupIdx)
.findLast(
group =>
group instanceof GroupElementModel &&
candidates.includes(group)
) ?? target;
}
} else {
const groups = target.groups;
target =
groups.findLast(group => {
return (
group instanceof GroupElementModel && candidates.includes(group)
);
}) ?? target;
}
if (target !== context.target) {
suggest({
id: target.id,
});
}
});
}
}