mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-02-13 12:55:00 +00:00
6e6b85098e
This PR is related to issue https://github.com/toeverything/AFFiNE/issues/14018 When uploading a new profile photo avatar the Pica function, which is responsible for reducing and resizing the profile photo, may crash if the browser's Fingerprint Protection is enabled. This is because Fingerprint Protection prevents Pica from modifying the canvas. This fix introduces a try-catch inside the function that calls the reduction and resizing of the photo. Also, the Error object is no longer passed directly to the notification service, which also caused issues previously. Now a message will appear that tells the user that the upload failed and to check the browser's fingerprint protection (check photo below). Affected files: packages/frontend/core/src/utils/reduce-image.ts <img width="408" height="136" alt="new_error" src="https://github.com/user-attachments/assets/d140e17c-8c13-4f4b-bdf7-7dd5ddc5c917" /> I'm open to any suggestions in terms of wording of the error messages. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved error handling for image compression with clearer, user-facing messages when compression is blocked or fails. * Ensures the original or reduced image is reliably returned as a fallback if compression is not performed. * Preserves file metadata (original lastModified, name, type) when returning processed files. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: DarkSky <darksky2048@gmail.com> Co-authored-by: DarkSky <25152247+darkskygit@users.noreply.github.com>