Files
AFFiNE-Mirror/blocksuite/tests-legacy/e2e/edgeless/note/note.spec.ts
fundon ec9bd1f383 feat(editor): add toolbar registry extension (#9572)
### What's Changed!

#### Added
Manage various types of toolbars uniformly in one place.

* `affine-toolbar-widget`
* `ToolbarRegistryExtension`

The toolbar currently supports and handles several scenarios:

1.  Select blocks: `BlockSelection`
2. Select text: `TextSelection` or `NativeSelection`
3. Hover a link: `affine-link` and `affine-reference`

#### Removed
Remove redundant toolbar implementations.

* `attachment` toolbar
* `bookmark` toolbar
* `embed` toolbar
* `formatting` toolbar
* `affine-link` toolbar
* `affine-reference` toolbar

### How to migrate?

Here is an example that can help us migrate some unrefactored toolbars:

Check out the more detailed types of [`ToolbarModuleConfig`](c178debf2d/blocksuite/affine/shared/src/services/toolbar-service/config.ts).

1.  Add toolbar configuration file to a block type, such as bookmark block: [`config.ts`](c178debf2d/blocksuite/affine/block-bookmark/src/configs/toolbar.ts)

```ts
export const builtinToolbarConfig = {
  actions: [
    {
      id: 'a.preview',
      content(ctx) {
        const model = ctx.getCurrentModelBy(BlockSelection, BookmarkBlockModel);
        if (!model) return null;

        const { url } = model;

        return html`<affine-link-preview .url=${url}></affine-link-preview>`;
      },
    },
    {
      id: 'b.conversions',
      actions: [
        {
          id: 'inline',
          label: 'Inline view',
          run(ctx) {
          },
        },
        {
          id: 'card',
          label: 'Card view',
          disabled: true,
        },
        {
          id: 'embed',
          label: 'Embed view',
          disabled(ctx) {
          },
          run(ctx) {
          },
        },
      ],
      content(ctx) {
      },
    } satisfies ToolbarActionGroup<ToolbarAction>,
    {
      id: 'c.style',
      actions: [
        {
          id: 'horizontal',
          label: 'Large horizontal style',
        },
        {
          id: 'list',
          label: 'Small horizontal style',
        },
      ],
      content(ctx) {
      },
    } satisfies ToolbarActionGroup<ToolbarAction>,
    {
      id: 'd.caption',
      tooltip: 'Caption',
      icon: CaptionIcon(),
      run(ctx) {
      },
    },
    {
      placement: ActionPlacement.More,
      id: 'a.clipboard',
      actions: [
        {
          id: 'copy',
          label: 'Copy',
          icon: CopyIcon(),
          run(ctx) {
          },
        },
        {
          id: 'duplicate',
          label: 'Duplicate',
          icon: DuplicateIcon(),
          run(ctx) {
          },
        },
      ],
    },
    {
      placement: ActionPlacement.More,
      id: 'b.refresh',
      label: 'Reload',
      icon: ResetIcon(),
      run(ctx) {
      },
    },
    {
      placement: ActionPlacement.More,
      id: 'c.delete',
      label: 'Delete',
      icon: DeleteIcon(),
      variant: 'destructive',
      run(ctx) {
      },
    },
  ],
} as const satisfies ToolbarModuleConfig;
```

2. Add configuration extension to a block spec: [bookmark's spec](c178debf2d/blocksuite/affine/block-bookmark/src/bookmark-spec.ts)

```ts
const flavour = BookmarkBlockSchema.model.flavour;

export const BookmarkBlockSpec: ExtensionType[] = [
  ...,
  ToolbarModuleExtension({
    id: BlockFlavourIdentifier(flavour),
    config: builtinToolbarConfig,
  }),
].flat();
```

3. If the bock type already has a toolbar configuration built in, we can customize it in the following ways:

Check out the [editor's config](c178debf2d/packages/frontend/core/src/blocksuite/extensions/editor-config/index.ts (L51C4-L54C8)) file.

```ts
// Defines a toolbar configuration for the bookmark block type
const customBookmarkToolbarConfig = {
  actions: [
    ...
  ]
} as const satisfies ToolbarModuleConfig;

// Adds it into the editor's config
 ToolbarModuleExtension({
    id: BlockFlavourIdentifier('custom:affine:bookmark'),
    config: customBookmarkToolbarConfig,
 }),
```

4. If we want to extend the global:

```ts
// Defines a toolbar configuration
const customWildcardToolbarConfig = {
  actions: [
    ...
  ]
} as const satisfies ToolbarModuleConfig;

// Adds it into the editor's config
 ToolbarModuleExtension({
    id: BlockFlavourIdentifier('custom:affine:*'),
    config: customWildcardToolbarConfig,
 }),
```

Currently, only most toolbars in page mode have been refactored. Next is edgeless mode.
2025-03-06 06:46:03 +00:00

544 lines
15 KiB
TypeScript

import { expect } from '@playwright/test';
import { lightThemeV2 } from '@toeverything/theme/v2';
import {
activeNoteInEdgeless,
addNote,
assertEdgelessTool,
changeEdgelessNoteBackground,
changeNoteDisplayMode,
locatorComponentToolbar,
locatorEdgelessZoomToolButton,
selectNoteInEdgeless,
setEdgelessTool,
switchEditorMode,
triggerComponentToolbarAction,
zoomOutByKeyboard,
zoomResetByKeyboard,
} from '../../utils/actions/edgeless.js';
import {
click,
clickBlockById,
dragBetweenCoords,
dragBetweenIndices,
enterPlaygroundRoom,
focusRichText,
focusRichTextEnd,
initEmptyEdgelessState,
initThreeParagraphs,
pressArrowDown,
pressArrowUp,
pressBackspace,
pressEnter,
pressTab,
type,
undoByKeyboard,
waitForInlineEditorStateUpdated,
waitNextFrame,
} from '../../utils/actions/index.js';
import {
assertBlockChildrenIds,
assertBlockCount,
assertEdgelessNonSelectedRect,
assertEdgelessNoteBackground,
assertEdgelessSelectedRect,
assertNoteSequence,
assertNoteXYWH,
assertRichTextInlineRange,
assertRichTexts,
assertTextSelection,
} from '../../utils/asserts.js';
import {
DEFAULT_NOTE_HEIGHT,
DEFAULT_NOTE_WIDTH,
NoteDisplayMode,
} from '../../utils/bs-alternative.js';
import { test } from '../../utils/playwright.js';
const CENTER_X = 450;
const CENTER_Y = 450;
test('can drag selected non-active note', async ({ page }) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await focusRichText(page);
await type(page, 'hello');
await assertRichTexts(page, ['hello']);
await switchEditorMode(page);
await zoomResetByKeyboard(page);
await assertNoteXYWH(page, [0, 0, DEFAULT_NOTE_WIDTH, DEFAULT_NOTE_HEIGHT]);
// selected, non-active
await page.mouse.click(CENTER_X, CENTER_Y);
await dragBetweenCoords(
page,
{ x: CENTER_X, y: CENTER_Y },
{ x: CENTER_X, y: CENTER_Y + 100 }
);
await assertNoteXYWH(page, [0, 100, DEFAULT_NOTE_WIDTH, DEFAULT_NOTE_HEIGHT]);
await undoByKeyboard(page);
await waitNextFrame(page);
await assertNoteXYWH(page, [0, 0, DEFAULT_NOTE_WIDTH, DEFAULT_NOTE_HEIGHT]);
});
test('add Note', async ({ page }) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await switchEditorMode(page);
await zoomResetByKeyboard(page);
await addNote(page, 'hello', 300, 300);
await assertEdgelessTool(page, 'default');
await assertRichTexts(page, ['', 'hello']);
await page.mouse.click(300, 200);
await page.mouse.click(350, 320);
await assertEdgelessSelectedRect(page, [
270,
260,
DEFAULT_NOTE_WIDTH,
DEFAULT_NOTE_HEIGHT,
]);
});
test('add empty Note', async ({ page }) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await switchEditorMode(page);
await zoomResetByKeyboard(page);
await setEdgelessTool(page, 'note');
// add note at 300,300
await page.mouse.click(300, 300);
await waitForInlineEditorStateUpdated(page);
// should wait for inline editor update and resizeObserver callback
await waitNextFrame(page);
// assert add note success
await assertBlockCount(page, 'edgeless-note', 2);
// click out of note
await page.mouse.click(250, 200);
// assert empty note is note removed
await page.mouse.move(320, 320);
await assertBlockCount(page, 'edgeless-note', 2);
});
test('always keep at least 1 note block', async ({ page }) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await switchEditorMode(page);
await setEdgelessTool(page, 'default');
// clicking in default mode will try to remove empty note block
await page.mouse.click(0, 0);
const notes = await page.locator('affine-edgeless-note').all();
expect(notes.length).toEqual(1);
});
test('edgeless arrow up/down', async ({ page }) => {
await enterPlaygroundRoom(page);
const { paragraphId, noteId } = await initEmptyEdgelessState(page);
await switchEditorMode(page);
await activeNoteInEdgeless(page, noteId);
await waitNextFrame(page, 400);
await type(page, 'aaaaa');
await pressEnter(page);
await type(page, 'aaaaa');
await pressEnter(page);
await type(page, 'aaa');
await waitForInlineEditorStateUpdated(page);
// 0 for page, 1 for surface, 2 for note, 3 for paragraph
expect(paragraphId).toBe('3');
await clickBlockById(page, paragraphId);
await assertRichTextInlineRange(page, 0, 5, 0);
await pressArrowDown(page);
await waitNextFrame(page);
await assertRichTextInlineRange(page, 1, 5, 0);
await pressArrowUp(page);
await waitNextFrame(page);
await assertRichTextInlineRange(page, 0, 5, 0);
await pressArrowUp(page);
await waitNextFrame(page);
await assertRichTextInlineRange(page, 0, 0, 0);
});
test('dragging un-selected note', async ({ page }) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await focusRichText(page);
await type(page, 'hello');
await assertRichTexts(page, ['hello']);
await switchEditorMode(page);
const noteBox = await page.locator('affine-edgeless-note').boundingBox();
if (!noteBox) {
throw new Error('Missing edgeless affine-note');
}
await page.mouse.click(noteBox.x + 5, noteBox.y + 5);
await assertEdgelessSelectedRect(page, [
noteBox.x,
noteBox.y,
noteBox.width,
noteBox.height,
]);
await dragBetweenCoords(
page,
{ x: noteBox.x + 10, y: noteBox.y + 15 },
{ x: noteBox.x + 10, y: noteBox.y + 35 },
{ steps: 10 }
);
await assertEdgelessSelectedRect(page, [
noteBox.x,
noteBox.y + 20,
noteBox.width,
noteBox.height,
]);
});
test('format quick bar should show up when double-clicking on text', async ({
page,
}) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await initThreeParagraphs(page);
await switchEditorMode(page);
await page.mouse.dblclick(CENTER_X, CENTER_Y);
await waitNextFrame(page);
await page
.locator('rich-text')
.nth(1)
.dblclick({
position: { x: 10, y: 10 },
delay: 20,
});
await page.waitForTimeout(200);
const formatBar = page.locator('affine-toolbar-widget editor-toolbar');
await expect(formatBar).toBeVisible();
});
test('when editing text in edgeless, should hide component toolbar', async ({
page,
}) => {
await enterPlaygroundRoom(page);
const { noteId } = await initEmptyEdgelessState(page);
await initThreeParagraphs(page);
await switchEditorMode(page);
await selectNoteInEdgeless(page, noteId);
const toolbar = locatorComponentToolbar(page);
await expect(toolbar).toBeVisible();
await page.mouse.click(0, 0);
await activeNoteInEdgeless(page, noteId);
await expect(toolbar).toBeHidden();
});
test('duplicate note should work correctly', async ({ page }) => {
await enterPlaygroundRoom(page);
const { noteId } = await initEmptyEdgelessState(page);
await initThreeParagraphs(page);
await assertRichTexts(page, ['123', '456', '789']);
await switchEditorMode(page);
await selectNoteInEdgeless(page, noteId);
await triggerComponentToolbarAction(page, 'duplicate');
await waitNextFrame(page, 200); // wait viewport fit animation
const moreActionsContainer = page.locator('.more-actions-container');
await expect(moreActionsContainer).toBeHidden();
const noteLocator = page.locator('affine-edgeless-note');
await expect(noteLocator).toHaveCount(2);
const [firstNote, secondNote] = await noteLocator.all();
// content should be same
expect(await firstNote.innerText()).toEqual(await secondNote.innerText());
// size should be same
const firstNoteBox = await firstNote.boundingBox();
const secondNoteBox = await secondNote.boundingBox();
expect(firstNoteBox!.width).toBeCloseTo(secondNoteBox!.width);
expect(firstNoteBox!.height).toBeCloseTo(secondNoteBox!.height);
});
test('double click toolbar zoom button, should not add text', async ({
page,
}) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await switchEditorMode(page);
const zoomOutButton = await locatorEdgelessZoomToolButton(
page,
'zoomOut',
false
);
await zoomOutButton.dblclick();
await assertEdgelessNonSelectedRect(page);
});
test('change note color', async ({ page }) => {
await enterPlaygroundRoom(page);
const { noteId } = await initEmptyEdgelessState(page);
await initThreeParagraphs(page);
await switchEditorMode(page);
await assertEdgelessNoteBackground(
page,
noteId,
lightThemeV2['edgeless/note/white']
);
await selectNoteInEdgeless(page, noteId);
await triggerComponentToolbarAction(page, 'changeNoteColor');
await changeEdgelessNoteBackground(page, 'Green');
await assertEdgelessNoteBackground(
page,
noteId,
lightThemeV2['edgeless/note/green']
);
});
test('cursor for active and inactive state', async ({ page }) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await focusRichText(page);
await type(page, 'hello');
await pressEnter(page);
await pressEnter(page);
await assertRichTexts(page, ['hello', '', '']);
await switchEditorMode(page);
await page.mouse.click(CENTER_X, CENTER_Y);
await waitNextFrame(page);
await assertTextSelection(page);
await page.mouse.dblclick(CENTER_X, CENTER_Y);
await waitNextFrame(page);
await assertTextSelection(page, {
blockId: '3',
index: 5,
length: 0,
});
});
test('when no visible note block, clicking in page mode will auto add a new note block', async ({
page,
}) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await switchEditorMode(page);
await assertBlockCount(page, 'edgeless-note', 1);
// select note
await selectNoteInEdgeless(page, '2');
await assertNoteSequence(page, '1');
await assertBlockCount(page, 'edgeless-note', 1);
// hide note
await triggerComponentToolbarAction(page, 'changeNoteDisplayMode');
await waitNextFrame(page);
await changeNoteDisplayMode(page, NoteDisplayMode.EdgelessOnly);
await switchEditorMode(page);
let note = await page.evaluate(() => {
return document.querySelector('affine-note');
});
expect(note).toBeNull();
await click(page, { x: 200, y: 280 });
note = await page.evaluate(() => {
return document.querySelector('affine-note');
});
expect(note).not.toBeNull();
});
test.fixme(
'Click at empty note should add a paragraph block',
async ({ page }) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await focusRichText(page);
await type(page, '123');
await assertRichTexts(page, ['123']);
await switchEditorMode(page);
// Drag paragraph out of note block
const paragraphBlock = await page
.locator(`[data-block-id="3"]`)
.boundingBox();
if (!paragraphBlock) {
throw new Error('paragraphBlock is not found');
}
await page.mouse.dblclick(paragraphBlock.x, paragraphBlock.y);
await waitNextFrame(page);
await page.mouse.move(
paragraphBlock.x + paragraphBlock.width / 2,
paragraphBlock.y + paragraphBlock.height / 2
);
await waitNextFrame(page);
const handle = await page
.locator('.affine-drag-handle-container')
.boundingBox();
if (!handle) {
throw new Error('handle is not found');
}
await page.mouse.move(
handle.x + handle.width / 2,
handle.y + handle.height / 2,
{ steps: 10 }
);
await page.mouse.down();
await page.mouse.move(100, 200, { steps: 30 });
await page.mouse.up();
// There should be two note blocks and one paragraph block
await assertRichTexts(page, ['123']);
await assertBlockCount(page, 'edgeless-note', 2);
await assertBlockCount(page, 'paragraph', 1);
// Click at empty note block to add a paragraph block
const emptyNote = await page.locator(`[data-block-id="2"]`).boundingBox();
if (!emptyNote) {
throw new Error('emptyNote is not found');
}
await page.mouse.click(
emptyNote.x + emptyNote.width / 2,
emptyNote.y + emptyNote.height / 2
);
await waitNextFrame(page, 300);
await type(page, '456');
await waitNextFrame(page, 400);
await page.mouse.click(100, 100);
await waitNextFrame(page, 400);
await assertBlockCount(page, 'paragraph', 2);
}
);
test('Should focus at closest text block when note collapse', async ({
page,
}) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
// Make sure there is no rich text content
await switchEditorMode(page);
await zoomResetByKeyboard(page);
await assertRichTexts(page, ['']);
// Select the note
await zoomOutByKeyboard(page);
const notePortalBox = await page
.locator('affine-edgeless-note')
.boundingBox();
if (!notePortalBox) {
throw new Error('notePortalBox is not found');
}
await page.mouse.click(notePortalBox.x + 10, notePortalBox.y + 10);
await waitNextFrame(page, 200);
const selectedRect = page
.locator('edgeless-selected-rect')
.locator('.affine-edgeless-selected-rect');
await expect(selectedRect).toBeVisible();
// Collapse the note
const selectedBox = await selectedRect.boundingBox();
if (!selectedBox) {
throw new Error('selectedBox is not found');
}
await page.mouse.move(
selectedBox.x + selectedBox.width / 2,
selectedBox.y + selectedBox.height
);
await page.mouse.down();
await page.mouse.move(
selectedBox.x + selectedBox.width / 2,
selectedBox.y + selectedBox.height + 200,
{ steps: 10 }
);
await page.mouse.up();
await expect(selectedRect).toBeVisible();
// Click at the bottom of note to focus at the closest text block
await page.mouse.click(
selectedBox.x + selectedBox.width / 2,
selectedBox.y + selectedBox.height - 20
);
await waitNextFrame(page, 200);
// Should be enter edit mode and there are no selected rect
await expect(selectedRect).toBeHidden();
// Focus at the closest text block and make sure can type
await type(page, 'hello');
await waitNextFrame(page, 200);
await assertRichTexts(page, ['hello']);
});
test('delete first block in edgeless note', async ({ page }) => {
await enterPlaygroundRoom(page);
await initEmptyEdgelessState(page);
await switchEditorMode(page);
await zoomResetByKeyboard(page);
await assertNoteXYWH(page, [0, 0, DEFAULT_NOTE_WIDTH, DEFAULT_NOTE_HEIGHT]);
await page.mouse.dblclick(CENTER_X, CENTER_Y);
// first block without children, nothing should happen
await assertRichTexts(page, ['']);
await assertBlockChildrenIds(page, '3', []);
await pressBackspace(page);
await type(page, 'aaa');
await pressEnter(page);
await type(page, 'bbb');
await pressTab(page);
await assertRichTexts(page, ['aaa', 'bbb']);
await assertBlockChildrenIds(page, '3', ['4']);
// first block with children, need to bring children to parent
await focusRichTextEnd(page);
await pressBackspace(page, 3);
await assertRichTexts(page, ['', 'bbb']);
await pressBackspace(page);
await assertRichTexts(page, ['bbb']);
await assertBlockChildrenIds(page, '4', []);
});
test('select text cross blocks in edgeless note', async ({ page }) => {
await enterPlaygroundRoom(page);
const { noteId } = await initEmptyEdgelessState(page);
await switchEditorMode(page);
await activeNoteInEdgeless(page, noteId);
await waitNextFrame(page, 400);
await type(page, 'aaa');
await pressEnter(page);
await type(page, 'bbb');
await pressEnter(page);
await type(page, 'ccc');
await assertRichTexts(page, ['aaa', 'bbb', 'ccc']);
await dragBetweenIndices(page, [0, 1], [2, 2]);
await pressBackspace(page);
await assertRichTexts(page, ['ac']);
});