pengx17
df99e2ca97
fix(electron): potential crash on quit ( #8829 )
...
fix AF-1696
Related log:
```
Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 Electron Framework 0x10c3bb09c electron::MessagePort::Close()
1 Electron Framework 0x10c3bcb78 gin::internal::Dispatcher<void (electron::MessagePort*)>::DispatchToCallbackImpl(gin::Arguments*)
2 Electron Framework 0x10c3bc984 gin::internal::Dispatcher<void (electron::MessagePort*)>::DispatchToCallback(v8::FunctionCallbackInfo<v8::Value> const&)
3 ??? 0x147e0f58c ???
4 ??? 0x147e0d45c ???
5 ??? 0x147e0d45c ???
6 ??? 0x147e0d45c ???
7 ??? 0x1401743b8 ???
8 ??? 0x147e0b088 ???
9 ??? 0x147e0acd4 ???
10 Electron Framework 0x10d657578 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*)
11 Electron Framework 0x10d53e478 v8::Function::Call(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*)
12 Electron Framework 0x11337ad34 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context)
13 Electron Framework 0x11337b0b0 node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context)
14 Electron Framework 0x10c46d9dc gin_helper::internal::CallMethodWithArgs(v8::Isolate*, v8::Local<v8::Object>, char const*, base::span<v8::Local<v8::Value>, 18446744073709551615ul, v8::Local<v8::Value>*>)
15 Electron Framework 0x10c3833b0 bool gin_helper::EventEmitterMixin<electron::api::WebContents>::Emit<>(std::__Cr::basic_string_view<char, std::__Cr::char_traits<char>>)
16 Electron Framework 0x10c38324c electron::api::WebContents::WebContentsDestroyed()
17 Electron Framework 0x10ebc2ee8 void content::WebContentsImpl::WebContentsObserverList::NotifyObservers<void (content::WebContentsObserver::*)()>(void (content::WebContentsObserver::*)())
18 Electron Framework 0x10ebc229c content::WebContentsImpl::~WebContentsImpl()
19 Electron Framework 0x10ebc32b0 content::WebContentsImpl::~WebContentsImpl()
20 Electron Framework 0x10c4212dc electron::InspectableWebContents::~InspectableWebContents()
21 Electron Framework 0x10c4213ac electron::InspectableWebContents::~InspectableWebContents()
22 Electron Framework 0x10c382ffc electron::api::WebContents::~WebContents()
23 Electron Framework 0x10c383498 non-virtual thunk to electron::api::WebContents::~WebContents()
24 Electron Framework 0x10c46cb80 gin_helper::CleanedUpAtExit::DoCleanup()
25 Electron Framework 0x10c3ec994 electron::JavascriptEnvironment::DestroyMicrotasksRunner()
26 Electron Framework 0x10c3d2828 electron::ElectronBrowserMainParts::PostMainMessageLoopRun()
27 Electron Framework 0x10e663458 content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
28 Electron Framework 0x10e664a80 content::BrowserMainRunnerImpl::Shutdown()
29 Electron Framework 0x10e661098 content::BrowserMain(content::MainFunctionParams)
30 Electron Framework 0x10c6339a4 content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*)
31 Electron Framework 0x10c634968 content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool)
32 Electron Framework 0x10c6347e8 content::ContentMainRunnerImpl::Run()
33 Electron Framework 0x10c633208 content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*)
34 Electron Framework 0x10c6332f0 content::ContentMain(content::ContentMainParams)
35 Electron Framework 0x10c2e98c0 ElectronMain
36 dyld 0x18b5a8274 start
```
2024-11-15 02:58:19 +00:00
renovate
3d3a66c3ed
chore: bump up electron version to v33 ( #8495 )
...
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [electron](https://redirect.github.com/electron/electron ) | [`^32.0.0` -> `^33.0.0`](https://renovatebot.com/diffs/npm/electron/32.1.2/33.0.0 ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>electron/electron (electron)</summary>
### [`v33.0.0`](https://redirect.github.com/electron/electron/compare/v32.2.0...v33.0.0 )
[Compare Source](https://redirect.github.com/electron/electron/compare/v32.2.0...v33.0.0 )
### [`v32.2.0`](https://redirect.github.com/electron/electron/releases/tag/v32.2.0 ): electron v32.2.0
[Compare Source](https://redirect.github.com/electron/electron/compare/v32.1.2...v32.2.0 )
### Release Notes for v32.2.0
#### Fixes
- Fixed a crash when calling `focus` on a `WebView`'s `webContents`. [#​43934](https://redirect.github.com/electron/electron/pull/43934 ) <span style="font-size:small;">(Also in [31](https://redirect.github.com/electron/electron/pull/43933 ), [33](https://redirect.github.com/electron/electron/pull/43932 ))</span>
- Fixed a potential issue accessing a child window document when overriding browserWindow creation via `setWindowOpenHandler`. [#​43877](https://redirect.github.com/electron/electron/pull/43877 ) <span style="font-size:small;">(Also in [31](https://redirect.github.com/electron/electron/pull/43878 ), [33](https://redirect.github.com/electron/electron/pull/43816 ))</span>
- Fixed an issue where an exception could be thrown on BrowserView after its owner BrowserWindow was closed. [#​44001](https://redirect.github.com/electron/electron/pull/44001 ) <span style="font-size:small;">(Also in [31](https://redirect.github.com/electron/electron/pull/43999 ), [33](https://redirect.github.com/electron/electron/pull/44000 ))</span>
- Fixed closing a window with more than one attached sheet on macOS. [#​43954](https://redirect.github.com/electron/electron/pull/43954 ) <span style="font-size:small;">(Also in [31](https://redirect.github.com/electron/electron/pull/43953 ), [33](https://redirect.github.com/electron/electron/pull/43952 ))</span>
- Fixed potential use-after-free during view removal on macOS. [#​43923](https://redirect.github.com/electron/electron/pull/43923 ) <span style="font-size:small;">(Also in [31](https://redirect.github.com/electron/electron/pull/43924 ), [33](https://redirect.github.com/electron/electron/pull/43922 ))</span>
#### Other Changes
- Ensured that the `sender-id` hint is set when creating desktop notifications on DBus. [#​43950](https://redirect.github.com/electron/electron/pull/43950 ) <span style="font-size:small;">(Also in [31](https://redirect.github.com/electron/electron/pull/43951 ), [33](https://redirect.github.com/electron/electron/pull/43949 ))</span>
- Updated Chromium to 128.0.6613.178. [#​44086](https://redirect.github.com/electron/electron/pull/44086 )
- Updated Node.js to v20.18.0. [#​44116](https://redirect.github.com/electron/electron/pull/44116 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/ ). View the [repository job log](https://developer.mend.io/github/toeverything/AFFiNE ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjAuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEyMC4xIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5IiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->
2024-10-15 07:18:28 +00:00
