diff --git a/packages/frontend/component/src/ui/menu/desktop/root.tsx b/packages/frontend/component/src/ui/menu/desktop/root.tsx index cad1a0f0ea..e7be21cd9f 100644 --- a/packages/frontend/component/src/ui/menu/desktop/root.tsx +++ b/packages/frontend/component/src/ui/menu/desktop/root.tsx @@ -1,5 +1,6 @@ import * as DropdownMenu from '@radix-ui/react-dropdown-menu'; import clsx from 'clsx'; +import React from 'react'; import type { MenuProps } from '../menu.types'; import * as styles from '../styles.css'; @@ -9,6 +10,7 @@ import * as desktopStyles from './styles.css'; export const DesktopMenu = ({ children, items, + noPortal, portalOptions, rootOptions: { onOpenChange, @@ -33,6 +35,7 @@ export const DesktopMenu = ({ side, sideOffset: (sideOffset ?? 0) + 5, }); + const ContentWrapper = noPortal ? React.Fragment : DropdownMenu.Portal; return ( - + {items} - + ); }; diff --git a/packages/frontend/component/src/ui/modal/modal.tsx b/packages/frontend/component/src/ui/modal/modal.tsx index 05f2073412..7a73d1dec7 100644 --- a/packages/frontend/component/src/ui/modal/modal.tsx +++ b/packages/frontend/component/src/ui/modal/modal.tsx @@ -9,7 +9,7 @@ import * as Dialog from '@radix-ui/react-dialog'; import * as VisuallyHidden from '@radix-ui/react-visually-hidden'; import { assignInlineVars } from '@vanilla-extract/dynamic'; import clsx from 'clsx'; -import type { CSSProperties, MouseEvent } from 'react'; +import type { CSSProperties } from 'react'; import { forwardRef, useCallback, useEffect, useState } from 'react'; import { startScopedViewTransition } from '../../utils'; @@ -142,7 +142,6 @@ export const ModalInner = forwardRef( overlayOptions: { className: overlayClassName, style: overlayStyle, - onClick: onOverlayClick, ...otherOverlayOptions } = {}, closeButtonOptions, @@ -191,19 +190,6 @@ export const ModalInner = forwardRef( [onEscapeKeyDown, persistent] ); - const handleOverlayClick = useCallback( - (e: MouseEvent) => { - onOverlayClick?.(e); - if (persistent) { - e.preventDefault(); - } else { - e.stopPropagation(); - onOpenChange?.(false); - } - }, - [onOpenChange, onOverlayClick, persistent] - ); - if (!container) { return; } @@ -226,74 +212,74 @@ export const ModalInner = forwardRef( style={{ ...overlayStyle, }} - onClick={handleOverlayClick} {...otherOverlayOptions} - /> -
- - {withoutCloseButton ? null : ( - - - - - - )} - {title ? ( - - {title} - - ) : ( - // Refer: https://www.radix-ui.com/primitives/docs/components/dialog#title - // If you want to hide the title, wrap it inside our Visually Hidden utility like this . - - - - )} - {description ? ( - - {description} - - ) : null} + + {withoutCloseButton ? null : ( + + + + + + )} + {title ? ( + + {title} + + ) : ( + // Refer: https://www.radix-ui.com/primitives/docs/components/dialog#title + // If you want to hide the title, wrap it inside our Visually Hidden utility like this . + + + + )} + {description ? ( + + {description} + + ) : null} - {children} - -
+ {children} + + + );