From f9903fd7480b887447adf6666fe1076df7a3d466 Mon Sep 17 00:00:00 2001 From: CatsJuice Date: Wed, 19 Jun 2024 09:21:23 +0000 Subject: [PATCH] fix(core): can't enter presentation again in share page (#7262) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix [TOV-916](https://linear.app/affine-design/issue/TOV-916/分享页面的-present-按钮在第二次进入演示模式时未生效) --- .../components/cloud/share-header-right-item/present.tsx | 8 ++------ packages/frontend/electron/renderer/app.tsx | 1 + 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/frontend/core/src/components/cloud/share-header-right-item/present.tsx b/packages/frontend/core/src/components/cloud/share-header-right-item/present.tsx index 6908dc495e..a43dd97e1d 100644 --- a/packages/frontend/core/src/components/cloud/share-header-right-item/present.tsx +++ b/packages/frontend/core/src/components/cloud/share-header-right-item/present.tsx @@ -45,13 +45,9 @@ export const PresentButton = () => { const edgelessPage = editorHost?.querySelector('affine-edgeless-root'); if (!edgelessPage) return; - edgelessPage.slots.edgelessToolUpdated.on(() => { + return edgelessPage.slots.edgelessToolUpdated.on(() => { setIsPresent(edgelessPage.edgelessTool.type === 'frameNavigator'); - }); - - return () => { - edgelessPage.slots.edgelessToolUpdated.dispose(); - }; + }).dispose; }, [editor?.host, isPresent]); return ( diff --git a/packages/frontend/electron/renderer/app.tsx b/packages/frontend/electron/renderer/app.tsx index 9f774d4b70..aa8512e2bb 100644 --- a/packages/frontend/electron/renderer/app.tsx +++ b/packages/frontend/electron/renderer/app.tsx @@ -35,6 +35,7 @@ const desktopWhiteList = [ '/open-app/url', '/upgrade-success', '/ai-upgrade-success', + '/share', ]; if ( !environment.isDesktop &&