diff --git a/blocksuite/affine/blocks/embed-doc/src/embed-synced-doc-block/embed-edgeless-synced-doc-block.ts b/blocksuite/affine/blocks/embed-doc/src/embed-synced-doc-block/embed-edgeless-synced-doc-block.ts index 176c186379..55d81238a1 100644 --- a/blocksuite/affine/blocks/embed-doc/src/embed-synced-doc-block/embed-edgeless-synced-doc-block.ts +++ b/blocksuite/affine/blocks/embed-doc/src/embed-synced-doc-block/embed-edgeless-synced-doc-block.ts @@ -20,7 +20,6 @@ import { choose } from 'lit/directives/choose.js'; import { classMap } from 'lit/directives/class-map.js'; import { guard } from 'lit/directives/guard.js'; import { styleMap } from 'lit/directives/style-map.js'; -import { when } from 'lit/directives/when.js'; import { EmbedSyncedDocConfigExtension } from './configs'; import { EmbedSyncedDocBlockComponent } from './embed-synced-doc-block'; @@ -123,22 +122,18 @@ export class EmbedEdgelessSyncedDocBlockComponent extends toEdgelessEmbedBlock(
${header}
- ${when( - !this.model.isFolded, - () => - html`
- ${this.isPageMode && this._isEmptySyncedDoc - ? html` -
- - This is a linked doc, you can add content here. - -
- ` - : guard([editorMode, syncedDoc], renderEditor)} -
-
` - )} +
+ ${this.isPageMode && this._isEmptySyncedDoc + ? html` +
+ + This is a linked doc, you can add content here. + +
+ ` + : guard([editorMode, syncedDoc], renderEditor)} +
+
` ); diff --git a/tests/affine-local/e2e/blocksuite/embed/synced.spec.ts b/tests/affine-local/e2e/blocksuite/embed/synced.spec.ts index 77a682d368..1eca8d4eaa 100644 --- a/tests/affine-local/e2e/blocksuite/embed/synced.spec.ts +++ b/tests/affine-local/e2e/blocksuite/embed/synced.spec.ts @@ -88,11 +88,11 @@ test.describe('edgeless', () => { const content = embedBlock.locator('editor-host'); await expect(foldButton).toHaveAttribute('data-folded', 'false'); - await expect(content).toBeVisible(); + await expect(content).toBeInViewport(); await foldButton.click(); - await expect(content).toBeHidden(); + await expect(content).not.toBeInViewport(); await expect(foldButton).toHaveAttribute('data-folded', 'true'); }); @@ -123,11 +123,11 @@ test.describe('edgeless', () => { const content = embedBlock.locator('editor-host'); await expect(foldButton).toHaveAttribute('data-folded', 'true'); - await expect(content).toBeHidden(); + await expect(content).not.toBeInViewport(); await foldButton.click(); await expect(foldButton).toHaveAttribute('data-folded', 'false'); - await expect(content).toBeVisible(); + await expect(content).toBeInViewport(); await embedBlock.click(); const [, , , h2] = await getSelectedXYWH(page); @@ -149,20 +149,20 @@ test.describe('edgeless', () => { await foldButton.click(); await resizeElementByHandle(page, [50, 0], 'bottom-right'); - await expect(content).toBeHidden(); + await expect(content).not.toBeInViewport(); await expect(foldButton).toHaveAttribute('data-folded', 'true'); await resizeElementByHandle(page, [-50, 0], 'bottom-right'); - await expect(content).toBeHidden(); + await expect(content).not.toBeInViewport(); await expect(foldButton).toHaveAttribute('data-folded', 'true'); await resizeElementByHandle(page, [0, 50], 'bottom-right'); await expect( content, 'should unfold the embed synced doc when adjust height to greater' - ).toBeVisible(); + ).toBeInViewport(); await expect(foldButton).toHaveAttribute('data-folded', 'false'); - await expect(content).toBeVisible(); + await expect(content).toBeInViewport(); }); }); });