From f492b6711b2b70f4cbf290dedd3b2ce3c8b45b1e Mon Sep 17 00:00:00 2001
From: Umar Faiz <83939820+umar23faiz@users.noreply.github.com>
Date: Thu, 22 Feb 2024 12:34:33 +0530
Subject: [PATCH] fix(core): the pitch zooming function incorrectly zooms the
 toolbar (#5456)

Co-authored-by: LongYinan <lynweklm@gmail.com>
---
 .../image-preview/hooks/use-zoom.tsx          | 22 ++++++++++++-------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/packages/frontend/core/src/components/image-preview/hooks/use-zoom.tsx b/packages/frontend/core/src/components/image-preview/hooks/use-zoom.tsx
index b6aaee95b3..2cdc060a71 100644
--- a/packages/frontend/core/src/components/image-preview/hooks/use-zoom.tsx
+++ b/packages/frontend/core/src/components/image-preview/hooks/use-zoom.tsx
@@ -96,11 +96,15 @@ export const useZoomControls = ({
     [dragEndImpl]
   );
 
-  const handleMouseUp = useCallback(() => {
-    if (isDragging) {
-      dragEndImpl();
-    }
-  }, [isDragging, dragEndImpl]);
+  const handleMouseUp = useCallback(
+    (evt: MouseEvent) => {
+      evt.preventDefault();
+      if (isDragging) {
+        dragEndImpl();
+      }
+    },
+    [isDragging, dragEndImpl]
+  );
 
   const checkZoomSize = useCallback(() => {
     const { current: zoomArea } = zoomRef;
@@ -183,15 +187,17 @@ export const useZoomControls = ({
 
   useEffect(() => {
     const handleScroll = (event: WheelEvent) => {
+      event.preventDefault();
       const { deltaY } = event;
       if (deltaY > 0) {
         zoomOut();
-      } else if (deltaY < 0) {
+      } else if (deltaY < 0 && currentScale < 2) {
         zoomIn();
       }
     };
 
-    const handleResize = () => {
+    const handleResize = (event: UIEvent) => {
+      event.preventDefault();
       checkZoomSize();
     };
 
@@ -206,7 +212,7 @@ export const useZoomControls = ({
       window.removeEventListener('resize', handleResize);
       window.removeEventListener('mouseup', handleMouseUp);
     };
-  }, [zoomIn, zoomOut, checkZoomSize, handleMouseUp]);
+  }, [zoomIn, zoomOut, checkZoomSize, handleMouseUp, currentScale]);
 
   return {
     zoomIn,