Jayden/AFFiNE-Mirror
0
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-08-24 13:17:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): suface component can be null (#12270)

Browse Source 
Closes: BS-3149

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **Refactor**
  - Improved internal handling of surface components across various tools, resulting in safer and more consistent access patterns.
  - Enhanced code maintainability and reliability without altering any visible features or user workflows.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Saul-Mirone
2025-05-14 08:37:10 +00:00
parent 7e722957a9
commit f2164e4d70
6 changed files with 39 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
blocksuite/affine/gfx/brush/src/eraser-tool.ts
+8 -7
View File
@@ -34,6 +34,10 @@ export class EraserTool extends BaseTool {
private readonly _eraseTargets = new Set<GfxModel>();
private get _surfaceComponent() {
return this.gfx.surfaceComponent as SurfaceBlockComponent | null;
}
private readonly _loop = () => {
const now = Date.now();
const elapsed = now - this._timestamp;
@@ -59,7 +63,7 @@ export class EraserTool extends BaseTool {
})
);
this._overlay.d = d;
(this.gfx.surfaceComponent as SurfaceBlockComponent)?.refresh();
this._surfaceComponent?.refresh();
}
this._timer = requestAnimationFrame(this._loop);
};
@@ -81,9 +85,7 @@ export class EraserTool extends BaseTool {
return;
}
(
this.gfx.surfaceComponent as SurfaceBlockComponent
)?.renderer.removeOverlay(this._overlay);
this._surfaceComponent?.renderer.removeOverlay(this._overlay);
this._erasable.clear();
this._eraseTargets.clear();
}
@@ -150,8 +152,7 @@ export class EraserTool extends BaseTool {
...this.gfx.layer.blocks,
]);
this._loop();
(this.gfx.surfaceComponent as SurfaceBlockComponent)?.renderer.addOverlay(
this._overlay
);
this._surfaceComponent?.renderer.addOverlay(this._overlay);
}
}