From ebb38a42a0412d2eeb2c6d369f90d1123f01f9eb Mon Sep 17 00:00:00 2001 From: pengx17 Date: Tue, 16 Apr 2024 06:57:17 +0000 Subject: [PATCH] fix: temporary fix for running electron tests (#6576) a workaround for spawn EINVAL error. Found this issue according to https://github.com/node-red/node-red/pull/4652 ~~In our case the electron app is spawned by playwright. I am still investigating the issue but don't know how long it takes.~~ Upstream fix: https://github.com/microsoft/playwright/pull/30382 --- .nvmrc | 2 +- packages/frontend/electron/scripts/dev.ts | 1 + packages/frontend/electron/scripts/generate-assets.ts | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.nvmrc b/.nvmrc index 209e3ef4b6..bc78e9f269 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -20 +20.12.1 diff --git a/packages/frontend/electron/scripts/dev.ts b/packages/frontend/electron/scripts/dev.ts index 3b990341c9..4ab9d5f616 100644 --- a/packages/frontend/electron/scripts/dev.ts +++ b/packages/frontend/electron/scripts/dev.ts @@ -37,6 +37,7 @@ function spawnOrReloadElectron() { spawnProcess = spawn(exe, ['.'], { cwd: electronDir, env: process.env, + shell: true, }); spawnProcess.stdout.on('data', d => { diff --git a/packages/frontend/electron/scripts/generate-assets.ts b/packages/frontend/electron/scripts/generate-assets.ts index a66ca1fbb4..68452316d4 100755 --- a/packages/frontend/electron/scripts/generate-assets.ts +++ b/packages/frontend/electron/scripts/generate-assets.ts @@ -55,12 +55,14 @@ if (!process.env.SKIP_WEB_BUILD) { stdio: 'inherit', env: process.env, cwd, + shell: true, }); spawnSync('yarn', ['workspace', '@affine/electron', 'build'], { stdio: 'inherit', env: process.env, cwd, + shell: true, }); // step 1.5: amend sourceMappingURL to allow debugging in devtools