Jayden/AFFiNE-Mirror
1
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-02-12 12:28:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(editor): perf optimization of flat data (#10494)

Browse Source 
The new code should be more efficient as it:
- Avoids unnecessary iterations when objects aren't empty
- Has clearer path management
- Reduces redundant object traversals
This commit is contained in:
Saul-Mirone
2025-02-28 04:51:54 +00:00
parent 1d865ad883
commit e90c00c3b7
1 changed files with 21 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
blocksuite/framework/store/src/reactive/flat-native-y.ts
View File

@@ -318,20 +318,26 @@ export class ReactiveFlatYMap extends BaseReactiveYData<
return;
}
this._updateWithYjsSkip(() => {
void keys.reduce((acc, key, index, arr) => {
if (index === arr.length - 1) {
void keys.reduce((acc, key, index) => {
if (index === keys.length - 1) {
delete acc[key];
let i = index - 1;
let curr = acc;
while (i > 0) {
const parentPath = keys.slice(0, i);
const parentKey = keys[i];
const parent = parentPath.reduce((acc, key) => {
return acc[key] as UnRecord;
}, proxy as UnRecord);
let parentKey = keys[index - 1];
let parent = proxy as UnRecord;
let path = keys.slice(0, -2);
for (let i = keys.length - 2; i > 0; i--) {
for (const pathKey of path) {
parent = parent[pathKey] as UnRecord;
}
if (!isEmptyObject(curr)) {
break;
}
deleteEmptyObject(curr, parentKey, parent);
curr = parent;
i--;
parentKey = keys[i - 1];
path = path.slice(0, -1);
parent = proxy as UnRecord;
}
}
return acc[key] as UnRecord;
@@ -487,8 +493,12 @@ export class ReactiveFlatYMap extends BaseReactiveYData<
};
}
function isEmptyObject(obj: UnRecord): boolean {
return Object.keys(obj).length === 0;
}
function deleteEmptyObject(obj: UnRecord, key: string, parent: UnRecord): void {
if (Object.keys(obj).length === 0) {
if (isEmptyObject(obj)) {
delete parent[key];
}
}