From dbcfd24ed8867fd5566b4e16870aa7c79be665ca Mon Sep 17 00:00:00 2001 From: Don Isaac Date: Mon, 26 Aug 2024 02:23:56 -0400 Subject: [PATCH] fix: remove unused variables (#7968) --- packages/backend/server/src/core/auth/service.ts | 2 +- packages/backend/server/src/core/quota/service.ts | 2 +- packages/backend/server/src/core/utils/doc.ts | 2 +- packages/backend/server/src/core/workspaces/controller.ts | 2 +- packages/backend/server/src/fundamentals/helpers/url.ts | 2 +- .../backend/server/src/fundamentals/storage/providers/fs.ts | 2 +- .../backend/server/src/fundamentals/storage/providers/utils.ts | 2 +- .../server/src/plugins/copilot/workflow/executor/check-html.ts | 2 +- .../server/src/plugins/copilot/workflow/executor/check-json.ts | 2 +- packages/common/infra/src/app-config-storage.ts | 2 +- packages/common/infra/src/framework/core/framework.ts | 2 +- .../src/components/auth-components/onboarding-page.tsx | 2 +- packages/frontend/core/src/hooks/affine/use-share-url.ts | 2 +- packages/frontend/core/src/modules/cloud/services/fetch.ts | 2 +- packages/frontend/core/src/pages/magic-link.tsx | 2 +- packages/frontend/core/src/utils/navigable-history.ts | 2 +- packages/frontend/electron/scripts/generate-yml.js | 2 +- packages/frontend/i18n/src/scripts/download.ts | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/packages/backend/server/src/core/auth/service.ts b/packages/backend/server/src/core/auth/service.ts index 81191d2b4b..58a9d8c035 100644 --- a/packages/backend/server/src/core/auth/service.ts +++ b/packages/backend/server/src/core/auth/service.ts @@ -83,7 +83,7 @@ export class AuthService implements OnApplicationBootstrap { await this.quota.switchUserQuota(devUser.id, QuotaType.ProPlanV1); await this.feature.addAdmin(devUser.id); await this.feature.addCopilot(devUser.id); - } catch (e) { + } catch { // ignore } } diff --git a/packages/backend/server/src/core/quota/service.ts b/packages/backend/server/src/core/quota/service.ts index 7808dcbfa6..c5193e768e 100644 --- a/packages/backend/server/src/core/quota/service.ts +++ b/packages/backend/server/src/core/quota/service.ts @@ -69,7 +69,7 @@ export class QuotaService { ...quota, feature: await QuotaConfig.get(this.prisma, quota.featureId), }; - } catch (_) {} + } catch {} return null as unknown as typeof quota & { feature: QuotaConfig; }; diff --git a/packages/backend/server/src/core/utils/doc.ts b/packages/backend/server/src/core/utils/doc.ts index 52c59204c4..34e535a8bc 100644 --- a/packages/backend/server/src/core/utils/doc.ts +++ b/packages/backend/server/src/core/utils/doc.ts @@ -21,7 +21,7 @@ export class DocID { static parse(raw: string): DocID | null { try { return new DocID(raw); - } catch (e) { + } catch { return null; } } diff --git a/packages/backend/server/src/core/workspaces/controller.ts b/packages/backend/server/src/core/workspaces/controller.ts index ee859c0d53..5ce1e81f7c 100644 --- a/packages/backend/server/src/core/workspaces/controller.ts +++ b/packages/backend/server/src/core/workspaces/controller.ts @@ -140,7 +140,7 @@ export class WorkspacesController { let ts; try { ts = new Date(timestamp); - } catch (e) { + } catch { throw new InvalidHistoryTimestamp({ timestamp }); } diff --git a/packages/backend/server/src/fundamentals/helpers/url.ts b/packages/backend/server/src/fundamentals/helpers/url.ts index 3869b6ebe5..48bf54fe18 100644 --- a/packages/backend/server/src/fundamentals/helpers/url.ts +++ b/packages/backend/server/src/fundamentals/helpers/url.ts @@ -89,7 +89,7 @@ export class URLHelper { if (!['http:', 'https:'].includes(url.protocol)) return false; if (!url.hostname) return false; return true; - } catch (_) { + } catch { return false; } } diff --git a/packages/backend/server/src/fundamentals/storage/providers/fs.ts b/packages/backend/server/src/fundamentals/storage/providers/fs.ts index 9b2dafea68..282396c98d 100644 --- a/packages/backend/server/src/fundamentals/storage/providers/fs.ts +++ b/packages/backend/server/src/fundamentals/storage/providers/fs.ts @@ -123,7 +123,7 @@ export class FsStorageProvider implements StorageProvider { }); } } - } catch (e) { + } catch { // failed to read dir, stop recursion } } diff --git a/packages/backend/server/src/fundamentals/storage/providers/utils.ts b/packages/backend/server/src/fundamentals/storage/providers/utils.ts index f8ac254e11..a0eab7d8c5 100644 --- a/packages/backend/server/src/fundamentals/storage/providers/utils.ts +++ b/packages/backend/server/src/fundamentals/storage/providers/utils.ts @@ -42,7 +42,7 @@ export async function autoMetadata( } return metadata; - } catch (e) { + } catch { return metadata; } } diff --git a/packages/backend/server/src/plugins/copilot/workflow/executor/check-html.ts b/packages/backend/server/src/plugins/copilot/workflow/executor/check-html.ts index af149aba5d..be24883ba6 100644 --- a/packages/backend/server/src/plugins/copilot/workflow/executor/check-html.ts +++ b/packages/backend/server/src/plugins/copilot/workflow/executor/check-html.ts @@ -43,7 +43,7 @@ export class CopilotCheckHtmlExecutor extends AutoRegisteredWorkflowExecutor { } } return false; - } catch (e) { + } catch { return false; } } diff --git a/packages/backend/server/src/plugins/copilot/workflow/executor/check-json.ts b/packages/backend/server/src/plugins/copilot/workflow/executor/check-json.ts index 0fb061d341..742dcd9521 100644 --- a/packages/backend/server/src/plugins/copilot/workflow/executor/check-json.ts +++ b/packages/backend/server/src/plugins/copilot/workflow/executor/check-json.ts @@ -34,7 +34,7 @@ export class CopilotCheckJsonExecutor extends AutoRegisteredWorkflowExecutor { return true; } return false; - } catch (e) { + } catch { return false; } } diff --git a/packages/common/infra/src/app-config-storage.ts b/packages/common/infra/src/app-config-storage.ts index 5db0127d2d..b4d5376bf0 100644 --- a/packages/common/infra/src/app-config-storage.ts +++ b/packages/common/infra/src/app-config-storage.ts @@ -64,7 +64,7 @@ class Storage { return this._options.config; } return cfg; - } catch (err) { + } catch { return this._cfg; } } else { diff --git a/packages/common/infra/src/framework/core/framework.ts b/packages/common/infra/src/framework/core/framework.ts index 7dc2c7e207..30f1173d46 100644 --- a/packages/common/infra/src/framework/core/framework.ts +++ b/packages/common/infra/src/framework/core/framework.ts @@ -521,7 +521,7 @@ function isConstructor(cls: any) { try { Reflect.construct(function () {}, [], cls); return true; - } catch (error) { + } catch { return false; } } diff --git a/packages/frontend/component/src/components/auth-components/onboarding-page.tsx b/packages/frontend/component/src/components/auth-components/onboarding-page.tsx index 89aac5e611..75c16f350e 100644 --- a/packages/frontend/component/src/components/auth-components/onboarding-page.tsx +++ b/packages/frontend/component/src/components/auth-components/onboarding-page.tsx @@ -45,7 +45,7 @@ function getCallbackUrl(location: Location) { const parsedUrl = new URL(url); return parsedUrl.pathname + parsedUrl.search; } - } catch (_) {} + } catch {} return null; } diff --git a/packages/frontend/core/src/hooks/affine/use-share-url.ts b/packages/frontend/core/src/hooks/affine/use-share-url.ts index ae5a19f8fb..9ed2b91a29 100644 --- a/packages/frontend/core/src/hooks/affine/use-share-url.ts +++ b/packages/frontend/core/src/hooks/affine/use-share-url.ts @@ -49,7 +49,7 @@ const generateUrl = ({ url.searchParams.append('xywh', xywh); } return url.toString(); - } catch (e) { + } catch { return null; } }; diff --git a/packages/frontend/core/src/modules/cloud/services/fetch.ts b/packages/frontend/core/src/modules/cloud/services/fetch.ts index 0936f9c0b1..4fab36f618 100644 --- a/packages/frontend/core/src/modules/cloud/services/fetch.ts +++ b/packages/frontend/core/src/modules/cloud/services/fetch.ts @@ -72,7 +72,7 @@ export class FetchService extends Service { if (res.headers.get('Content-Type')?.includes('application/json')) { try { reason = await res.json(); - } catch (err) { + } catch { // ignore } } diff --git a/packages/frontend/core/src/pages/magic-link.tsx b/packages/frontend/core/src/pages/magic-link.tsx index 3abe2c6d2d..6f833c4253 100644 --- a/packages/frontend/core/src/pages/magic-link.tsx +++ b/packages/frontend/core/src/pages/magic-link.tsx @@ -24,7 +24,7 @@ export const loader: LoaderFunction = async ({ request }) => { try { const { message } = await res.json(); error = message; - } catch (e) { + } catch { error = 'failed to verify sign-in token'; } return redirect(`/signIn?error=${encodeURIComponent(error)}`); diff --git a/packages/frontend/core/src/utils/navigable-history.ts b/packages/frontend/core/src/utils/navigable-history.ts index a1d3e02b7b..0fcff1aba0 100644 --- a/packages/frontend/core/src/utils/navigable-history.ts +++ b/packages/frontend/core/src/utils/navigable-history.ts @@ -187,7 +187,7 @@ function warning(cond: any, message: string) { // enabling "pause on exceptions" in your JavaScript debugger. throw new Error(message); // eslint-disable-next-line no-empty - } catch (e) {} + } catch {} } } diff --git a/packages/frontend/electron/scripts/generate-yml.js b/packages/frontend/electron/scripts/generate-yml.js index 89dc4ff10d..f1c2612c16 100644 --- a/packages/frontend/electron/scripts/generate-yml.js +++ b/packages/frontend/electron/scripts/generate-yml.js @@ -32,7 +32,7 @@ const generateYml = platform => { sha512: hash, size: size, }); - } catch (e) {} + } catch {} }); // path & sha512 are deprecated yml.path = yml.files[0].url; diff --git a/packages/frontend/i18n/src/scripts/download.ts b/packages/frontend/i18n/src/scripts/download.ts index 52c7597a8a..71110951e8 100644 --- a/packages/frontend/i18n/src/scripts/download.ts +++ b/packages/frontend/i18n/src/scripts/download.ts @@ -49,7 +49,7 @@ const getBaseTranslations = async (baseLanguage: { tag: string }) => { const main = async () => { try { await fs.access(RES_DIR); - } catch (error) { + } catch { fs.mkdir(RES_DIR).catch(console.error); console.log('Create directory', RES_DIR); }