From d80c80ecdd796323bb542ccf51a7281936829976 Mon Sep 17 00:00:00 2001 From: pengx17 Date: Tue, 30 Jul 2024 11:38:23 +0000 Subject: [PATCH] fix: remove shadow for bordered main container (#7655) fix PD-1498 --- packages/frontend/core/src/components/workspace/index.css.ts | 3 --- .../src/modules/workbench/view/split-view/split-view.css.ts | 5 ++++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/frontend/core/src/components/workspace/index.css.ts b/packages/frontend/core/src/components/workspace/index.css.ts index 0fe123c0d9..4e33a98e9c 100644 --- a/packages/frontend/core/src/components/workspace/index.css.ts +++ b/packages/frontend/core/src/components/workspace/index.css.ts @@ -56,9 +56,6 @@ export const mainContainerStyle = style({ borderRadius: 6, margin: '8px', overflow: 'clip', - // TODO(@Peng): is this performance intensive? - // TODO(@catsjuice): not match with design's shadow, theme missing - filter: 'drop-shadow(0px 0px 4px rgba(66,65,73,.14))', '@media': { print: { overflow: 'visible', diff --git a/packages/frontend/core/src/modules/workbench/view/split-view/split-view.css.ts b/packages/frontend/core/src/modules/workbench/view/split-view/split-view.css.ts index f9c6c889e5..344117079d 100644 --- a/packages/frontend/core/src/modules/workbench/view/split-view/split-view.css.ts +++ b/packages/frontend/core/src/modules/workbench/view/split-view/split-view.css.ts @@ -43,11 +43,14 @@ export const splitViewPanel = style({ }, '[data-client-border="false"] &:not([data-is-last="true"]):not([data-is-dragging="true"])': { - borderRight: `1px solid ${cssVar('borderColor')}`, + borderRight: `0.5px solid ${cssVar('borderColor')}`, }, '&[data-is-dragging="true"]': { zIndex: 1, }, + '[data-client-border="true"] &': { + border: `0.5px solid ${cssVar('borderColor')}`, + }, }, });