From d7be1b3424a8cb7c772061eb81631db47ebcdc9a Mon Sep 17 00:00:00 2001 From: akumatus Date: Mon, 28 Apr 2025 14:25:28 +0000 Subject: [PATCH] fix(core): skip onboarding in e2e tests (#12044) ## Summary by CodeRabbit - **Chores** - Updated test setup to automatically skip onboarding steps during environment initialization. - Simplified test utility methods by removing notification handling logic from chat panel and editor mode switching processes. --- .../e2e/utils/chat-panel-utils.ts | 3 --- .../affine-cloud-copilot/e2e/utils/editor-utils.ts | 14 -------------- tests/affine-cloud-copilot/e2e/utils/test-utils.ts | 2 ++ tests/affine-cloud-copilot/global-setup.ts | 5 ++++- 4 files changed, 6 insertions(+), 18 deletions(-) diff --git a/tests/affine-cloud-copilot/e2e/utils/chat-panel-utils.ts b/tests/affine-cloud-copilot/e2e/utils/chat-panel-utils.ts index 4a417a7148..d6b1104f1f 100644 --- a/tests/affine-cloud-copilot/e2e/utils/chat-panel-utils.ts +++ b/tests/affine-cloud-copilot/e2e/utils/chat-panel-utils.ts @@ -32,9 +32,6 @@ export class ChatPanelUtils { }); await page.waitForTimeout(500); // wait the sidebar stable } - if (await page.getByTestId('notification-close-button').isVisible()) { - await page.getByTestId('notification-close-button').click(); - } await page.getByTestId('sidebar-tab-chat').click(); await expect(page.getByTestId('sidebar-tab-content-chat')).toBeVisible(); } diff --git a/tests/affine-cloud-copilot/e2e/utils/editor-utils.ts b/tests/affine-cloud-copilot/e2e/utils/editor-utils.ts index e732a7d9b6..04017b6b0b 100644 --- a/tests/affine-cloud-copilot/e2e/utils/editor-utils.ts +++ b/tests/affine-cloud-copilot/e2e/utils/editor-utils.ts @@ -53,20 +53,6 @@ export class EditorUtils { await page.getByTestId('switch-edgeless-mode-button').click(); await editor.waitForElementState('hidden'); await page.waitForSelector('edgeless-editor'); - try { - const edgelessNotificationClose = page.getByTestId( - 'notification-close-button' - ); - await edgelessNotificationClose.waitFor({ - state: 'visible', - timeout: 2000, - }); - await edgelessNotificationClose.click(); - // Focus to the edgeless editor - await page.mouse.click(400, 400); - } catch { - // do nothing if the notification close button is not found - } } public static async switchToPageMode(page: Page) { diff --git a/tests/affine-cloud-copilot/e2e/utils/test-utils.ts b/tests/affine-cloud-copilot/e2e/utils/test-utils.ts index 9ec142a71f..474845055f 100644 --- a/tests/affine-cloud-copilot/e2e/utils/test-utils.ts +++ b/tests/affine-cloud-copilot/e2e/utils/test-utils.ts @@ -1,3 +1,4 @@ +import { skipOnboarding } from '@affine-test/kit/playwright'; import { createRandomAIUser } from '@affine-test/kit/utils/cloud'; import { openHomePage, setCoreUrl } from '@affine-test/kit/utils/load-page'; import { @@ -58,6 +59,7 @@ export class TestUtils { } public async setupTestEnvironment(page: Page) { + await skipOnboarding(page.context()); await openHomePage(page); await this.createNewPage(page); } diff --git a/tests/affine-cloud-copilot/global-setup.ts b/tests/affine-cloud-copilot/global-setup.ts index 2a4e0253d5..401a4b34fd 100644 --- a/tests/affine-cloud-copilot/global-setup.ts +++ b/tests/affine-cloud-copilot/global-setup.ts @@ -1,5 +1,6 @@ import fs from 'node:fs'; +import { skipOnboarding } from '@affine-test/kit/playwright'; import { createRandomAIUser, enableCloudWorkspace, @@ -20,7 +21,9 @@ async function setupTestEnvironment(page: Page) { export default async function globalSetup() { const browser = await chromium.launch(); - const page = await browser.newPage(); + const context = await browser.newContext(); + await skipOnboarding(context); + const page = await context.newPage(); await page.goto('http://localhost:8080/', { timeout: 240 * 1000 }); const user = await getUser(); await page.getByTestId('sidebar-user-avatar').click({