fix: use overflow: clip instead of js to prevent scrolling with pgup/pgdown (#6338)

This commit is contained in:
pengx17
2024-03-27 07:07:22 +00:00
parent 5ca17c155a
commit d4c7d58b00
2 changed files with 2 additions and 16 deletions

View File

@@ -49,7 +49,7 @@ export const mainContainerStyle = style({
width: 0,
display: 'flex',
flex: 1,
overflow: 'hidden',
overflow: 'clip',
maxWidth: '100%',
transition: 'margin-left 0.2s ease',
selectors: {

View File

@@ -27,14 +27,13 @@ import {
} from '@toeverything/infra';
import clsx from 'clsx';
import { useSetAtom } from 'jotai';
import type { KeyboardEventHandler, ReactElement } from 'react';
import type { ReactElement } from 'react';
import {
memo,
useCallback,
useEffect,
useLayoutEffect,
useMemo,
useRef,
useState,
} from 'react';
import { useParams } from 'react-router-dom';
@@ -203,17 +202,6 @@ const DetailPageImpl = memo(function DetailPageImpl() {
);
const isWindowsDesktop = environment.isDesktop && environment.isWindows;
const scrollableRef = useRef<HTMLDivElement>(null);
const keydownHandler: KeyboardEventHandler = useCallback(e => {
// prevent pgup/pgdown from scrolling the page
if (e.key === 'PageUp' || e.key === 'PageDown') {
e.preventDefault();
scrollableRef.current?.scrollBy({
top: e.key === 'PageUp' ? -window.innerHeight : window.innerHeight,
behavior: 'smooth',
});
}
}, []);
return (
<>
@@ -230,8 +218,6 @@ const DetailPageImpl = memo(function DetailPageImpl() {
<TopTip pageId={currentPageId} workspace={currentWorkspace} />
<Scrollable.Root>
<Scrollable.Viewport
ref={scrollableRef}
onKeyDown={keydownHandler}
className={clsx(
'affine-page-viewport',
styles.affineDocViewport,