chore: prohibit unnecessary await (#4586)

apps/core/src/bootstrap/plugins/setup.ts

@@ -358,9 +358,7 @@ function createSetupImpl(rootStore: ReturnType<typeof createStore>) {
             },
           }
         ),
-        navigator: {
-          userAgent: navigator.userAgent,
-        },
+        navigator: globalThis.navigator,
 
         MouseEvent: globalThis.MouseEvent,
         KeyboardEvent: globalThis.KeyboardEvent,

apps/core/src/components/page-detail-editor.tsx

@@ -42,7 +42,10 @@ export interface PageDetailEditorProps {
   isPublic?: boolean;
   workspace: Workspace;
   pageId: string;
-  onInit: (page: Page, editor: Readonly<EditorContainer>) => void;
+  onInit: (
+    page: Page,
+    editor: Readonly<EditorContainer>
+  ) => Promise<void> | void;
   onLoad?: OnLoadEditor;
 }
 

apps/core/src/hooks/use-workspaces.ts

@@ -112,7 +112,7 @@ export function useAppHelper() {
           targetWorkspace
         );
         // delete workspace from jotai storage
-        await set(workspaces => workspaces.filter(ws => ws.id !== workspaceId));
+        set(workspaces => workspaces.filter(ws => ws.id !== workspaceId));
       },
       [jotaiWorkspaces, set]
     ),

apps/core/src/pages/share/detail-page.tsx

@@ -70,7 +70,7 @@ export const Component = (): ReactElement => {
           isPublic
           workspace={page.workspace}
           pageId={page.id}
-          onInit={useCallback(() => noop, [])}
+          onInit={noop}
           onLoad={useCallback(() => noop, [])}
         />
       </MainContainer>