fix: add no-new-array rule (#5117)

.eslintrc.js

@@ -214,6 +214,7 @@ const config = {
     'unicorn/prefer-date-now': 'error',
     'unicorn/no-typeof-undefined': 'error',
     'unicorn/no-useless-promise-resolve-reject': 'error',
+    'unicorn/no-new-array': 'error',
     'unicorn/new-for-builtins': 'error',
     'sonarjs/no-all-duplicated-branches': 'error',
     'sonarjs/no-element-overwrite': 'error',

packages/backend/server/tests/history.spec.ts

@@ -183,26 +183,30 @@ test('should correctly list all history records', async t => {
 
   // insert expired data
   await db.snapshotHistory.createMany({
-    data: new Array(10).fill(0).map((_, i) => ({
+    data: Array.from({ length: 10 })
-      workspaceId: snapshot.workspaceId,
+      .fill(0)
-      id: snapshot.id,
+      .map((_, i) => ({
-      blob: snapshot.blob,
+        workspaceId: snapshot.workspaceId,
-      state: snapshot.state,
+        id: snapshot.id,
-      timestamp: new Date(timestamp - 10 - i),
+        blob: snapshot.blob,
-      expiredAt: new Date(timestamp - 1),
+        state: snapshot.state,
-    })),
+        timestamp: new Date(timestamp - 10 - i),
+        expiredAt: new Date(timestamp - 1),
+      })),
   });
 
   // insert available data
   await db.snapshotHistory.createMany({
-    data: new Array(10).fill(0).map((_, i) => ({
+    data: Array.from({ length: 10 })
-      workspaceId: snapshot.workspaceId,
+      .fill(0)
-      id: snapshot.id,
+      .map((_, i) => ({
-      blob: snapshot.blob,
+        workspaceId: snapshot.workspaceId,
-      state: snapshot.state,
+        id: snapshot.id,
-      timestamp: new Date(timestamp + i),
+        blob: snapshot.blob,
-      expiredAt: new Date(timestamp + 1000),
+        state: snapshot.state,
-    })),
+        timestamp: new Date(timestamp + i),
+        expiredAt: new Date(timestamp + 1000),
+      })),
   });
 
   const list = await manager.list(
@@ -243,14 +247,16 @@ test('should be able to get last history record', async t => {
 
   // insert available data
   await db.snapshotHistory.createMany({
-    data: new Array(10).fill(0).map((_, i) => ({
+    data: Array.from({ length: 10 })
-      workspaceId: snapshot.workspaceId,
+      .fill(0)
-      id: snapshot.id,
+      .map((_, i) => ({
-      blob: snapshot.blob,
+        workspaceId: snapshot.workspaceId,
-      state: snapshot.state,
+        id: snapshot.id,
-      timestamp: new Date(timestamp + i),
+        blob: snapshot.blob,
-      expiredAt: new Date(timestamp + 1000),
+        state: snapshot.state,
-    })),
+        timestamp: new Date(timestamp + i),
+        expiredAt: new Date(timestamp + 1000),
+      })),
   });
 
   const history = await manager.last(snapshot.workspaceId, snapshot.id);
@@ -299,26 +305,30 @@ test('should be able to cleanup expired history', async t => {
 
   // insert expired data
   await db.snapshotHistory.createMany({
-    data: new Array(10).fill(0).map((_, i) => ({
+    data: Array.from({ length: 10 })
-      workspaceId: snapshot.workspaceId,
+      .fill(0)
-      id: snapshot.id,
+      .map((_, i) => ({
-      blob: snapshot.blob,
+        workspaceId: snapshot.workspaceId,
-      state: snapshot.state,
+        id: snapshot.id,
-      timestamp: new Date(timestamp - 10 - i),
+        blob: snapshot.blob,
-      expiredAt: new Date(timestamp - 1),
+        state: snapshot.state,
-    })),
+        timestamp: new Date(timestamp - 10 - i),
+        expiredAt: new Date(timestamp - 1),
+      })),
   });
 
   // insert available data
   await db.snapshotHistory.createMany({
-    data: new Array(10).fill(0).map((_, i) => ({
+    data: Array.from({ length: 10 })
-      workspaceId: snapshot.workspaceId,
+      .fill(0)
-      id: snapshot.id,
+      .map((_, i) => ({
-      blob: snapshot.blob,
+        workspaceId: snapshot.workspaceId,
-      state: snapshot.state,
+        id: snapshot.id,
-      timestamp: new Date(timestamp + i),
+        blob: snapshot.blob,
-      expiredAt: new Date(timestamp + 1000),
+        state: snapshot.state,
-    })),
+        timestamp: new Date(timestamp + i),
+        expiredAt: new Date(timestamp + 1000),
+      })),
   });
 
   let count = await db.snapshotHistory.count();

packages/frontend/component/src/components/setting-components/workspace-detail-skeleton.tsx

@@ -8,17 +8,19 @@ export const WorkspaceDetailSkeleton = () => {
     <>
       <SettingHeader title={<Skeleton />} subtitle={<Skeleton />} />
 
-      {new Array(3).fill(0).map((_, index) => {
+      {Array.from({ length: 3 })
-        return (
+        .fill(0)
-          <SettingWrapper title={<Skeleton />} key={index}>
+        .map((_, index) => {
-            <SettingRow
+          return (
-              name={<Skeleton />}
+            <SettingWrapper title={<Skeleton />} key={index}>
-              desc={<Skeleton />}
+              <SettingRow
-              spreadCol={false}
+                name={<Skeleton />}
-            ></SettingRow>
+                desc={<Skeleton />}
-          </SettingWrapper>
+                spreadCol={false}
-        );
+              ></SettingRow>
-      })}
+            </SettingWrapper>
+          );
+        })}
     </>
   );
 };

packages/frontend/component/src/components/setting-components/workspace-list-skeleton.tsx

@@ -26,9 +26,11 @@ export const WorkspaceListItemSkeleton = () => {
 export const WorkspaceListSkeleton = () => {
   return (
     <>
-      {new Array(5).fill(0).map((_, index) => {
+      {Array.from({ length: 5 })
-        return <WorkspaceListItemSkeleton key={index} />;
+        .fill(0)
-      })}
+        .map((_, index) => {
+          return <WorkspaceListItemSkeleton key={index} />;
+        })}
     </>
   );
 };

packages/frontend/graphql/src/utils.ts

@@ -3,7 +3,7 @@ export const TRACE_ID_BYTES = 16;
 export const TRACE_VERSION = '00';
 export const TRACE_FLAG = '01';
 
-const BytesBuffer = new Array(32);
+const BytesBuffer = Array.from<number>({ length: 32 });
 
 type TraceSpan = {
   name: string;

tests/affine-cloud/e2e/collaboration.spec.ts

@@ -265,7 +265,9 @@ test.describe('collaboration members', () => {
       await addUserToWorkspace(workspaceId, userB.id, 1 /* READ */);
     };
     await Promise.all(
-      new Array(10).fill(1).map(() => createUserAndAddToWorkspace())
+      Array.from({ length: 10 })
+        .fill(1)
+        .map(() => createUserAndAddToWorkspace())
     );
 
     await openSettingModal(page);