chore: standardize tsconfig (#9568)

packages/frontend/apps/android/package.json

@@ -3,7 +3,6 @@
   "version": "0.19.0",
   "description": "AFFiNE Desktop Web application",
   "private": true,
-  "browser": "src/index.tsx",
   "scripts": {
     "build": "affine bundle",
     "dev": "affine bundle --dev"

packages/frontend/apps/android/tsconfig.json

@@ -1,12 +1,15 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.web.json",
   "compilerOptions": {
-    "composite": true,
-    "outDir": "lib",
-    "moduleResolution": "Bundler",
-    "types": ["affine__env"],
-    "rootDir": "./src"
+    "rootDir": "./src",
+    "outDir": "./dist",
+    "tsBuildInfoFile": "./dist/tsconfig.tsbuildinfo"
   },
   "include": ["./src"],
-  "references": [{ "path": "../../core" }]
+  "references": [
+    { "path": "../../component" },
+    { "path": "../../core" },
+    { "path": "../../i18n" },
+    { "path": "../../../../blocksuite/affine/all" }
+  ]
 }

packages/frontend/apps/electron-renderer/tsconfig.json

@@ -1,17 +1,17 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.web.json",
   "compilerOptions": {
-    "composite": true,
-    "outDir": "lib",
-    "moduleResolution": "Bundler",
-    "types": ["affine__env"],
-    "rootDir": "./src"
+    "rootDir": "./src",
+    // dist is kept for webpack output
+    "outDir": "./lib",
+    "tsBuildInfoFile": "./lib/tsconfig.tsbuildinfo"
   },
   "include": ["./src"],
   "references": [
+    { "path": "../../component" },
     { "path": "../../core" },
-    {
-      "path": "../../electron-api"
-    }
+    { "path": "../../electron-api" },
+    { "path": "../../i18n" },
+    { "path": "../../../../tools/utils" }
   ]
 }

packages/frontend/apps/electron/package.json

@@ -10,6 +10,15 @@
   },
   "description": "AFFiNE Desktop App",
   "homepage": "https://github.com/toeverything/AFFiNE",
+  "exports": {
+    "./helper/exposed": "./src/helper/exposed.ts",
+    "./main/exposed": "./src/main/exposed.ts",
+    "./preload/electron-api": "./src/preload/electron-api.ts",
+    "./preload/shared-storage": "./src/preload/shared-storage.ts",
+    "./main/shared-state-schema": "./src/main/shared-state-schema.ts",
+    "./main/updater/event": "./src/main/updater/event.ts",
+    "./main/windows-manager": "./src/main/windows-manager/index.ts"
+  },
   "scripts": {
     "start": "electron .",
     "dev": "cross-env DEV_SERVER_URL=http://localhost:8080 node ./scripts/dev.ts",

packages/frontend/apps/electron/src/main/ui/handlers.ts

@@ -106,7 +106,7 @@ export const uiHandlers = {
       link =
         'https://api.fxtwitter.com/status/' + /\/status\/(.*)/.exec(link)?.[1];
       try {
-        const { tweet } = await fetch(link).then(res => res.json());
+        const { tweet } = (await fetch(link).then(res => res.json())) as any;
         return {
           title: tweet.author.name,
           icon: tweet.author.avatar_url,

packages/frontend/apps/electron/src/main/windows-manager/context-menu.ts

@@ -9,11 +9,14 @@ import {
   WebContentViewsManager,
 } from './tab-views';
 
-export const showTabContextMenu = async (tabId: string, viewIndex: number) => {
+export const showTabContextMenu = async (
+  tabId: string,
+  viewIndex: number
+): Promise<TabAction | null> => {
   const workbenches = WebContentViewsManager.instance.tabViewsMeta.workbenches;
   const tabMeta = workbenches.find(w => w.id === tabId);
   if (!tabMeta) {
-    return;
+    return null;
   }
 
   const { resolve, promise } = Promise.withResolvers<TabAction | null>();
@@ -93,7 +96,7 @@ export const showTabContextMenu = async (tabId: string, viewIndex: number) => {
   ];
   const menu = Menu.buildFromTemplate(template);
   menu.popup();
-  // eslint-disable-next-line prefer-const
+
   let unsub: (() => void) | undefined;
   const subscription = WebContentViewsManager.instance.tabAction$.subscribe(
     action => {

packages/frontend/apps/electron/src/preload/electron-api.ts

@@ -1,4 +1,6 @@
 // Please add modules to `external` in `rollupOptions` to avoid wrong bundling.
+import type { MessagePort } from 'node:worker_threads';
+
 import type { EventBasedChannel } from 'async-call-rpc';
 import { AsyncCall } from 'async-call-rpc';
 import { ipcRenderer } from 'electron';
@@ -135,12 +137,13 @@ const helperPort = new Promise<MessagePort>(resolve =>
 const createMessagePortChannel = (port: MessagePort): EventBasedChannel => {
   return {
     on(listener) {
-      port.onmessage = e => {
+      const listen = (e: MessageEvent) => {
         listener(e.data);
       };
+      port.addEventListener('message', listen as any);
       port.start();
       return () => {
-        port.onmessage = null;
+        port.removeEventListener('message', listen as any);
         try {
           port.close();
         } catch (err) {
@@ -246,10 +249,15 @@ export const events = {
   ...helperAPIs.events,
 };
 
-// Create MessagePort that can be used by web workers
+/**
+ * Create MessagePort that can be used by web workers
+ *
+ * !!!
+ * SHOULD ONLY BE USED IN RENDERER PROCESS
+ * !!!
+ */
 export function requestWebWorkerPort() {
   const ch = new MessageChannel();
-
   const localPort = ch.port1;
   const remotePort = ch.port2;
 
@@ -274,6 +282,7 @@ export function requestWebWorkerPort() {
   const portId = crypto.randomUUID();
 
   setTimeout(() => {
+    // @ts-expect-error this function should only be evaluated in the renderer process
     window.postMessage(
       {
         type: 'electron:request-api-port',

packages/frontend/apps/electron/tsconfig.json

@@ -1,45 +1,16 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.node.json",
   "compilerOptions": {
-    "composite": true,
-    "skipLibCheck": true,
-    "target": "ES2022",
-    "module": "ESNext",
-    "emitDecoratorMetadata": true,
-    "experimentalDecorators": true,
-    "types": ["node", "affine__env"],
-    "outDir": "lib",
-    "moduleResolution": "Bundler",
-    "resolveJsonModule": true,
-    "noImplicitOverride": true,
-    "paths": {
-      "@toeverything/infra/*": ["../../common/infra/src/*"]
-    }
+    "rootDir": "./src",
+    "outDir": "./dist",
+    "tsBuildInfoFile": "./dist/tsconfig.tsbuildinfo"
   },
   "include": ["./src"],
-  "exclude": ["renderer", "node_modules", "lib", "dist", "**/__tests__/**/*"],
   "references": [
-    {
-      "path": "../../../frontend/native"
-    },
-    {
-      "path": "../../../common/infra"
-    },
-    {
-      "path": "../../../common/env"
-    },
-    {
-      "path": "./tsconfig.node.json"
-    },
-    {
-      "path": "../../../../tests/kit"
-    },
-    {
-      "path": "../../../../tools/utils"
-    }
-  ],
-  "ts-node": {
-    "esm": true,
-    "experimentalSpecifierResolution": "node"
-  }
+    { "path": "../../../../tests/kit" },
+    { "path": "../../../../tools/utils" },
+    { "path": "../../native" },
+    { "path": "../../../common/nbstore" },
+    { "path": "../../../common/infra" }
+  ]
 }

packages/frontend/apps/electron/tsconfig.node.json

@@ -1,26 +1,9 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "./tsconfig.json",
   "compilerOptions": {
-    "composite": true,
-    "target": "ESNext",
-    "module": "ESNext",
-    "resolveJsonModule": true,
-    "moduleResolution": "bundler",
-    "allowSyntheticDefaultImports": true,
-    "noEmit": false,
-    "outDir": "./lib/scripts",
-    "types": ["node", "affine__env"],
-    "allowJs": true
+    "rootDir": ".",
+    "outDir": "./lib",
+    "tsBuildInfoFile": "./lib/tsconfig.tsbuildinfo"
   },
-  "include": ["./scripts"],
-  "exclude": ["./renderer"],
-  "ts-node": {
-    "esm": true,
-    "experimentalSpecifierResolution": "node"
-  },
-  "references": [
-    {
-      "path": "../../../../tools/utils"
-    }
-  ]
+  "include": ["./test", "./scripts", "./vitest.config.ts"]
 }

packages/frontend/apps/electron/tsconfig.test.json

@@ -1,21 +0,0 @@
-{
-  "extends": "../../../../tsconfig.json",
-  "compilerOptions": {
-    "composite": true,
-    "target": "ESNext",
-    "module": "ESNext",
-    "resolveJsonModule": true,
-    "moduleResolution": "Node",
-    "allowSyntheticDefaultImports": true,
-    "noEmit": false,
-    "outDir": "./lib/tests",
-    "types": ["node", "affine__env"],
-    "allowJs": true
-  },
-  "references": [
-    {
-      "path": "./tsconfig.json"
-    }
-  ],
-  "include": ["./test"]
-}

packages/frontend/apps/ios/src/fetch.ts

@@ -23,7 +23,6 @@ const readFileAsBase64 = (file: File) =>
   });
 const convertFormData = async (formData: FormData) => {
   const newFormData = [];
-  // @ts-expect-error FormData.entries
   for (const pair of formData.entries()) {
     const [key, value] = pair;
     if (value instanceof File) {
@@ -47,7 +46,7 @@ const convertBody = async (body: unknown, contentType: string) => {
     if (body instanceof ReadableStream) {
       const reader = body.getReader();
       const chunks = [];
-      // eslint-disable-next-line no-constant-condition
+
       while (true) {
         const { done, value } = await reader.read();
         if (done) break;
@@ -129,7 +128,6 @@ export function configureFetchProvider(framework: Framework) {
       console.time(tag);
       try {
         const { body } = request;
-        // @ts-expect-error Headers.entries
         const optionHeaders = Object.fromEntries(request.headers.entries());
         const {
           data: requestData,

packages/frontend/apps/ios/src/index.tsx

@@ -50,7 +50,7 @@ function main() {
 }
 
 function mountApp() {
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+  // oxlint-disable-next-line @typescript-eslint/no-non-null-assertion
   const root = document.getElementById('app')!;
   createRoot(root).render(
     <StrictMode>

packages/frontend/apps/ios/tsconfig.json

@@ -1,16 +1,17 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.web.json",
   "compilerOptions": {
-    "composite": true,
-    "outDir": "lib",
-    "moduleResolution": "Bundler",
-    "types": ["affine__env"],
-    "rootDir": "./src"
+    "rootDir": "./src",
+    "outDir": "./dist",
+    "tsBuildInfoFile": "./dist/tsconfig.tsbuildinfo"
   },
   "include": ["./src"],
   "references": [
+    { "path": "../../component" },
     { "path": "../../core" },
-    { "path": "../../native" },
-    { "path": "../../../common/nbstore" }
+    { "path": "../../i18n" },
+    { "path": "../../../../blocksuite/affine/all" },
+    { "path": "../../../common/infra" },
+    { "path": "../../native" }
   ]
 }

packages/frontend/apps/mobile/tsconfig.json

@@ -1,12 +1,15 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.web.json",
   "compilerOptions": {
-    "composite": true,
-    "outDir": "lib",
-    "moduleResolution": "Bundler",
-    "types": ["affine__env"],
-    "rootDir": "./src"
+    "rootDir": "./src",
+    "outDir": "./dist",
+    "tsBuildInfoFile": "./dist/tsconfig.tsbuildinfo"
   },
   "include": ["./src"],
-  "references": [{ "path": "../../core" }]
+  "references": [
+    { "path": "../../component" },
+    { "path": "../../core" },
+    { "path": "../../i18n" },
+    { "path": "../../../../blocksuite/affine/all" }
+  ]
 }

packages/frontend/apps/web/src/index.tsx

@@ -43,7 +43,7 @@ function main() {
 }
 
 function mountApp() {
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+  // oxlint-disable-next-line @typescript-eslint/no-non-null-assertion
   const root = document.getElementById('app')!;
   createRoot(root).render(
     <StrictMode>

packages/frontend/apps/web/tsconfig.json

@@ -1,12 +1,14 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.web.json",
   "compilerOptions": {
-    "composite": true,
-    "outDir": "lib",
-    "moduleResolution": "Bundler",
-    "types": ["affine__env"],
-    "rootDir": "./src"
+    "rootDir": "./src",
+    "outDir": "./dist",
+    "tsBuildInfoFile": "./dist/tsconfig.tsbuildinfo"
   },
   "include": ["./src"],
-  "references": [{ "path": "../../core" }]
+  "references": [
+    { "path": "../../component" },
+    { "path": "../../core" },
+    { "path": "../../i18n" }
+  ]
 }