From bf5029a073b7d86ebfcea93722e46721daa8aef8 Mon Sep 17 00:00:00 2001 From: Peng Xiao Date: Thu, 8 Jun 2023 20:06:15 +0800 Subject: [PATCH] fix: a potential crash on fav list (#2716) (cherry picked from commit 546d5764e6f14ba6268bd844c2091ddea3298827) --- .../pure/workspace-slider-bar/favorite/favorite-list.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/web/src/components/pure/workspace-slider-bar/favorite/favorite-list.tsx b/apps/web/src/components/pure/workspace-slider-bar/favorite/favorite-list.tsx index 78127ff627..c271194a07 100644 --- a/apps/web/src/components/pure/workspace-slider-bar/favorite/favorite-list.tsx +++ b/apps/web/src/components/pure/workspace-slider-bar/favorite/favorite-list.tsx @@ -34,7 +34,9 @@ function FavoriteMenuItem({ const referencesToShow = useMemo(() => { return [ ...new Set( - references.filter(ref => !parentIds.has(ref) && !metaMapping[ref].trash) + references.filter( + ref => !parentIds.has(ref) && !metaMapping[ref]?.trash + ) ), ]; }, [references, parentIds, metaMapping]);