feat: add new rule for floating promise (#2726)

Co-authored-by: Himself65 <himself65@outlook.com>

apps/web/src/components/affine/affine-error-eoundary.tsx

@@ -67,7 +67,7 @@ export class AffineErrorBoundary extends Component<
                         pageId: error.workspace.meta.pageMetas[0].id,
                       },
                     })
-                    .then(() => {
+                    .finally(() => {
                       this.setState({ error: null });
                     });
                 }}

apps/web/src/components/affine/workspace-setting-detail/index.tsx

@@ -95,7 +95,7 @@ export const WorkspaceSettingDetail: React.FC<
   const workspaceId = workspace.id;
   useEffect(() => {
     if (isAffine && isOwner) {
-      preload([QueryKey.getMembers, workspaceId], fetcher);
+      preload([QueryKey.getMembers, workspaceId], fetcher).catch(console.error);
     }
   }, [isAffine, isOwner, workspaceId]);
   const containerRef = useRef<HTMLDivElement | null>(null);

apps/web/src/components/affine/workspace-setting-detail/panel/publish/index.tsx

@@ -46,8 +46,8 @@ const PublishPanelAffine: React.FC<PublishPanelAffineProps> = ({
   const shareUrl = origin + '/public-workspace/' + workspace.id;
   const t = useAFFiNEI18N();
   const publishWorkspace = useToggleWorkspacePublish(workspace);
-  const copyUrl = useCallback(() => {
-    navigator.clipboard.writeText(shareUrl);
+  const copyUrl = useCallback(async () => {
+    await navigator.clipboard.writeText(shareUrl);
     toast(t['Copied link to clipboard']());
   }, [shareUrl, t]);
 

apps/web/src/components/blocksuite/block-suite-page-list/utils.tsx

@@ -16,12 +16,12 @@ export const usePageHelper = (blockSuiteWorkspace: BlockSuiteWorkspace) => {
 
   const createPageAndOpen = () => {
     const page = createPage();
-    openPage(blockSuiteWorkspace.id, page.id);
+    return openPage(blockSuiteWorkspace.id, page.id);
   };
   const createEdgelessAndOpen = () => {
     const page = createPage();
     setPreferredMode(page.id, 'edgeless');
-    openPage(blockSuiteWorkspace.id, page.id);
+    return openPage(blockSuiteWorkspace.id, page.id);
   };
   const importFileAndOpen = async () => {
     const { showImportModal } = await import('@blocksuite/blocks');

apps/web/src/components/blocksuite/workspace-header/header-right-items/edit-page.tsx

@@ -10,7 +10,9 @@ export const EditPage = () => {
   const { jumpToPage } = useRouterHelper(router);
   const onClickPage = useCallback(() => {
     if (workspaceId && pageId) {
-      jumpToPage(workspaceId, pageId);
+      jumpToPage(workspaceId, pageId).catch(error => {
+        console.error(error);
+      });
     }
   }, [jumpToPage, pageId, workspaceId]);
   return (

apps/web/src/components/blocksuite/workspace-header/header-right-items/language-menu.tsx

@@ -9,7 +9,7 @@ const LanguageMenuContent: FC = () => {
   const i18n = useI18N();
   const changeLanguage = useCallback(
     (event: string) => {
-      i18n.changeLanguage(event);
+      void i18n.changeLanguage(event);
     },
     [i18n]
   );

apps/web/src/components/blocksuite/workspace-header/header-right-items/share-menu.tsx

@@ -96,8 +96,8 @@ const LocalHeaderShareMenu: React.FC<BaseHeaderProps> = props => {
         onClose={() => {
           setOpen(false);
         }}
-        onConform={() => {
-          onTransformWorkspace(
+        onConform={async () => {
+          await onTransformWorkspace(
             WorkspaceFlavour.LOCAL,
             WorkspaceFlavour.AFFINE,
             props.workspace as LocalWorkspace

apps/web/src/components/blocksuite/workspace-header/header-right-items/sync-user.tsx

@@ -138,17 +138,14 @@ export const SyncUser = () => {
               workspace as LocalWorkspace
             );
             // fixme(himself65): refactor this
-            router
-              .replace({
-                pathname: `/workspace/[workspaceId]/all`,
-                query: {
-                  workspaceId: id,
-                },
-              })
-              .then(() => {
-                router.reload();
-              });
+            await router.replace({
+              pathname: `/workspace/[workspaceId]/all`,
+              query: {
+                workspaceId: id,
+              },
+            });
             setOpen(false);
+            router.reload();
           }}
         />
       </>

apps/web/src/components/blocksuite/workspace-header/header-right-items/trash-button-group.tsx

@@ -63,9 +63,10 @@ export const TrashButtonGroup = () => {
                 workspaceId: workspace.id,
               },
             })
-            .then(() => {
-              blockSuiteWorkspace.removePage(pageId);
+            .catch(error => {
+              console.error(error);
             });
+          blockSuiteWorkspace.removePage(pageId);
         }}
         onCancel={() => {
           setOpen(false);

apps/web/src/components/pure/message-center/index.tsx

@@ -43,7 +43,7 @@ export const MessageCenter: FC = memo(function MessageCenter() {
           })
           .catch(() => {
             setPopup(false);
-            onLogout();
+            return onLogout();
           });
       } else {
         toast(Messages[event.detail.code].message);

apps/web/src/components/pure/quick-search-modal/published-results.tsx

@@ -64,9 +64,11 @@ export const PublishedResults: FC<PublishedResultsProps> = ({
                 <Command.Item
                   key={result.id}
                   onSelect={() => {
-                    router.push(
-                      `/public-workspace/${router.query.workspaceId}/${result.id}`
-                    );
+                    router
+                      .push(
+                        `/public-workspace/${router.query.workspaceId}/${result.id}`
+                      )
+                      .catch(err => console.error(err));
                     onClose();
                   }}
                   value={result.id}

apps/web/src/components/pure/quick-search-modal/results.tsx

@@ -71,7 +71,9 @@ export const Results: FC<ResultsProps> = ({
                   value={page.id}
                   onSelect={() => {
                     onClose();
-                    jumpToPage(blockSuiteWorkspace.id, page.id);
+                    jumpToPage(blockSuiteWorkspace.id, page.id).catch(
+                      console.error
+                    );
                   }}
                 >
                   <StyledListItem>
@@ -95,7 +97,7 @@ export const Results: FC<ResultsProps> = ({
                 value={link.title}
                 onSelect={() => {
                   onClose();
-                  router.push(link.href);
+                  router.push(link.href).catch(console.error);
                 }}
               >
                 <StyledListItem>
@@ -133,7 +135,9 @@ export const Results: FC<ResultsProps> = ({
             onSelect={() => {
               onClose();
               assertExists(blockSuiteWorkspace.id);
-              jumpToPage(blockSuiteWorkspace.id, result.id);
+              jumpToPage(blockSuiteWorkspace.id, result.id).catch(error =>
+                console.error(error)
+              );
             }}
             value={result.id}
           >