refactor(editor): remove assertExists (#10615)

packages/frontend/core/src/blocksuite/ai/actions/doc-handler.ts

@@ -3,7 +3,6 @@ import {
   AIStarIconWithAnimation,
   createLitPortal,
 } from '@blocksuite/affine/blocks';
-import { assertExists } from '@blocksuite/affine/global/utils';
 import { flip, offset } from '@floating-ui/dom';
 import { html, type TemplateResult } from 'lit';
 
@@ -169,7 +168,7 @@ function updateAIPanelConfig<T extends keyof BlockSuitePresets.AIActions>(
   trackerOptions?: BlockSuitePresets.TrackerOptions
 ) {
   const { config, host } = aiPanel;
-  assertExists(config);
+  if (!config) return;
   config.generateAnswer = actionToGenerateAnswer(
     host,
     id,
@@ -203,7 +202,7 @@ export function actionToHandler<T extends keyof BlockSuitePresets.AIActions>(
     const { selectedBlocks: blocks } = getSelections(aiPanel.host);
     if (!blocks || blocks.length === 0) return;
     const block = blocks.at(-1);
-    assertExists(block);
+    if (!block) return;
     aiPanel.toggle(block, '');
   };
 }

packages/frontend/core/src/blocksuite/ai/actions/edgeless-handler.ts

@@ -14,7 +14,6 @@ import {
   splitElements,
   TextElementModel,
 } from '@blocksuite/affine/blocks';
-import { assertExists } from '@blocksuite/affine/global/utils';
 import { Slice } from '@blocksuite/affine/store';
 import type { TemplateResult } from 'lit';
 
@@ -319,7 +318,7 @@ function updateEdgelessAIPanelConfig<
 ) {
   const host = aiPanel.host;
   const { config } = aiPanel;
-  assertExists(config);
+  if (!config) return;
   config.answerRenderer = actionToAnswerRenderer(id, host, ctx);
   config.generateAnswer = actionToGeneration(
     id,
@@ -414,7 +413,7 @@ export function actionToHandler<T extends keyof BlockSuitePresets.AIActions>(
       referenceElement = getElementToolbar(host);
     } else if (!isEmpty) {
       const lastSelected = selectedElements.at(-1)?.id;
-      assertExists(lastSelected);
+      if (!lastSelected) return;
       const noteAnchor = getSelectedNoteAnchor(host, lastSelected);
       referenceElement = noteAnchor;
     }

packages/frontend/core/src/blocksuite/ai/actions/edgeless-response.ts

@@ -23,7 +23,6 @@ import {
   TelemetryProvider,
 } from '@blocksuite/affine/blocks';
 import { Bound } from '@blocksuite/affine/global/gfx';
-import { assertExists } from '@blocksuite/affine/global/utils';
 import { html, type TemplateResult } from 'lit';
 import { styleMap } from 'lit/directives/style-map.js';
 
@@ -238,7 +237,7 @@ function createBlockAndInsert(
   const doc = host.doc;
   const edgelessCopilot = getEdgelessCopilotWidget(host);
   doc.transact(() => {
-    assertExists(doc.root);
+    if (!doc.root) return;
     let blockId = '';
     const bounds = edgelessCopilot.determineInsertionBounds(
       EDGELESS_TEXT_BLOCK_MIN_WIDTH,
@@ -280,8 +279,7 @@ function createBlockAndInsert(
 const defaultHandler = (host: EditorHost) => {
   const panel = getAIPanelWidget(host);
   const selectedElements = getCopilotSelectedElems(host);
-
-  assertExists(panel.answer);
+  if (!panel.answer) return;
   if (
     selectedElements.length === 1 &&
     selectedElements[0] instanceof EdgelessTextBlockModel

packages/frontend/core/src/blocksuite/ai/ai-panel.ts

@@ -9,7 +9,6 @@ import {
   NoteDisplayMode,
 } from '@blocksuite/affine/blocks';
 import { Bound } from '@blocksuite/affine/global/gfx';
-import { assertExists } from '@blocksuite/affine/global/utils';
 import type { FrameworkProvider } from '@toeverything/infra';
 import type { TemplateResult } from 'lit';
 
@@ -98,7 +97,7 @@ function createNewNote(host: EditorHost): AIItemConfig {
       const panel = getAIPanelWidget(host);
       const gfx = host.std.get(GfxControllerIdentifier);
       doc.transact(() => {
-        assertExists(doc.root);
+        if (!doc.root || !panel.answer) return;
         const noteBlockId = doc.addBlock(
           'affine:note',
           {
@@ -109,7 +108,6 @@ function createNewNote(host: EditorHost): AIItemConfig {
           doc.root.id
         );
 
-        assertExists(panel.answer);
         insertFromMarkdown(host, panel.answer, doc, noteBlockId)
           .then(() => {
             gfx.selection.set({

packages/frontend/core/src/blocksuite/ai/entries/slash-menu/setup-slash-menu.ts

@@ -7,14 +7,12 @@ import {
   AIStarIcon,
   DocModeProvider,
 } from '@blocksuite/affine/blocks';
-import { assertExists } from '@blocksuite/affine/global/utils';
 import { MoreHorizontalIcon } from '@blocksuite/icons/lit';
 import { html } from 'lit';
 
 import { pageAIGroups } from '../../_common/config';
 import { handleInlineAskAIAction } from '../../actions/doc-handler';
 import type { AIItemConfig } from '../../components/ai-item/types';
-import { AIProvider } from '../../provider';
 import {
   AFFINE_AI_PANEL_WIDGET,
   type AffineAIPanelWidget,
@@ -55,10 +53,9 @@ export function setupSlashMenuAIEntry(slashMenu: AffineSlashMenuWidget) {
   });
 
   const subMenuWrapper = (item: AIItemConfig): AffineSlashSubMenu => {
-    assertExists(item.subItem);
     return {
       ...basicItemConfig(item),
-      subMenu: item.subItem.map<AffineSlashMenuActionItem>(
+      subMenu: (item.subItem ?? []).map<AffineSlashMenuActionItem>(
         ({ type, handler }) => ({
           name: type,
           action: ({ rootComponent }) => handler?.(rootComponent.host),
@@ -87,9 +84,6 @@ export function setupSlashMenuAIEntry(slashMenu: AffineSlashMenuWidget) {
         AFFINE_AI_PANEL_WIDGET,
         rootComponent.model.id
       ) as AffineAIPanelWidget;
-      assertExists(affineAIPanelWidget);
-      assertExists(AIProvider.actions.chat);
-      assertExists(affineAIPanelWidget.host);
       handleInlineAskAIAction(affineAIPanelWidget.host);
     },
   });

packages/frontend/core/src/blocksuite/ai/provider/request.ts

@@ -1,4 +1,3 @@
-import { assertExists } from '@blocksuite/affine/global/utils';
 import { partition } from 'lodash-es';
 
 import { AIProvider } from './ai-provider';
@@ -146,7 +145,6 @@ export function textToText({
         if (retry) {
           const retrySessionId =
             (await sessionId) ?? AIProvider.LAST_ACTION_SESSIONID;
-          assertExists(retrySessionId, 'retry sessionId is required');
           _sessionId = retrySessionId;
           _messageId = undefined;
         } else {
@@ -220,7 +218,6 @@ export function textToText({
         if (retry) {
           const retrySessionId =
             (await sessionId) ?? AIProvider.LAST_ACTION_SESSIONID;
-          assertExists(retrySessionId, 'retry sessionId is required');
           _sessionId = retrySessionId;
           _messageId = undefined;
         } else {
@@ -275,7 +272,6 @@ export function toImage({
       if (retry) {
         const retrySessionId =
           (await sessionId) ?? AIProvider.LAST_ACTION_SESSIONID;
-        assertExists(retrySessionId, 'retry sessionId is required');
         _sessionId = retrySessionId;
         _messageId = undefined;
       } else {

packages/frontend/core/src/blocksuite/ai/provider/setup-provider.tsx

@@ -5,7 +5,6 @@ import {
   type getCopilotHistoriesQuery,
   type RequestOptions,
 } from '@affine/graphql';
-import { assertExists } from '@blocksuite/affine/global/utils';
 import { z } from 'zod';
 
 import { AIProvider } from './ai-provider';
@@ -234,7 +233,9 @@ export function setupAIProvider(
   });
 
   AIProvider.provide('expandMindmap', options => {
-    assertExists(options.input, 'expandMindmap action requires input');
+    if (!options.input) {
+      throw new Error('expandMindmap action requires input');
+    }
     return textToText({
       ...options,
       client,

packages/frontend/core/src/blocksuite/ai/utils/ai-widgets.ts

@@ -1,5 +1,4 @@
 import type { EditorHost } from '@blocksuite/affine/block-std';
-import { assertExists } from '@blocksuite/affine/global/utils';
 
 import {
   AFFINE_AI_PANEL_WIDGET,
@@ -8,9 +7,10 @@ import {
 
 export const getAIPanelWidget = (host: EditorHost): AffineAIPanelWidget => {
   const rootBlockId = host.doc.root?.id;
-  assertExists(rootBlockId);
+  if (!rootBlockId) {
+    throw new Error('rootBlockId is not found');
+  }
   const aiPanel = host.view.getWidget(AFFINE_AI_PANEL_WIDGET, rootBlockId);
-  assertExists(aiPanel);
   if (!(aiPanel instanceof AffineAIPanelWidget)) {
     throw new Error('AI panel not found');
   }

packages/frontend/core/src/blocksuite/ai/utils/connector.ts

@@ -3,7 +3,6 @@ import {
   type EdgelessRootService,
   SurfaceBlockComponent,
 } from '@blocksuite/affine/blocks';
-import { assertExists } from '@blocksuite/affine/global/utils';
 
 export const getConnectorFromId = (
   id: string,
@@ -68,7 +67,9 @@ export const findTree = (
     };
   };
   const tree = run(rootId);
-  assertExists(tree);
+  if (!tree) {
+    throw new Error('tree is not found');
+  }
   return tree;
 };
 export const findLeaf = (

packages/frontend/core/src/blocksuite/ai/utils/image.ts

@@ -1,5 +1,4 @@
 import { FetchUtils } from '@blocksuite/affine/blocks';
-import { assertExists } from '@blocksuite/affine/global/utils';
 
 export async function fetchImageToFile(
   url: string,
@@ -26,14 +25,17 @@ function fetchImageFallback(
   url: string,
   filename: string
 ): Promise<File | void> {
-  return new Promise(resolve => {
+  return new Promise((resolve, reject) => {
     const img = new Image();
     img.onload = () => {
       const c = document.createElement('canvas');
       c.width = img.width;
       c.height = img.height;
       const ctx = c.getContext('2d');
-      assertExists(ctx);
+      if (!ctx) {
+        reject();
+        return;
+      }
       ctx.imageSmoothingEnabled = true;
       ctx.imageSmoothingQuality = 'high';
       ctx.drawImage(img, 0, 0);
@@ -51,7 +53,7 @@ function fetchImageFallback(
 }
 
 function convertToPng(blob: Blob): Promise<Blob | null> {
-  return new Promise(resolve => {
+  return new Promise((resolve, reject) => {
     const reader = new FileReader();
     reader.addEventListener('load', _ => {
       const img = new Image();
@@ -60,7 +62,10 @@ function convertToPng(blob: Blob): Promise<Blob | null> {
         c.width = img.width;
         c.height = img.height;
         const ctx = c.getContext('2d');
-        assertExists(ctx);
+        if (!ctx) {
+          reject();
+          return;
+        }
         ctx.imageSmoothingEnabled = true;
         ctx.imageSmoothingQuality = 'high';
         ctx.drawImage(img, 0, 0);

packages/frontend/core/src/blocksuite/ai/utils/template-job.ts

@@ -6,11 +6,12 @@ import {
   TemplateMiddlewares,
 } from '@blocksuite/affine/blocks';
 import { Bound, getCommonBound } from '@blocksuite/affine/global/gfx';
-import { assertExists } from '@blocksuite/affine/global/utils';
 
 export function createTemplateJob(host: EditorHost) {
   const surface = getSurfaceBlock(host.doc);
-  assertExists(surface);
+  if (!surface) {
+    throw new Error('surface is not found');
+  }
 
   const middlewares: ((job: TemplateJob) => void)[] = [];
   const layer = new LayerManager(host.doc, surface, {

packages/frontend/core/src/blocksuite/ai/widgets/ai-panel/ai-panel.ts

@@ -13,7 +13,6 @@ import {
   stopPropagation,
   ThemeProvider,
 } from '@blocksuite/affine/blocks';
-import { assertExists } from '@blocksuite/affine/global/utils';
 import type { BaseSelection } from '@blocksuite/affine/store';
 import {
   autoPlacement,
@@ -176,10 +175,16 @@ export class AffineAIPanelWidget extends WidgetComponent {
   generate = () => {
     this.restoreSelection();
 
-    assertExists(this.config);
     const text = this._inputText;
-    assertExists(text);
-    assertExists(this.config.generateAnswer);
+    if (!this.config) {
+      throw new Error('config is not found');
+    }
+    if (text === null || text === undefined) {
+      throw new Error('text is not found');
+    }
+    if (!this.config.generateAnswer) {
+      throw new Error('generateAnswer is not found');
+    }
 
     this._resetAbortController();
 
@@ -193,7 +198,9 @@ export class AffineAIPanelWidget extends WidgetComponent {
     const finish = (type: 'success' | 'error' | 'aborted', err?: AIError) => {
       if (type === 'aborted') return;
 
-      assertExists(this.config);
+      if (!this.config) {
+        throw new Error('config is not found when finish');
+      }
       if (type === 'error') {
         this.state = 'error';
         this.config.errorStateConfig.error = err;