refactor(editor): remove assertExists (#10615)

blocksuite/affine/components/src/portal/helper.ts

@@ -1,4 +1,5 @@
-import { assertExists, Slot } from '@blocksuite/global/utils';
+import { BlockSuiteError } from '@blocksuite/global/exceptions';
+import { Slot } from '@blocksuite/global/utils';
 import {
   autoUpdate,
   computePosition,
@@ -39,7 +40,12 @@ export function createSimplePortal({
   });
 
   const root = shadowDom ? portalRoot.shadowRoot : portalRoot;
-  assertExists(root);
+  if (!root) {
+    throw new BlockSuiteError(
+      BlockSuiteError.ErrorCode.ValueNotExists,
+      'Failed to create portal root'
+    );
+  }
 
   let updateId = 0;
   const updatePortal: (id: number) => void = id => {
@@ -55,7 +61,6 @@ export function createSimplePortal({
       template instanceof Function
         ? template({ updatePortal: () => updatePortal(curId) })
         : template;
-    assertExists(templateResult);
     render(templateResult, root, renderOptions);
   };
 
@@ -173,7 +178,6 @@ export function createLitPortal({
       ? positionConfigOrFn(portalRoot)
       : positionConfigOrFn;
   const { referenceElement, ...options } = computePositionOptions;
-  assertExists(referenceElement, 'referenceElement is required');
   const update = () => {
     if (
       computePositionOptions.abortWhenRefRemoved !== false &&

blocksuite/affine/components/src/rich-text/format/format-block.ts

@@ -1,7 +1,6 @@
 import { getSelectedBlocksCommand } from '@blocksuite/affine-shared/commands';
 import type { AffineTextAttributes } from '@blocksuite/affine-shared/types';
 import type { BlockSelection, Command } from '@blocksuite/block-std';
-import { assertExists } from '@blocksuite/global/utils';
 import { INLINE_ROOT_ATTR, type InlineRootElement } from '@blocksuite/inline';
 
 import { FORMAT_BLOCK_SUPPORT_FLAVOURS } from './consts.js';
@@ -14,10 +13,12 @@ export const formatBlockCommand: Command<{
   mode?: 'replace' | 'merge';
 }> = (ctx, next) => {
   const blockSelections = ctx.blockSelections ?? ctx.currentBlockSelections;
-  assertExists(
-    blockSelections,
-    '`blockSelections` is required, you need to pass it in args or use `getBlockSelections` command before adding this command to the pipeline.'
-  );
+  if (!blockSelections) {
+    console.error(
+      '`blockSelections` is required, you need to pass it in args or use `getBlockSelections` command before adding this command to the pipeline.'
+    );
+    return;
+  }
 
   if (blockSelections.length === 0) return;
 
@@ -33,7 +34,12 @@ export const formatBlockCommand: Command<{
     })
     .pipe((ctx, next) => {
       const { selectedBlocks } = ctx;
-      assertExists(selectedBlocks);
+      if (!selectedBlocks) {
+        console.error(
+          '`selectedBlocks` is required, you need to pass it in args or use `getSelectedBlocksCommand` command before adding this command to the pipeline.'
+        );
+        return;
+      }
 
       const selectedInlineEditors = selectedBlocks.flatMap(el => {
         const inlineRoot = el.querySelector<

blocksuite/affine/components/src/rich-text/format/utils.ts

@@ -11,7 +11,6 @@ import {
   type EditorHost,
   type InitCommandCtx,
 } from '@blocksuite/block-std';
-import { assertExists } from '@blocksuite/global/utils';
 import {
   INLINE_ROOT_ATTR,
   type InlineEditor,
@@ -92,7 +91,12 @@ function handleCurrentSelection(
       })
       .pipe((ctx, next) => {
         const { selectedBlocks } = ctx;
-        assertExists(selectedBlocks);
+        if (!selectedBlocks) {
+          console.error(
+            '`selectedBlocks` is required, you need to pass it in args or use `getSelectedBlocksCommand` command before adding this command to the pipeline.'
+          );
+          return false;
+        }
 
         const selectedInlineEditors = getSelectedInlineEditors(
           selectedBlocks,
@@ -119,7 +123,12 @@ function handleCurrentSelection(
       })
       .pipe((ctx, next) => {
         const { selectedBlocks } = ctx;
-        assertExists(selectedBlocks);
+        if (!selectedBlocks) {
+          console.error(
+            '`selectedBlocks` is required, you need to pass it in args or use `getSelectedBlocksCommand` command before adding this command to the pipeline.'
+          );
+          return false;
+        }
 
         const selectedInlineEditors = getSelectedInlineEditors(
           selectedBlocks,

blocksuite/affine/components/src/rich-text/inline/presets/nodes/reference-node/reference-alias-popup.ts

@@ -8,11 +8,7 @@ import {
 import { FONT_XS, PANEL_BASE } from '@blocksuite/affine-shared/styles';
 import type { AffineTextAttributes } from '@blocksuite/affine-shared/types';
 import { type BlockStdScope, ShadowlessElement } from '@blocksuite/block-std';
-import {
-  assertExists,
-  SignalWatcher,
-  WithDisposable,
-} from '@blocksuite/global/utils';
+import { SignalWatcher, WithDisposable } from '@blocksuite/global/utils';
 import { DoneIcon, ResetIcon } from '@blocksuite/icons/lit';
 import type { DeltaInsert, InlineRange } from '@blocksuite/inline';
 import { computePosition, inline, offset, shift } from '@floating-ui/dom';
@@ -211,7 +207,9 @@ export class ReferenceAliasPopup extends SignalWatcher(
 
   override updated() {
     const range = this.inlineEditor.toDomRange(this.inlineRange);
-    assertExists(range);
+    if (!range) {
+      return;
+    }
 
     const visualElement = {
       getBoundingClientRect: () => range.getBoundingClientRect(),

blocksuite/affine/components/src/rich-text/inline/presets/nodes/reference-node/reference-popup.ts

@@ -16,7 +16,7 @@ import {
   type BlockComponent,
   type BlockStdScope,
 } from '@blocksuite/block-std';
-import { assertExists, WithDisposable } from '@blocksuite/global/utils';
+import { WithDisposable } from '@blocksuite/global/utils';
 import { ArrowDownSmallIcon, MoreVerticalIcon } from '@blocksuite/icons/lit';
 import type { InlineRange } from '@blocksuite/inline';
 import { computePosition, inline, offset, shift } from '@floating-ui/dom';
@@ -51,6 +51,10 @@ export class ReferencePopup extends WithDisposable(LitElement) {
   static override styles = styles;
 
   private readonly _copyLink = () => {
+    if (!this.std) {
+      console.error('`std` is not found');
+      return;
+    }
     const url = this.std
       .getOptional(GenerateDocUrlProvider)
       ?.generateDocUrl(this.referenceInfo.pageId, this.referenceInfo.params);
@@ -66,6 +70,10 @@ export class ReferencePopup extends WithDisposable(LitElement) {
   };
 
   private readonly _openDoc = (event?: Partial<DocLinkClickedEvent>) => {
+    if (!this.std) {
+      console.error('`std` is not found');
+      return;
+    }
     this.std.getOptional(RefNodeSlotsProvider)?.docLinkClicked.emit({
       ...this.referenceInfo,
       ...event,
@@ -89,6 +97,11 @@ export class ReferencePopup extends WithDisposable(LitElement) {
       abortController,
     } = this;
 
+    if (!std) {
+      console.error('`std` is not found');
+      return;
+    }
+
     const aliasPopup = new ReferenceAliasPopup();
 
     aliasPopup.std = std;
@@ -105,6 +118,10 @@ export class ReferencePopup extends WithDisposable(LitElement) {
   };
 
   private readonly _toggleViewSelector = (e: Event) => {
+    if (!this.std) {
+      console.error('`std` is not found');
+      return;
+    }
     const opened = (e as CustomEvent<boolean>).detail;
     if (!opened) return;
 
@@ -112,6 +129,10 @@ export class ReferencePopup extends WithDisposable(LitElement) {
   };
 
   private readonly _trackViewSelected = (type: string) => {
+    if (!this.std) {
+      console.error('`std` is not found');
+      return;
+    }
     track(this.std, 'SelectedView', {
       control: 'select view',
       type: `${type} view`,
@@ -119,6 +140,11 @@ export class ReferencePopup extends WithDisposable(LitElement) {
   };
 
   get _embedViewButtonDisabled() {
+    if (!this.block) {
+      console.error('`block` is not found');
+      return true;
+    }
+
     if (
       this.block.doc.readonly ||
       isInsideBlockByFlavour(
@@ -131,13 +157,13 @@ export class ReferencePopup extends WithDisposable(LitElement) {
     }
     return (
       !!this.block.closest('affine-embed-synced-doc-block') ||
-      this.referenceDocId === this.doc.id
+      this.referenceDocId === this.block.doc.id
     );
   }
 
   _openButtonDisabled(openMode?: OpenDocMode) {
     if (openMode === 'open-in-active-view') {
-      return this.referenceDocId === this.doc.id;
+      return this.referenceDocId === this.doc?.id;
     }
     return false;
   }
@@ -146,34 +172,32 @@ export class ReferencePopup extends WithDisposable(LitElement) {
     const block = this.inlineEditor.rootElement?.closest<BlockComponent>(
       `[${BLOCK_ID_ATTR}]`
     );
-    assertExists(block);
     return block;
   }
 
   get doc() {
-    const doc = this.block.doc;
-    assertExists(doc);
+    const doc = this.block?.doc;
     return doc;
   }
 
   get referenceDocId() {
     const docId = this.inlineEditor.getFormat(this.targetInlineRange).reference
       ?.pageId;
-    assertExists(docId);
     return docId;
   }
 
   get std() {
-    const std = this.block.std;
-    assertExists(std);
+    const std = this.block?.std;
     return std;
   }
 
   private _convertToCardView() {
     const block = this.block;
+    if (!block) return;
+
     const doc = block.host.doc;
     const parent = doc.getParent(block.model);
-    assertExists(parent);
+    if (!parent) return;
 
     const index = parent.children.indexOf(block.model);
 
@@ -197,10 +221,17 @@ export class ReferencePopup extends WithDisposable(LitElement) {
 
   private _convertToEmbedView() {
     const block = this.block;
-    const std = block.std;
+    const std = block?.std;
+    if (!std || !block) {
+      console.error('`std` or `block` is not found');
+      return;
+    }
     const doc = block.host.doc;
     const parent = doc.getParent(block.model);
-    assertExists(parent);
+    if (!parent) {
+      console.error('`parent` is not found');
+      return;
+    }
 
     const index = parent.children.indexOf(block.model);
     const referenceInfo = this.referenceInfo;
@@ -242,7 +273,7 @@ export class ReferencePopup extends WithDisposable(LitElement) {
           type: 'delete',
           label: 'Delete',
           icon: DeleteIcon,
-          disabled: this.doc.readonly,
+          disabled: this.doc?.readonly,
           action: () => this._delete(),
         },
       ],
@@ -250,6 +281,10 @@ export class ReferencePopup extends WithDisposable(LitElement) {
   }
 
   private _openMenuButton() {
+    if (!this.std) {
+      console.error('`std` is not found');
+      return nothing;
+    }
     const openDocConfig = this.std.get(OpenDocExtensionIdentifier);
 
     const buttons: MenuItem[] = openDocConfig.items
@@ -330,7 +365,7 @@ export class ReferencePopup extends WithDisposable(LitElement) {
       type: 'card',
       label: 'Card view',
       action: () => this._convertToCardView(),
-      disabled: this.doc.readonly,
+      disabled: this.doc?.readonly,
     });
 
     buttons.push({
@@ -338,7 +373,9 @@ export class ReferencePopup extends WithDisposable(LitElement) {
       label: 'Embed view',
       action: () => this._convertToEmbedView(),
       disabled:
-        this.doc.readonly || this.isLinkedNode || this._embedViewButtonDisabled,
+        this.doc?.readonly ||
+        this.isLinkedNode ||
+        this._embedViewButtonDisabled,
     });
 
     return html`
@@ -388,11 +425,14 @@ export class ReferencePopup extends WithDisposable(LitElement) {
       return;
     }
 
+    if (!this.block) return;
+
     const parent = this.block.host.doc.getParent(this.block.model);
-    assertExists(parent);
+    if (!parent) return;
 
     this.disposables.add(
       effect(() => {
+        if (!this.block) return;
         const children = parent.children;
         if (children.includes(this.block.model)) return;
         this.abortController.abort();
@@ -435,7 +475,7 @@ export class ReferencePopup extends WithDisposable(LitElement) {
           aria-label="Edit"
           data-testid="edit"
           .tooltip=${'Edit'}
-          ?disabled=${this.doc.readonly}
+          ?disabled=${this.doc?.readonly}
           @click=${this._openEditPopup}
         >
           ${EditIcon}
@@ -479,10 +519,8 @@ export class ReferencePopup extends WithDisposable(LitElement) {
   }
 
   override updated() {
-    assertExists(this.popupContainer);
     const range = this.inlineEditor.toDomRange(this.targetInlineRange);
-    assertExists(range);
-
+    if (!range) return;
     const visualElement = {
       getBoundingClientRect: () => range.getBoundingClientRect(),
       getClientRects: () => range.getClientRects(),

blocksuite/affine/components/src/rich-text/rich-text.ts

@@ -1,6 +1,6 @@
 import type { AffineTextAttributes } from '@blocksuite/affine-shared/types';
 import { ShadowlessElement } from '@blocksuite/block-std';
-import { assertExists, WithDisposable } from '@blocksuite/global/utils';
+import { WithDisposable } from '@blocksuite/global/utils';
 import {
   type AttributeRenderer,
   type DeltaInsert,
@@ -148,7 +148,6 @@ export class RichText extends WithDisposable(ShadowlessElement) {
   }
 
   get inlineEditorContainer() {
-    assertExists(this._inlineEditorContainer);
     return this._inlineEditorContainer;
   }
 

blocksuite/affine/components/src/toolbar/tooltip.ts

@@ -1,5 +1,4 @@
 import { requestConnectedFrame } from '@blocksuite/affine-shared/utils';
-import { assertExists } from '@blocksuite/global/utils';
 import {
   arrow,
   type ComputePositionReturn,
@@ -193,7 +192,10 @@ export class Tooltip extends LitElement {
     );
 
     const parent = this.parentElement;
-    assertExists(parent, 'Tooltip must have a parent element');
+    if (!parent) {
+      console.error('Tooltip must have a parent element');
+      return;
+    }
 
     // Wait for render
     requestConnectedFrame(() => {