From b4212d54ed654e07e0b522b5047b6f59c70fcd78 Mon Sep 17 00:00:00 2001 From: EYHN Date: Thu, 20 Jun 2024 04:24:47 +0000 Subject: [PATCH] chore(core): delete center peek feature flag (#7281) --- packages/common/env/src/global.ts | 1 - .../blocksuite/block-suite-editor/lit-adaper.tsx | 2 +- .../core/src/modules/peek-view/entities/peek-view.ts | 3 --- packages/frontend/core/src/providers/modal-provider.tsx | 2 +- tools/cli/src/webpack/runtime-config.ts | 7 ------- 5 files changed, 2 insertions(+), 13 deletions(-) diff --git a/packages/common/env/src/global.ts b/packages/common/env/src/global.ts index 9c99fe5e5e..279ec822e2 100644 --- a/packages/common/env/src/global.ts +++ b/packages/common/env/src/global.ts @@ -24,7 +24,6 @@ export const runtimeFlagsSchema = z.object({ enablePayment: z.boolean(), enablePageHistory: z.boolean(), enableExperimentalFeature: z.boolean(), - enablePeekView: z.boolean(), allowLocalWorkspace: z.boolean(), // this is for the electron app serverUrlPrefix: z.string(), diff --git a/packages/frontend/core/src/components/blocksuite/block-suite-editor/lit-adaper.tsx b/packages/frontend/core/src/components/blocksuite/block-suite-editor/lit-adaper.tsx index cfe718e54b..8f28f9bd65 100644 --- a/packages/frontend/core/src/components/blocksuite/block-suite-editor/lit-adaper.tsx +++ b/packages/frontend/core/src/components/blocksuite/block-suite-editor/lit-adaper.tsx @@ -101,7 +101,7 @@ const usePatchSpecs = (page: Doc, shared: boolean, mode: DocMode) => { patchReferenceRenderer(patched, reactToLit, referenceRenderer), confirmModal ); - if (!page.readonly && runtimeConfig.enablePeekView) { + if (!page.readonly) { patched = patchPeekViewService(patched, peekViewService); } if (!page.readonly) { diff --git a/packages/frontend/core/src/modules/peek-view/entities/peek-view.ts b/packages/frontend/core/src/modules/peek-view/entities/peek-view.ts index 6e4a46db1a..e7c23a1bc6 100644 --- a/packages/frontend/core/src/modules/peek-view/entities/peek-view.ts +++ b/packages/frontend/core/src/modules/peek-view/entities/peek-view.ts @@ -109,9 +109,6 @@ export class PeekViewEntity extends Entity { // return true if the peek view will be handled open = (target: ActivePeekView['target']) => { - if (!runtimeConfig.enablePeekView) { - return false; - } const resolvedInfo = resolvePeekInfoFromPeekTarget(target); if (!resolvedInfo) { return false; diff --git a/packages/frontend/core/src/providers/modal-provider.tsx b/packages/frontend/core/src/providers/modal-provider.tsx index 1a77b73088..c9e22fb346 100644 --- a/packages/frontend/core/src/providers/modal-provider.tsx +++ b/packages/frontend/core/src/providers/modal-provider.tsx @@ -231,7 +231,7 @@ export function CurrentWorkspaceModals() { )} - {runtimeConfig.enablePeekView && } + {environment.isDesktop && }