From ada69c80f64ab4ac4bb55f3f4ab6a8be47288f91 Mon Sep 17 00:00:00 2001 From: darkskygit Date: Fri, 30 May 2025 08:04:18 +0000 Subject: [PATCH] feat(server): only trigger embedding in workspace sync (#12634) ## Summary by CodeRabbit - **Bug Fixes** - Improved handling of workspace embedding events to ensure they are only triggered for workspace-type spaces. - **Chores** - Added additional debug logging for document embedding jobs to aid in monitoring and troubleshooting. --- packages/backend/server/src/core/sync/gateway.ts | 4 +++- packages/backend/server/src/plugins/copilot/context/job.ts | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/backend/server/src/core/sync/gateway.ts b/packages/backend/server/src/core/sync/gateway.ts index 4687cde2f0..99b4637cd9 100644 --- a/packages/backend/server/src/core/sync/gateway.ts +++ b/packages/backend/server/src/core/sync/gateway.ts @@ -203,7 +203,9 @@ export class SpaceSyncGateway await client.join(room); } } else { - this.event.emit('workspace.embedding', { workspaceId: spaceId }); + if (spaceType === SpaceType.Workspace) { + this.event.emit('workspace.embedding', { workspaceId: spaceId }); + } await this.selectAdapter(client, spaceType).join(user.id, spaceId); } diff --git a/packages/backend/server/src/plugins/copilot/context/job.ts b/packages/backend/server/src/plugins/copilot/context/job.ts index 4e0d4ba4a4..290ade53f1 100644 --- a/packages/backend/server/src/plugins/copilot/context/job.ts +++ b/packages/backend/server/src/plugins/copilot/context/job.ts @@ -129,6 +129,10 @@ export class CopilotContextDocJob { if (enableDocEmbedding) { const toBeEmbedDocIds = await this.models.copilotWorkspace.findDocsToEmbed(workspaceId); + this.logger.debug('Trigger embedding for docs', { + workspaceId, + toBeEmbedDocs: toBeEmbedDocIds.length, + }); for (const docId of toBeEmbedDocIds) { await this.queue.add( 'copilot.embedding.docs',