refactor(core): refactor atom to use di (#5831)

To support multiple instances, this PR removes some atoms and implements them using the new DI system.

removed atom

- `pageSettingsAtom`
- `currentPageIdAtom`
- `currentModeAtom`

packages/frontend/core/src/atoms/__tests__/atom.spec.ts

@@ -1,37 +0,0 @@
-/**
- * @vitest-environment happy-dom
- */
-import 'fake-indexeddb/auto';
-
-import { createStore } from 'jotai';
-import { describe, expect, test } from 'vitest';
-
-import {
-  pageSettingFamily,
-  pageSettingsAtom,
-  recentPageIdsBaseAtom,
-} from '../index';
-
-describe('page mode atom', () => {
-  test('basic', () => {
-    const store = createStore();
-    const page0SettingAtom = pageSettingFamily('page0');
-    store.set(page0SettingAtom, {
-      mode: 'page',
-    });
-
-    expect(store.get(pageSettingsAtom)).toEqual({
-      page0: {
-        mode: 'page',
-      },
-    });
-
-    expect(store.get(recentPageIdsBaseAtom)).toEqual(['page0']);
-
-    const page1SettingAtom = pageSettingFamily('page1');
-    store.set(page1SettingAtom, {
-      mode: 'edgeless',
-    });
-    expect(store.get(recentPageIdsBaseAtom)).toEqual(['page1', 'page0']);
-  });
-});

packages/frontend/core/src/atoms/index.ts

@@ -1,7 +1,5 @@
-import type { PrimitiveAtom } from 'jotai';
 import { atom } from 'jotai';
-import { atomFamily, atomWithStorage } from 'jotai/utils';
-import type { AtomFamily } from 'jotai/vanilla/utils/atomFamily';
+import { atomWithStorage } from 'jotai/utils';
 
 import type { AuthProps } from '../components/affine/auth';
 import type { CreateWorkspaceMode } from '../components/affine/create-workspace-modal';
@@ -45,66 +43,11 @@ export const authAtom = atom<AuthAtom>({
 
 export const openDisableCloudAlertModalAtom = atom(false);
 
-export type PageMode = 'page' | 'edgeless';
-type PageLocalSetting = {
-  mode: PageMode;
-};
-
-const pageSettingsBaseAtom = atomWithStorage(
-  'pageSettings',
-  {} as Record<string, PageLocalSetting>
-);
-
-// readonly atom by design
-export const pageSettingsAtom = atom(get => get(pageSettingsBaseAtom));
-
 export const recentPageIdsBaseAtom = atomWithStorage<string[]>(
   'recentPageSettings',
   []
 );
 
-const defaultPageSetting = {
-  mode: 'page',
-} satisfies PageLocalSetting;
-
-export const pageSettingFamily: AtomFamily<
-  string,
-  PrimitiveAtom<PageLocalSetting>
-> = atomFamily((pageId: string) =>
-  atom(
-    get =>
-      get(pageSettingsBaseAtom)[pageId] ?? {
-        ...defaultPageSetting,
-      },
-    (get, set, patch) => {
-      // fixme: this does not work when page reload,
-      // since atomWithStorage is async
-      set(recentPageIdsBaseAtom, ids => {
-        // pick 3 recent page ids
-        return [...new Set([pageId, ...ids]).values()].slice(0, 3);
-      });
-      const prevSetting = {
-        ...defaultPageSetting,
-        ...get(pageSettingsBaseAtom)[pageId],
-      };
-      set(pageSettingsBaseAtom, settings => ({
-        ...settings,
-        [pageId]: {
-          ...prevSetting,
-          ...(typeof patch === 'function' ? patch(prevSetting) : patch),
-        },
-      }));
-    }
-  )
-);
-
-export const setPageModeAtom = atom(
-  void 0,
-  (_, set, pageId: string, mode: PageMode) => {
-    set(pageSettingFamily(pageId), { mode });
-  }
-);
-
 export type PageModeOption = 'all' | 'page' | 'edgeless';
 export const allPageModeSelectAtom = atom<PageModeOption>('all');
 

packages/frontend/core/src/atoms/mode.ts

@@ -1,13 +0,0 @@
-import { atom } from 'jotai/vanilla';
-
-import { pageSettingFamily } from './index';
-
-export const currentPageIdAtom = atom<string | null>(null);
-
-export const currentModeAtom = atom<'page' | 'edgeless'>(get => {
-  const pageId = get(currentPageIdAtom);
-  if (!pageId) {
-    return 'page';
-  }
-  return get(pageSettingFamily(pageId)).mode;
-});