From 68ab7d3968fcfc3db7e355a7817e9bf2438e9462 Mon Sep 17 00:00:00 2001 From: Lynette Lopez Date: Wed, 28 Sep 2022 20:54:51 -0500 Subject: [PATCH 1/2] Remove double exclammation mark for function that already returns a boolean --- libs/components/common/src/lib/text/EditableText.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/components/common/src/lib/text/EditableText.tsx b/libs/components/common/src/lib/text/EditableText.tsx index 87c111544a..57509e9379 100644 --- a/libs/components/common/src/lib/text/EditableText.tsx +++ b/libs/components/common/src/lib/text/EditableText.tsx @@ -551,7 +551,7 @@ export const Text = forwardRef((props, ref) => { } } // markdown interception - if (supportMarkdown && !!handleMarkdown(e)) { + if (supportMarkdown && handleMarkdown(e)) { const start_selection = utils.current.getStartSelection(); utils.current.setSelection(start_selection); e.preventDefault(); From 1e0614ff5657e49279f4acb284e2f6e35619e232 Mon Sep 17 00:00:00 2001 From: Lynette Lopez Date: Wed, 28 Sep 2022 20:55:26 -0500 Subject: [PATCH 2/2] Move selection mark/cursor to end of markdown once done processing --- libs/components/common/src/lib/text/EditableText.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/components/common/src/lib/text/EditableText.tsx b/libs/components/common/src/lib/text/EditableText.tsx index 57509e9379..ba7ffad621 100644 --- a/libs/components/common/src/lib/text/EditableText.tsx +++ b/libs/components/common/src/lib/text/EditableText.tsx @@ -552,8 +552,8 @@ export const Text = forwardRef((props, ref) => { } // markdown interception if (supportMarkdown && handleMarkdown(e)) { - const start_selection = utils.current.getStartSelection(); - utils.current.setSelection(start_selection); + const endOfMarkdown = utils.current.getEndSelection(); + utils.current.setSelection(endOfMarkdown); e.preventDefault(); return true; }