From aa3b97b05644b572cab0c1d6c92000db3009f60f Mon Sep 17 00:00:00 2001 From: LongYinan Date: Thu, 14 Sep 2023 01:47:15 -0700 Subject: [PATCH] style: imporve tsconfig (#4358) --- apps/core/src/utils/user-setting.ts | 2 +- .../page-list/__tests__/use-all-page-setting.spec.ts | 2 +- tsconfig.json | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/core/src/utils/user-setting.ts b/apps/core/src/utils/user-setting.ts index 06122f99d3..8e4ced7f73 100644 --- a/apps/core/src/utils/user-setting.ts +++ b/apps/core/src/utils/user-setting.ts @@ -164,7 +164,7 @@ const pageCollectionBaseAtom = atomWithObservable(get => { export const currentCollectionsAtom: CollectionsAtom = atom( get => get(pageCollectionBaseAtom), - async (get, set, apply) => { + async (get, _, apply) => { const collections = await get(pageCollectionBaseAtom); let newCollections: Collection[]; if (typeof apply === 'function') { diff --git a/packages/component/src/components/page-list/__tests__/use-all-page-setting.spec.ts b/packages/component/src/components/page-list/__tests__/use-all-page-setting.spec.ts index 4e083b0954..ef21a293cd 100644 --- a/packages/component/src/components/page-list/__tests__/use-all-page-setting.spec.ts +++ b/packages/component/src/components/page-list/__tests__/use-all-page-setting.spec.ts @@ -20,7 +20,7 @@ const baseAtom = atom([]); const mockAtom: CollectionsAtom = atom( get => get(baseAtom), - async (get, set, update) => { + async (_, set, update) => { set(baseAtom, update); } ); diff --git a/tsconfig.json b/tsconfig.json index 0da03a3fae..1f1b9668ac 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -5,16 +5,16 @@ // Type Checking "strict": true, - // exactOptionalPropertyTypes: false, + "exactOptionalPropertyTypes": false, "noFallthroughCasesInSwitch": true, "noImplicitAny": true, "noImplicitOverride": true, "noImplicitReturns": true, "noImplicitThis": true, - // "noUnusedLocals": true, - // "noUnusedParameters": true, - // noPropertyAccessFromIndexSignature: false, - // noUncheckedIndexedAccess: false, + "noUnusedLocals": true, + "noUnusedParameters": true, + "noPropertyAccessFromIndexSignature": false, + "noUncheckedIndexedAccess": false, "useUnknownInCatchVariables": true, // Modules