mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-02-21 08:17:10 +08:00
fix(core): some ux enhancements on comments (#13105)
fix PD-2688 #### PR Dependency Tree * **PR #13105** 👈 This tree was auto-generated by [Charcoal](https://github.com/danerwilliams/charcoal) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit * **New Features** * Added configurable support for enabling or disabling inline comments. * Introduced visual indication (strikethrough) for deleted comments in the comment sidebar. * Sidebar now shows when a comment is no longer present in the editor. * Added a localized placeholder prompt ("What are your thoughts?") in the comment editor. * Integrated detailed event tracking for comment actions: create, edit, delete, and resolve. * **Improvements** * Inline comments are now disabled in shared mode. * Enhanced synchronization between editor comments and provider state to remove stale comments. * Inline comment features now respect the document’s read-only state. * Improved mention handling and tracking in comment creation and editing. * Comment manager and entities now dynamically track comments present in the editor. * Comment configuration updated to enable or disable inline comments based on settings. * **Bug Fixes** * Prevented comment block creation when in read-only mode. * **Localization** * Added English localization for the comment prompt. <!-- end of auto-generated comment: release notes by coderabbit.ai --> #### PR Dependency Tree * **PR #13105** 👈 This tree was auto-generated by [Charcoal](https://github.com/danerwilliams/charcoal)
This commit is contained in:
@@ -198,6 +198,15 @@ type WorkspaceEmbeddingEvents =
|
||||
| 'addIgnoredDocs';
|
||||
// END SECTION
|
||||
|
||||
// SECTION: comment events
|
||||
// Add events for comment actions
|
||||
type CommentEvents =
|
||||
| 'createComment'
|
||||
| 'editComment'
|
||||
| 'deleteComment'
|
||||
| 'resolveComment';
|
||||
// END SECTION
|
||||
|
||||
type UserEvents =
|
||||
| GeneralEvents
|
||||
| AppEvents
|
||||
@@ -215,6 +224,7 @@ type UserEvents =
|
||||
| PaymentEvents
|
||||
| DNDEvents
|
||||
| AIEvents
|
||||
| CommentEvents
|
||||
| AttachmentEvents
|
||||
| TemplateEvents
|
||||
| NotificationEvents
|
||||
@@ -421,6 +431,9 @@ interface PageEvents extends PageDivision {
|
||||
chatPanel: {
|
||||
chatPanelInput: ['addEmbeddingDoc'];
|
||||
};
|
||||
commentPanel: {
|
||||
$: ['createComment', 'editComment', 'deleteComment', 'resolveComment'];
|
||||
};
|
||||
attachment: {
|
||||
$: [
|
||||
'openAttachmentInFullscreen',
|
||||
@@ -807,6 +820,15 @@ export type EventArgs = {
|
||||
navigatePinedCollectionRouter: {
|
||||
control: 'all' | 'user-custom-collection';
|
||||
};
|
||||
resolveComment: { type: 'on' | 'off' };
|
||||
createComment: {
|
||||
type: 'root' | 'node';
|
||||
withAttachment: boolean;
|
||||
withMention: boolean;
|
||||
category: string;
|
||||
};
|
||||
editComment: { type: 'root' | 'node' };
|
||||
deleteComment: { type: 'root' | 'node' };
|
||||
};
|
||||
|
||||
// for type checking
|
||||
|
||||
Reference in New Issue
Block a user