From 8e1bf90ebdaa7e9cb66634bca7d214592967f835 Mon Sep 17 00:00:00 2001 From: Chi Zhang Date: Tue, 3 Jan 2023 13:39:24 +0800 Subject: [PATCH] feat: improve document remove & title (#657) * fix: cancel delete, do not show toast * feat: support document title sync page title --- .../components/header/header-right-items/editor-option-menu.tsx | 2 +- packages/app/src/pages/workspace/[workspaceId]/[pageId].tsx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/app/src/components/header/header-right-items/editor-option-menu.tsx b/packages/app/src/components/header/header-right-items/editor-option-menu.tsx index 24a07245ee..ea71aef757 100644 --- a/packages/app/src/components/header/header-right-items/editor-option-menu.tsx +++ b/packages/app/src/components/header/header-right-items/editor-option-menu.tsx @@ -87,7 +87,7 @@ const PopoverContent = () => { confirmType: 'danger', }).then(confirm => { confirm && toggleDeletePage(id); - toast('Moved to Trash'); + confirm && toast('Moved to Trash'); }); }} icon={} diff --git a/packages/app/src/pages/workspace/[workspaceId]/[pageId].tsx b/packages/app/src/pages/workspace/[workspaceId]/[pageId].tsx index 726a23b677..971e950f8b 100644 --- a/packages/app/src/pages/workspace/[workspaceId]/[pageId].tsx +++ b/packages/app/src/pages/workspace/[workspaceId]/[pageId].tsx @@ -68,6 +68,7 @@ const Page: NextPageWithLayout = () => { } } + document.title = currentPage?.meta.title || 'Untitled'; return ret; }, [currentWorkspace, currentPage, createEditor, setEditor]);