chore: remove preloading pages (#5854)

tests/affine-desktop/e2e/basic.spec.ts

@@ -1,6 +1,9 @@
 import { test } from '@affine-test/kit/electron';
 import { withCtrlOrMeta } from '@affine-test/kit/utils/keyboard';
-import { getBlockSuiteEditorTitle } from '@affine-test/kit/utils/page-logic';
+import {
+  clickNewPageButton,
+  getBlockSuiteEditorTitle,
+} from '@affine-test/kit/utils/page-logic';
 import {
   clickSideBarCurrentWorkspaceBanner,
   clickSideBarSettingButton,
@@ -28,9 +31,7 @@ test('app sidebar router forward/back', async ({ page }) => {
   {
     // create pages
     await page.waitForTimeout(500);
-    await page.getByTestId('sidebar-new-page-button').click({
-      delay: 100,
-    });
+    await clickNewPageButton(page);
     await page.waitForSelector('v-line');
     const title = getBlockSuiteEditorTitle(page);
     await title.focus();

tests/affine-local/e2e/all-page.spec.ts

@@ -14,6 +14,7 @@ import {
 } from '@affine-test/kit/utils/filter';
 import { openHomePage } from '@affine-test/kit/utils/load-page';
 import {
+  clickNewPageButton,
   getBlockSuiteEditorTitle,
   waitForAllPagesLoad,
   waitForEditorLoad,
@@ -118,7 +119,7 @@ test('allow creation of filters by tags', async ({ page }) => {
     .locator('[data-testid="page-list-item"]')
     .all();
   const pagesWithTagsCount = pagesWithTags.length;
-  expect(pagesWithTagsCount).not.toBe(0);
+  expect(pagesWithTagsCount).toBe(0);
   await createPageWithTag(page, { title: 'Page A', tags: ['Page A'] });
   await createPageWithTag(page, { title: 'Page B', tags: ['Page B'] });
   await clickSideBarAllPageButton(page);
@@ -183,6 +184,7 @@ test('enable selection and use ESC to disable selection', async ({ page }) => {
 test('select two pages and delete', async ({ page }) => {
   await openHomePage(page);
   await waitForEditorLoad(page);
+  await clickNewPageButton(page);
   await clickSideBarAllPageButton(page);
   await waitForAllPagesLoad(page);
 
@@ -229,6 +231,7 @@ test('select a group of items by clicking "Select All" in group header', async (
 }) => {
   await openHomePage(page);
   await waitForEditorLoad(page);
+  await clickNewPageButton(page);
   await clickSideBarAllPageButton(page);
   await waitForAllPagesLoad(page);
 

tests/affine-local/e2e/change-page-mode.spec.ts

@@ -1,6 +1,7 @@
 import { test } from '@affine-test/kit/playwright';
 import { openHomePage } from '@affine-test/kit/utils/load-page';
 import {
+  clickNewPageButton,
   clickPageMoreActions,
   waitForEditorLoad,
 } from '@affine-test/kit/utils/page-logic';
@@ -15,6 +16,7 @@ test('Switch to edgeless by switch edgeless item', async ({ page }) => {
   }
   await openHomePage(page);
   await waitForEditorLoad(page);
+  await clickNewPageButton(page);
   const btn = page.getByTestId('switch-edgeless-mode-button');
   await page.evaluate(() => {
     // @ts-expect-error
@@ -56,6 +58,7 @@ test('Switch to edgeless by switch edgeless item', async ({ page }) => {
 test('Convert to edgeless by editor header items', async ({ page }) => {
   await openHomePage(page);
   await waitForEditorLoad(page);
+  await clickNewPageButton(page);
   await clickPageMoreActions(page);
   const menusEdgelessItem = page.getByTestId('editor-option-menu-edgeless');
   await menusEdgelessItem.click({ delay: 100 });

tests/affine-local/e2e/local-first-favorites-items.spec.ts

@@ -135,6 +135,7 @@ test("Deleted page's reference will not be shown in sidebar", async ({
 test('Add new favorite page via sidebar', async ({ page }) => {
   await openHomePage(page);
   await waitForEditorLoad(page);
+  await clickNewPageButton(page);
   await page.getByTestId('slider-bar-add-favorite-button').first().click();
   await waitForEmptyEditor(page);
 

tests/affine-local/e2e/local-first-workspace-list.spec.ts

@@ -50,11 +50,11 @@ test('create one workspace in the workspace list', async ({
   await clickSideBarAllPageButton(page);
   await page.waitForTimeout(2000);
   const result = await getPagesCount(page);
-  expect(result).toBe(11);
+  expect(result).toBe(1);
   await page.reload();
   await page.waitForTimeout(4000);
   const result1 = await getPagesCount(page);
-  expect(result1).toBe(11);
+  expect(result1).toBe(1);
   const currentWorkspace = await workspace.current();
 
   expect(currentWorkspace.meta.flavour).toContain('local');

tests/affine-local/e2e/open-affine.spec.ts

@@ -40,11 +40,3 @@ test('Download client tip', async ({ page }) => {
   );
   await expect(currentLocalDemoTipsItemItem).toBeVisible();
 });
-
-test('Check the class name for the scrollbar', async ({ page }) => {
-  //Because the scroll bar in page mode depends on the class name of blocksuite
-  await openHomePage(page);
-  await waitForEditorLoad(page);
-  const affineDocViewport = page.locator('.affine-doc-viewport');
-  await expect(affineDocViewport).toBeVisible();
-});

tests/affine-local/e2e/quick-search.spec.ts

@@ -12,7 +12,7 @@ import { expect, type Locator, type Page } from '@playwright/test';
 const openQuickSearchByShortcut = async (page: Page, checkVisible = true) => {
   await withCtrlOrMeta(page, () => page.keyboard.press('k', { delay: 50 }));
   if (checkVisible) {
-    expect(page.getByTestId('cmdk-quick-search')).toBeVisible();
+    await expect(page.getByTestId('cmdk-quick-search')).toBeVisible();
   }
 };
 
@@ -367,6 +367,7 @@ test('can use cmdk to delete page and restore it', async ({ page }) => {
   await page.getByTestId('confirm-delete-page').click();
   const restoreButton = page.getByTestId('page-restore-button');
   await expect(restoreButton).toBeVisible();
+  await page.waitForTimeout(100);
   await openQuickSearchByShortcut(page);
   expect(await commandsIsVisible(page, 'Move to Trash')).toBe(false);
   expect(await commandsIsVisible(page, 'Export to PDF')).toBe(false);

tests/kit/utils/page-logic.ts

@@ -15,6 +15,13 @@ export async function waitForAllPagesLoad(page: Page) {
 }
 
 export async function clickNewPageButton(page: Page) {
+  //FiXME: when the page is in edgeless mode, clickNewPageButton will create a new edgeless page
+  const edgelessPage = page.locator('edgeless-editor');
+  if (await edgelessPage.isVisible()) {
+    await page.getByTestId('switch-page-mode-button').click({
+      delay: 100,
+    });
+  }
   // fixme(himself65): if too fast, the page will crash
   await page.getByTestId('sidebar-new-page-button').click({
     delay: 100,