Jayden/AFFiNE-Mirror
0
0
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2026-08-03 18:40:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): improve pdf embed viewer UX (#11641)

Browse Source 
Closes: [BS-3101](https://linear.app/affine-design/issue/BS-3101/pdf-embed-模式的选中框选-和点开看详情有比较大的问题)

### What's Changed!

* Fixed disable pointer event in native pdf viewer by dragging
* Disable opening peek view with pdf viewer in readonly and sharing modes
This commit is contained in:
fundon
2025-04-15 08:51:02 +00:00
parent 0df584bd5e
commit 8ca675b2ec
8 changed files with 203 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/affine-cloud/e2e/share-page.spec.ts
+59
View File
@@ -1,4 +1,5 @@
import { skipOnboarding, test } from '@affine-test/kit/playwright';
import { importAttachment } from '@affine-test/kit/utils/attachment';
import {
createRandomUser,
enableCloudWorkspaceFromShareButton,
@@ -8,6 +9,7 @@ import {
import {
clickEdgelessModeButton,
getParagraphIds,
locateToolbar,
} from '@affine-test/kit/utils/editor';
import { importImage } from '@affine-test/kit/utils/image';
import { copyByKeyboard } from '@affine-test/kit/utils/keyboard';
@@ -455,3 +457,60 @@ test('share page should support copying content', async ({ page, browser }) => {
expect(copiedText).toContain('Hello World');
}
});
test('should disable opening peek view with pdf viewer in readonly and sharing modes', async ({
page,
browser,
}) => {
await page.reload();
await waitForEditorLoad(page);
await createLocalWorkspace(
{
name: 'test',
},
page
);
await enableCloudWorkspaceFromShareButton(page);
const title = getBlockSuiteEditorTitle(page);
await title.click();
await page.keyboard.press('Enter');
await importAttachment(page, 'lorem-ipsum.pdf');
const toolbar = locateToolbar(page);
const switchViewButton = toolbar.getByLabel('Switch view');
const embedViewButton = toolbar.getByLabel('Embed view');
const attachment = page.locator('affine-attachment');
await attachment.click();
await switchViewButton.click();
await embedViewButton.click();
await expect(attachment.locator('iframe')).toBeVisible();
// enable share page and copy page link
await enableShare(page);
await page.getByTestId('share-menu-copy-link-button').click();
await page.getByTestId('share-link-menu-copy-page').click();
// check share page is accessible
{
const context = await browser.newContext();
await skipOnboarding(context);
const url: string = await page.evaluate(() =>
navigator.clipboard.readText()
);
const page2 = await context.newPage();
await page2.goto(url);
await waitForEditorLoad(page2);
const attachment = page2.locator('affine-attachment');
await expect(attachment.locator('iframe')).toBeVisible();
await attachment.dblclick();
const pdfViewer = page2.getByTestId('pdf-viewer');
await expect(pdfViewer).not.toBeVisible();
}
});