fix: message wrong about favourites (#669)

* fix: wrong message
* chore: update type

packages/app/src/components/contact-modal/index.tsx

@@ -57,7 +57,10 @@ type TransitionsModalProps = {
   onClose: () => void;
 };
 
-export const ContactModal = ({ open, onClose }: TransitionsModalProps) => {
+export const ContactModal = ({
+  open,
+  onClose,
+}: TransitionsModalProps): JSX.Element => {
   const { t } = useTranslation();
   const rightLinkList = [
     {

packages/app/src/components/header/header-right-items/editor-option-menu.tsx

@@ -37,12 +37,12 @@ const PopoverContent = () => {
         onClick={() => {
           toggleFavoritePage(id);
           toast(
-            !favorite ? t('Removed to Favourites') : t('Added to Favourites')
+            favorite ? t('Removed from Favourites') : t('Added to Favourites')
           );
         }}
         icon={favorite ? <FavouritedIcon /> : <FavouritesIcon />}
       >
-        {favorite ? t('Remove to favourites') : t('Add to favourites')}
+        {favorite ? t('Remove from favourites') : t('Add to favourites')}
       </MenuItem>
       <MenuItem
         icon={mode === 'page' ? <EdgelessIcon /> : <PaperIcon />}

packages/app/src/components/page-list/index.tsx

@@ -45,7 +45,7 @@ const FavoriteTag = ({
           e.stopPropagation();
           toggleFavoritePage(id);
           toast(
-            !favorite ? t('Removed to Favourites') : t('Added to Favourites')
+            favorite ? t('Removed from Favourites') : t('Added to Favourites')
           );
         }}
         style={{

packages/app/src/components/page-list/operation-cell.tsx

@@ -27,12 +27,12 @@ export const OperationCell = ({ pageMeta }: { pageMeta: PageMeta }) => {
         onClick={() => {
           toggleFavoritePage(id);
           toast(
-            !favorite ? t('Removed to Favourites') : t('Added to Favourites')
+            favorite ? t('Removed from Favourites') : t('Added to Favourites')
           );
         }}
         icon={favorite ? <FavouritedIcon /> : <FavouritesIcon />}
       >
-        {favorite ? t('Remove to favourites') : t('Add to favourites')}
+        {favorite ? t('Remove from favourites') : t('Add to favourites')}
       </MenuItem>
       <MenuItem
         onClick={() => {

packages/app/src/components/quick-search/config.ts

@@ -1,6 +1,13 @@
 import { AllPagesIcon, FavouritesIcon, TrashIcon } from '@blocksuite/icons';
 import { useTranslation } from 'react-i18next';
-export const useSwitchToConfig = (currentWorkspaceId: string) => {
+
+export const useSwitchToConfig = (
+  currentWorkspaceId: string
+): {
+  title: string;
+  href: string;
+  icon: React.FC<React.SVGProps<SVGSVGElement>>;
+}[] => {
   const { t } = useTranslation();
   const List = [
     {

packages/app/src/components/shortcuts-modal/config.ts

@@ -1,5 +1,8 @@
 import { useTranslation } from 'react-i18next';
-export const useMacKeyboardShortcuts = () => {
+interface ShortcutTip {
+  [x: string]: string;
+}
+export const useMacKeyboardShortcuts = (): ShortcutTip => {
   const { t } = useTranslation();
   return {
     [t('Undo')]: '⌘+Z',
@@ -23,7 +26,7 @@ export const useMacKeyboardShortcuts = () => {
   };
 };
 
-export const useMacMarkdownShortcuts = () => {
+export const useMacMarkdownShortcuts = (): ShortcutTip => {
   const { t } = useTranslation();
   return {
     [t('Bold')]: '**Text** ',
@@ -42,7 +45,7 @@ export const useMacMarkdownShortcuts = () => {
   };
 };
 
-export const useWindowsKeyboardShortcuts = () => {
+export const useWindowsKeyboardShortcuts = (): ShortcutTip => {
   const { t } = useTranslation();
   return {
     [t('Undo')]: 'Ctrl+Z',
@@ -65,7 +68,7 @@ export const useWindowsKeyboardShortcuts = () => {
     [t('Reduce indent')]: 'Shift+Tab',
   };
 };
-export const useWinMarkdownShortcuts = () => {
+export const useWinMarkdownShortcuts = (): ShortcutTip => {
   const { t } = useTranslation();
   return {
     [t('Bold')]: '**Text** ',

packages/app/src/libs/i18n/resources/en.json

@@ -11,8 +11,8 @@
   "Find results": "Find {{number}} results",
   "Collapse sidebar": "Collapse sidebar",
   "Expand sidebar": "Expand sidebar",
-  "Removed to Favourites": "Removed to Favourites",
+  "Removed from Favourites": "Removed from Favourites",
-  "Remove to favourites": "Remove to favourites",
+  "Remove from favourites": "Remove from favourites",
   "Added to Favourites": "Added to Favourites",
   "Add to favourites": "Add to favourites",
   "Paper": "Paper",