fix(electron): potential crash on quit (#8855)

packages/frontend/apps/electron/src/main/windows-manager/main-window.ts

@@ -5,6 +5,7 @@ import electronWindowState from 'electron-window-state';
 import { BehaviorSubject } from 'rxjs';
 
 import { isLinux, isMacOS, isWindows } from '../../shared/utils';
+import { beforeAppQuit } from '../cleanup';
 import { buildType } from '../config';
 import { mainWindowOrigin } from '../constants';
 import { ensureHelperProcess } from '../helper-process';
@@ -116,11 +117,17 @@ export class MainWindowManager {
       uiSubjects.onFullScreen$.next(mainWindow.isFullScreen());
     });
 
+    beforeAppQuit(() => {
+      this.cleanupWindows();
+    });
+
     mainWindow.on('close', e => {
       // TODO(@pengx17): gracefully close the app, for example, ask user to save unsaved changes
       e.preventDefault();
       if (!isMacOS()) {
         closeAllWindows();
+        this.mainWindowReady = undefined;
+        this.mainWindow$.next(undefined);
       } else {
         // hide window on macOS
         // application quit will be handled by closing the hidden window

packages/frontend/apps/electron/src/main/windows-manager/tab-views.ts

@@ -25,6 +25,7 @@ import {
 } from 'rxjs';
 
 import { isMacOS } from '../../shared/utils';
+import { beforeAppQuit } from '../cleanup';
 import { CLOUD_BASE_URL, isDev } from '../config';
 import { mainWindowOrigin, shellViewUrl } from '../constants';
 import { ensureHelperProcess } from '../helper-process';
@@ -749,8 +750,10 @@ export class WebContentViewsManager {
       })
     );
 
-    app.on('before-quit', () => {
-      disposables.forEach(d => d.unsubscribe());
+    disposables.forEach(d => {
+      beforeAppQuit(() => {
+        d.unsubscribe();
+      });
     });
 
     const focusActiveView = () => {