From 85bee72e6b92d406661af719115388fbb7074ea1 Mon Sep 17 00:00:00 2001
From: liuyi <forehalo@gmail.com>
Date: Wed, 22 Nov 2023 03:51:17 +0000
Subject: [PATCH] chore(server): remove deprecated redis manager (#4971)

---
 .../backend/server/src/modules/doc/index.ts   |   5 +-
 .../server/src/modules/doc/redis-manager.ts   | 129 ------------------
 2 files changed, 1 insertion(+), 133 deletions(-)
 delete mode 100644 packages/backend/server/src/modules/doc/redis-manager.ts

diff --git a/packages/backend/server/src/modules/doc/index.ts b/packages/backend/server/src/modules/doc/index.ts
index 806d3f157f..54dd6e95ec 100644
--- a/packages/backend/server/src/modules/doc/index.ts
+++ b/packages/backend/server/src/modules/doc/index.ts
@@ -1,7 +1,6 @@
 import { DynamicModule } from '@nestjs/common';
 
 import { DocManager } from './manager';
-import { RedisDocManager } from './redis-manager';
 
 export class DocModule {
   /**
@@ -17,9 +16,7 @@ export class DocModule {
         },
         {
           provide: DocManager,
-          useClass: globalThis.AFFiNE.redis.enabled
-            ? RedisDocManager
-            : DocManager,
+          useClass: DocManager,
         },
       ],
       exports: [DocManager],
diff --git a/packages/backend/server/src/modules/doc/redis-manager.ts b/packages/backend/server/src/modules/doc/redis-manager.ts
deleted file mode 100644
index 3ae69c3b26..0000000000
--- a/packages/backend/server/src/modules/doc/redis-manager.ts
+++ /dev/null
@@ -1,129 +0,0 @@
-import { Inject, Injectable } from '@nestjs/common';
-import Redis from 'ioredis';
-
-import { Config } from '../../config';
-import { Metrics } from '../../metrics/metrics';
-import { PrismaService } from '../../prisma';
-import { DocID } from '../../utils/doc';
-import { DocManager } from './manager';
-
-function makeKey(prefix: string) {
-  return (parts: TemplateStringsArray, ...args: any[]) => {
-    return parts.reduce((prev, curr, i) => {
-      return prev + curr + (args[i] || '');
-    }, prefix);
-  };
-}
-
-const pending = 'um_pending:';
-const updates = makeKey('um_u:');
-const lock = makeKey('um_l:');
-
-const pushUpdateLua = `
-    redis.call('sadd', KEYS[1], ARGV[1])
-    redis.call('rpush', KEYS[2], ARGV[2])
-`;
-
-/**
- * @deprecated unstable
- */
-@Injectable()
-export class RedisDocManager extends DocManager {
-  private readonly redis: Redis;
-
-  constructor(
-    protected override readonly db: PrismaService,
-    @Inject('DOC_MANAGER_AUTOMATION')
-    protected override readonly automation: boolean,
-    protected override readonly config: Config,
-    protected override readonly metrics: Metrics
-  ) {
-    super(db, automation, config, metrics);
-    this.redis = new Redis(config.redis);
-    this.redis.defineCommand('pushDocUpdate', {
-      numberOfKeys: 2,
-      lua: pushUpdateLua,
-    });
-  }
-
-  override onModuleInit(): void {
-    if (this.automation) {
-      this.setup();
-    }
-  }
-
-  override async autoSquash(): Promise<void> {
-    // incase some update fallback to db
-    await super.autoSquash();
-
-    // consume rest updates in redis queue
-    const pendingDoc = await this.redis.spop(pending).catch(() => null); // safe
-
-    if (!pendingDoc) {
-      return;
-    }
-
-    const docId = new DocID(pendingDoc);
-    const updateKey = updates`${pendingDoc}`;
-    const lockKey = lock`${pendingDoc}`;
-
-    // acquire the lock
-    const lockResult = await this.redis
-      .set(
-        lockKey,
-        '1',
-        'EX',
-        // 10mins, incase progress exit in between lock require & release, which is a rare.
-        // if the lock is really hold more then 10mins, we should check the merge logic correctness
-        600,
-        'NX'
-      )
-      .catch(() => null); // safe;
-
-    if (!lockResult) {
-      // we failed to acquire the lock, put the pending doc back to queue.
-      await this.redis.sadd(pending, pendingDoc).catch(() => null); // safe
-      return;
-    }
-
-    try {
-      // fetch pending updates
-      const updates = await this.redis
-        .lrangeBuffer(updateKey, 0, -1)
-        .catch(() => []); // safe
-
-      if (!updates.length) {
-        return;
-      }
-
-      this.logger.verbose(
-        `applying ${updates.length} updates for workspace: ${docId}`
-      );
-
-      const snapshot = await this.getSnapshot(docId.workspace, docId.guid);
-
-      // merge
-      const doc = await (snapshot
-        ? this.applyUpdates(docId.full, snapshot.blob, ...updates)
-        : this.applyUpdates(docId.full, ...updates));
-
-      // update snapshot
-      await this.upsert(docId.workspace, docId.guid, doc, snapshot?.seq);
-
-      // delete merged updates
-      await this.redis
-        .ltrim(updateKey, updates.length, -1)
-        // safe, fallback to mergeUpdates
-        .catch(e => {
-          this.logger.error(`Failed to remove merged updates from Redis: ${e}`);
-        });
-    } catch (e) {
-      this.logger.error(
-        `Failed to merge updates with snapshot for ${docId}: ${e}`
-      );
-      await this.redis.sadd(pending, docId.toString()).catch(() => null); // safe
-    } finally {
-      await this.redis.del(lockKey);
-    }
-  }
-}