From 844b13af1fb48b6c3c9fb6d8042dae5b1e349090 Mon Sep 17 00:00:00 2001
From: pengx17 <pengxiao@outlook.com>
Date: Thu, 13 Mar 2025 04:47:23 +0000
Subject: [PATCH] fix(core): unsub in LiveData.fromSignal (#10756)

---
 packages/common/infra/src/livedata/livedata.ts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/common/infra/src/livedata/livedata.ts b/packages/common/infra/src/livedata/livedata.ts
index 16de3a9343..d6cf7495a1 100644
--- a/packages/common/infra/src/livedata/livedata.ts
+++ b/packages/common/infra/src/livedata/livedata.ts
@@ -144,9 +144,13 @@ export class LiveData<T = unknown>
   static fromSignal<T>(signal: ReadonlySignal<T>): LiveData<T> {
     return LiveData.from(
       new Observable(subscriber => {
-        signal.subscribe(value => {
+        const unsubscribe = signal.subscribe(value => {
           subscriber.next(value);
         });
+
+        return () => {
+          unsubscribe();
+        };
       }),
       signal.value
     );