mirror of
https://github.com/toeverything/AFFiNE.git
synced 2026-08-24 05:07:06 +08:00
fix(editor): throttle render linked doc card when blockUpdated (#9361)
[BS-2223](https://linear.app/affine-design/issue/BS-2223/性能问题:linked-doc-card-view加载西藏的文档,app-直接挂了)
This commit is contained in:
@@ -23,6 +23,12 @@ import { render, type TemplateResult } from 'lit';
|
|||||||
import type { EmbedLinkedDocBlockComponent } from '../embed-linked-doc-block/index.js';
|
import type { EmbedLinkedDocBlockComponent } from '../embed-linked-doc-block/index.js';
|
||||||
import type { EmbedSyncedDocCard } from '../embed-synced-doc-block/components/embed-synced-doc-card.js';
|
import type { EmbedSyncedDocCard } from '../embed-synced-doc-block/components/embed-synced-doc-card.js';
|
||||||
|
|
||||||
|
// Throttle delay for block updates to reduce unnecessary re-renders
|
||||||
|
// - Prevents rapid-fire updates when multiple blocks are updated in quick succession
|
||||||
|
// - Ensures UI remains responsive while maintaining performance
|
||||||
|
// - Small enough to feel instant to users, large enough to batch updates effectively
|
||||||
|
export const RENDER_CARD_THROTTLE_MS = 60;
|
||||||
|
|
||||||
export function renderLinkedDocInCard(
|
export function renderLinkedDocInCard(
|
||||||
card: EmbedLinkedDocBlockComponent | EmbedSyncedDocCard
|
card: EmbedLinkedDocBlockComponent | EmbedSyncedDocCard
|
||||||
) {
|
) {
|
||||||
|
|||||||
+24
-17
@@ -23,7 +23,7 @@ import {
|
|||||||
matchFlavours,
|
matchFlavours,
|
||||||
referenceToNode,
|
referenceToNode,
|
||||||
} from '@blocksuite/affine-shared/utils';
|
} from '@blocksuite/affine-shared/utils';
|
||||||
import { Bound } from '@blocksuite/global/utils';
|
import { Bound, throttle } from '@blocksuite/global/utils';
|
||||||
import { DocCollection } from '@blocksuite/store';
|
import { DocCollection } from '@blocksuite/store';
|
||||||
import { computed } from '@preact/signals-core';
|
import { computed } from '@preact/signals-core';
|
||||||
import { html, nothing } from 'lit';
|
import { html, nothing } from 'lit';
|
||||||
@@ -33,7 +33,10 @@ import { styleMap } from 'lit/directives/style-map.js';
|
|||||||
import { when } from 'lit/directives/when.js';
|
import { when } from 'lit/directives/when.js';
|
||||||
|
|
||||||
import { EmbedBlockComponent } from '../common/embed-block-element.js';
|
import { EmbedBlockComponent } from '../common/embed-block-element.js';
|
||||||
import { renderLinkedDocInCard } from '../common/render-linked-doc.js';
|
import {
|
||||||
|
RENDER_CARD_THROTTLE_MS,
|
||||||
|
renderLinkedDocInCard,
|
||||||
|
} from '../common/render-linked-doc.js';
|
||||||
import { SyncedDocErrorIcon } from '../embed-synced-doc-block/styles.js';
|
import { SyncedDocErrorIcon } from '../embed-synced-doc-block/styles.js';
|
||||||
import {
|
import {
|
||||||
type EmbedLinkedDocBlockConfig,
|
type EmbedLinkedDocBlockConfig,
|
||||||
@@ -301,24 +304,28 @@ export class EmbedLinkedDocBlockComponent extends EmbedBlockComponent<EmbedLinke
|
|||||||
});
|
});
|
||||||
})
|
})
|
||||||
);
|
);
|
||||||
|
// Should throttle the blockUpdated event to avoid too many re-renders
|
||||||
|
// Because the blockUpdated event is triggered too frequently at some cases
|
||||||
this.disposables.add(
|
this.disposables.add(
|
||||||
linkedDoc.slots.blockUpdated.on(payload => {
|
linkedDoc.slots.blockUpdated.on(
|
||||||
if (
|
throttle(payload => {
|
||||||
payload.type === 'update' &&
|
if (
|
||||||
['', 'caption', 'xywh'].includes(payload.props.key)
|
payload.type === 'update' &&
|
||||||
) {
|
['', 'caption', 'xywh'].includes(payload.props.key)
|
||||||
return;
|
) {
|
||||||
}
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
if (payload.type === 'add' && payload.init) {
|
if (payload.type === 'add' && payload.init) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
this._load().catch(e => {
|
this._load().catch(e => {
|
||||||
console.error(e);
|
console.error(e);
|
||||||
this.isError = true;
|
this.isError = true;
|
||||||
});
|
});
|
||||||
})
|
}, RENDER_CARD_THROTTLE_MS)
|
||||||
|
)
|
||||||
);
|
);
|
||||||
|
|
||||||
this._setDocUpdatedAt();
|
this._setDocUpdatedAt();
|
||||||
|
|||||||
+21
-14
@@ -1,11 +1,14 @@
|
|||||||
import { ThemeProvider } from '@blocksuite/affine-shared/services';
|
import { ThemeProvider } from '@blocksuite/affine-shared/services';
|
||||||
import { isGfxBlockComponent, ShadowlessElement } from '@blocksuite/block-std';
|
import { isGfxBlockComponent, ShadowlessElement } from '@blocksuite/block-std';
|
||||||
import { WithDisposable } from '@blocksuite/global/utils';
|
import { throttle, WithDisposable } from '@blocksuite/global/utils';
|
||||||
import { html, nothing } from 'lit';
|
import { html, nothing } from 'lit';
|
||||||
import { property, queryAsync } from 'lit/decorators.js';
|
import { property, queryAsync } from 'lit/decorators.js';
|
||||||
import { classMap } from 'lit/directives/class-map.js';
|
import { classMap } from 'lit/directives/class-map.js';
|
||||||
|
|
||||||
import { renderLinkedDocInCard } from '../../common/render-linked-doc.js';
|
import {
|
||||||
|
RENDER_CARD_THROTTLE_MS,
|
||||||
|
renderLinkedDocInCard,
|
||||||
|
} from '../../common/render-linked-doc.js';
|
||||||
import type { EmbedSyncedDocBlockComponent } from '../embed-synced-doc-block.js';
|
import type { EmbedSyncedDocBlockComponent } from '../embed-synced-doc-block.js';
|
||||||
import { cardStyles } from '../styles.js';
|
import { cardStyles } from '../styles.js';
|
||||||
import { getSyncedDocIcons } from '../utils.js';
|
import { getSyncedDocIcons } from '../utils.js';
|
||||||
@@ -101,19 +104,23 @@ export class EmbedSyncedDocCard extends WithDisposable(ShadowlessElement) {
|
|||||||
renderLinkedDocInCard(this);
|
renderLinkedDocInCard(this);
|
||||||
})
|
})
|
||||||
);
|
);
|
||||||
|
// Should throttle the blockUpdated event to avoid too many re-renders
|
||||||
|
// Because the blockUpdated event is triggered too frequently at some cases
|
||||||
this.disposables.add(
|
this.disposables.add(
|
||||||
syncedDoc.slots.blockUpdated.on(payload => {
|
syncedDoc.slots.blockUpdated.on(
|
||||||
if (this._dragging) {
|
throttle(payload => {
|
||||||
return;
|
if (this._dragging) {
|
||||||
}
|
return;
|
||||||
if (
|
}
|
||||||
payload.type === 'update' &&
|
if (
|
||||||
['', 'caption', 'xywh'].includes(payload.props.key)
|
payload.type === 'update' &&
|
||||||
) {
|
['', 'caption', 'xywh'].includes(payload.props.key)
|
||||||
return;
|
) {
|
||||||
}
|
return;
|
||||||
renderLinkedDocInCard(this);
|
}
|
||||||
})
|
renderLinkedDocInCard(this);
|
||||||
|
}, RENDER_CARD_THROTTLE_MS)
|
||||||
|
)
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user