chore: cleanup legacy logic (#15072)

packages/backend/server/src/plugins/payment/stripe.ts

@@ -7,7 +7,6 @@ import {
   decodeLookupKey,
   DEFAULT_PRICES,
   SubscriptionRecurring,
-  SubscriptionVariant,
 } from './types';
 
 @Injectable()
@@ -39,20 +38,18 @@ export class StripeFactory {
   }
 
   setup() {
-    // Prefer new keys under payment.stripe.*, fallback to legacy root keys for backward compatibility
     const {
-      apiKey: nestedApiKey,
+      apiKey,
       webhookKey: _,
       ...config
     } = this.config.payment.stripe || {};
     // NOTE:
     //   we always fake a key if not set because `new Stripe` will complain if it's empty string
     //   this will make code cleaner than providing `Stripe` instance as optional one.
-    const apiKey =
-      nestedApiKey || this.config.payment.apiKey || 'stripe-api-key';
+    const stripeApiKey = apiKey || 'stripe-api-key';
 
     // TODO@(@darkskygit): use per-requests api key injection
-    this.#stripe = new Stripe(apiKey, config);
+    this.#stripe = new Stripe(stripeApiKey, config);
     if (this.config.payment.enabled) {
       this.server.enableFeature(ServerFeature.Payment);
     } else {
@@ -107,8 +104,7 @@ export class StripeFactory {
           lookup_key: key,
           tax_behavior: 'inclusive',
           recurring:
-            lookupKey.recurring === SubscriptionRecurring.Lifetime ||
-            lookupKey.variant === SubscriptionVariant.Onetime
+            lookupKey.recurring === SubscriptionRecurring.Lifetime
               ? undefined
               : {
                   interval: