From 7dbb85c8c221309b322c450c0bf4d6a9919584fe Mon Sep 17 00:00:00 2001 From: doouding Date: Fri, 27 Dec 2024 07:07:53 +0000 Subject: [PATCH] fix: sentry AFFINE-84T (#9368) Fixes [BS-2243](https://linear.app/affine-design/issue/BS-2243/typeerror-cannot-read-properties-of-undefined-reading-length) --- .../src/root-block/edgeless/edgeless-keyboard.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/blocksuite/blocks/src/root-block/edgeless/edgeless-keyboard.ts b/blocksuite/blocks/src/root-block/edgeless/edgeless-keyboard.ts index 3e8750adde..a8d6cc3d9a 100644 --- a/blocksuite/blocks/src/root-block/edgeless/edgeless-keyboard.ts +++ b/blocksuite/blocks/src/root-block/edgeless/edgeless-keyboard.ts @@ -436,13 +436,15 @@ export class EdgelessPageKeyboardManager extends PageKeyboardManager { 'keyDown', ctx => { const event = ctx.get('keyboardState').raw; - const service = this.rootComponent.service; - const selection = service.selection; + const gfx = this.rootComponent.gfx; + const selection = gfx.selection; + if (event.code === 'Space' && !event.repeat) { this._space(event); } else if ( !selection.editing && - event.key.length === 1 && + // the key might be `Unidentified` according to mdn + event.key?.length === 1 && !event.shiftKey && !event.ctrlKey && !event.altKey && @@ -452,7 +454,7 @@ export class EdgelessPageKeyboardManager extends PageKeyboardManager { const doc = this.rootComponent.doc; if (isSingleMindMapNode(elements)) { - const target = service.getElementById( + const target = gfx.getElementById( elements[0].id ) as ShapeElementModel; if (target.text) {